Skip to content

[No QA] Docs updates for E/A#91176 Add file import cross-references for company cards#91365

Merged
brianlee-expensify merged 2 commits into
mainfrom
claude-docsUpdateCSVCardImportGA
May 28, 2026
Merged

[No QA] Docs updates for E/A#91176 Add file import cross-references for company cards#91365
brianlee-expensify merged 2 commits into
mainfrom
claude-docsUpdateCSVCardImportGA

Conversation

@MelvinBot

Copy link
Copy Markdown
Contributor

Summary

  • Adds cross-references to the Import Company Card Transactions From a Spreadsheet article from the Direct Feed, Commercial Feed, and Assign Company Cards articles, now that the CSV card import feature is generally available (beta removed in Remove CSV Card Import beta #91176).
  • Fixes "XLX" → "XLS" typos in the existing file import article.

Changed articles

  • Import-Company-Card-Transactions-From-a-Spreadsheet.md — fixed file extension typos (XLX → XLS)
  • Assign-Company-Cards.md — added link to file import article in prerequisites
  • Set-up-a-Commercial-Card-Feed-Connection.md — added file import as alternative in intro and FAQ
  • Set-up-a-Direct-Company-Card-Feed-Connection.md — added file import as alternative in intro

Now that CSV card import is no longer behind a beta flag,
update company card help articles to cross-reference the
file import option and fix XLX -> XLS typos.

Co-authored-by: Alberto Gonzalez-Cela <Gonals@users.noreply.github.com>
@MelvinBot MelvinBot added the HelpDot Apply this label if the issue relates to ExpensifyHelp label May 21, 2026
@MelvinBot MelvinBot mentioned this pull request May 21, 2026
53 tasks
@github-actions github-actions Bot changed the title Docs updates for E/A#91176 Add file import cross-references for company cards [No QA] Docs updates for E/A#91176 Add file import cross-references for company cards May 21, 2026
@OSBotify

This comment has been minimized.

@stephanieelliott stephanieelliott self-assigned this May 22, 2026
@stephanieelliott
stephanieelliott marked this pull request as ready for review May 27, 2026 04:59
@stephanieelliott
stephanieelliott self-requested a review as a code owner May 27, 2026 04:59
@github-actions

Copy link
Copy Markdown
Contributor

HelpDot Documentation Review

Overall Assessment

This PR makes two categories of changes across four company-card articles: (1) fixing a repeated "XLX" typo to the correct "XLS" file extension, and (2) adding cross-links to the spreadsheet import article from three related articles. Both categories are well-scoped improvements that correct factual inaccuracy and improve discoverability.

Scores Summary

  • Readability: 9/10 - The typo fixes improve correctness, and the added Oxford comma improves clarity. The double-space fix in the Commercial Card Feed FAQ is a nice cleanup. All changes are clean and well-integrated into existing prose.
  • AI Readiness: 9/10 - Cross-links use descriptive anchor text that reflects real search phrasing (e.g., "import company card transactions from a spreadsheet"). The YAML metadata in the spreadsheet article already contains "XLS" in its keywords, so the body text now matches. No heading or metadata changes were needed for this diff.
  • Style Compliance: 9/10 - Anchor text follows the "Learn how to [task]" or descriptive-task pattern required by the cross-linking standards. All links use relative paths. Link placement is appropriate -- links appear in explanatory paragraphs and conditional dependency statements, not inside numbered step instructions.

Key Findings

  • Typo fix is important: "XLX" is not a real file format. Correcting it to "XLS" in all three occurrences prevents user confusion and ensures the article matches real-world terminology. The addition of the Oxford comma ("CSV, TXT, XLS, or XLSX") is a minor but welcome consistency improvement.
  • Cross-links are well-placed: The new links to the spreadsheet import article are added in prerequisite/alternative-workflow contexts (e.g., "If you're not eligible..." or "If you haven't set up a feed yet..."), which aligns with the governance rule that cross-links should only appear for prerequisite workflows, deep-dives, or excluded workflows.
  • Link volume is reasonable: Each article gains one or two links at most, staying within the governance guidance to limit cross-links and preserve topical clarity.
  • Minor observation: In Set-up-a-Commercial-Card-Feed-Connection.md, the original intro link text said "set up a direct company card feed connection instead" and the PR changes it to remove "instead" while appending the new spreadsheet link. The removal of "instead" is appropriate since there are now two alternatives listed.

Recommendations

  • No blocking issues. This PR is ready to merge.
  • For a future pass: the spreadsheet import article (line 10 in the current file) still has a trailing space after the H1 heading. This is pre-existing and outside this diff, so it is not scored here.

Files Reviewed

  • Assign-Company-Cards.md - Added one cross-link bullet to spreadsheet import; removed trailing whitespace. Clean.
  • Import-Company-Card-Transactions-From-a-Spreadsheet.md - Fixed "XLX" to "XLS" in three locations; added Oxford comma. Correct and necessary.
  • Set-up-a-Commercial-Card-Feed-Connection.md - Added cross-links to spreadsheet import in intro and FAQ; fixed double space. Well-placed.
  • Set-up-a-Direct-Company-Card-Feed-Connection.md - Added cross-link to spreadsheet import as a fallback option. Appropriate context.

Note: No inline comments were necessary -- all changes in this PR are well-formed and compliant with governance standards.

@MelvinBot

Copy link
Copy Markdown
Contributor Author

The failing review check is not related to this PR's changes — it's a transient GitHub API error (other side closed) that occurred when the workflow tried to fetch the list of changed files. This is a flaky infrastructure issue.

Fix: Re-run the failed review job. I don't have permission to trigger re-runs, so a maintainer will need to click "Re-run failed jobs" on the failed workflow run.

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@stephanieelliott
stephanieelliott requested a review from a team May 28, 2026 03:11
@melvin-bot

melvin-bot Bot commented May 28, 2026

Copy link
Copy Markdown

Concierge reviewer checklist:

  • I have verified the accuracy of the article
    • The article is within a hub that makes sense, and the navigation is correct
    • All processes, screenshots, and examples align with current product behavior.
    • All links within the doc have been verified for correct destination and functionality.
  • I have verified the readability of the article
    • The article's language is clear, concise, and free of jargon.
    • The grammar, spelling, and punctuation are correct.
    • The article contains at least one image, or that an image is not necessary
  • I have verified the formatting of the article
    • The article has consistent formatting (headings, bullet points, etc.) with other HelpDot articles and that aligns with the HelpDot formatting standards.
    • The article has proper text spacing and breaks for readability.
  • I have verified the article has the appropriate tone and style
    • The article's tone is professional, friendly, and suitable for the target audience.
    • The article's tone, terminology, and voice are consistent throughout.
  • I have verified the overall quality of the article
    • The article is not missing any information, nor does it contain redundant information.
    • The article fully addresses user needs.
  • I have verified that all requested improvements have been addressed

For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member?

cc @brianlee-expensify

@melvin-bot
melvin-bot Bot requested review from brianlee-expensify and removed request for a team May 28, 2026 03:11
@melvin-bot

melvin-bot Bot commented May 28, 2026

Copy link
Copy Markdown

@brianlee-expensify Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@brianlee-expensify

Copy link
Copy Markdown
Contributor

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
    • MacOS: Desktop
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified there are no new alerts related to the canBeMissing param for useOnyx
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
Android: mWeb Chrome
iOS: HybridApp
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop

@brianlee-expensify
brianlee-expensify merged commit c8ecf8f into main May 28, 2026
18 checks passed
@brianlee-expensify
brianlee-expensify deleted the claude-docsUpdateCSVCardImportGA branch May 28, 2026 23:18
@melvin-bot

melvin-bot Bot commented May 28, 2026

Copy link
Copy Markdown

@brianlee-expensify looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@melvin-bot melvin-bot Bot added the Emergency label May 28, 2026
@brianlee-expensify

Copy link
Copy Markdown
Contributor

Help Site update, no QA review

@github-actions

Copy link
Copy Markdown
Contributor

HelpDot Documentation Review

Overall Assessment

This PR makes small, targeted improvements across four company card documentation articles: fixing a repeated file-extension typo ("XLX" corrected to "XLS"), adding cross-links to the new spreadsheet import article, and cleaning up minor whitespace issues (trailing space, double space). The changes are minimal in scope and well-executed.

Scores Summary

  • Readability: 9/10 - The corrections improve accuracy (fixing the typo in three locations). Cross-links are placed in appropriate non-procedural locations and use clear, descriptive anchor text. No issues with sentence clarity or flow.
  • AI Readiness: 9/10 - No changes to headings, metadata, or structural elements. The added cross-links use full feature names in anchor text (e.g., "import company card transactions from a spreadsheet"), which supports semantic retrieval. No regressions introduced.
  • Style Compliance: 9/10 - Cross-link anchor text follows the governance format ("Learn how to [task]" or descriptive task phrasing). Links use relative paths as required. One minor observation: the link in Set-up-a-Direct-Company-Card-Feed-Connection.md uses "learn how to import company card transactions from a spreadsheet" while Assign-Company-Cards.md uses "Learn how to import..." (capitalized). Both forms appear in existing content, but consistency would be ideal.

Key Findings

  • The "XLX" to "XLS" typo fix is a valuable correction that appears in the intro paragraph and two procedural sections of the spreadsheet import article.
  • Cross-links to the spreadsheet import article are added in contextually appropriate places: after introductory/explanatory text, not inside numbered steps. This aligns with the cross-linking standards in HELP_AUTHORING_GUIDELINES.md Section 7.
  • The double-space fix on line 107 of Set-up-a-Commercial-Card-Feed-Connection.md is a minor but welcome cleanup.
  • No governance violations were introduced by these changes.

Recommendations

  • Consider standardizing the anchor text capitalization: "Learn how to import..." (sentence case with capital L) is used in Assign-Company-Cards.md, while "learn how to import..." (lowercase) is used inline in Set-up-a-Direct-Company-Card-Feed-Connection.md and Set-up-a-Commercial-Card-Feed-Connection.md. The lowercase form is correct when embedded mid-sentence; just verify each usage reads naturally in context.
  • No blocking issues. This PR is ready to merge.

Files Reviewed

  • Assign-Company-Cards.md - Added cross-link to spreadsheet import article; fixed trailing whitespace. Clean.
  • Import-Company-Card-Transactions-From-a-Spreadsheet.md - Fixed "XLX" typo to "XLS" in three locations. Clean.
  • Set-up-a-Commercial-Card-Feed-Connection.md - Added two cross-links to spreadsheet import; fixed double space. Clean.
  • Set-up-a-Direct-Company-Card-Feed-Connection.md - Added cross-link to spreadsheet import. Clean.

This review assessed only the proposed changes in the PR diff, scored against the HelpDot governance files (HELPSITE_NAMING_CONVENTIONS.md, HELP_AUTHORING_GUIDELINES.md, TEMPLATE.md).

## What can I do if my bank doesn't offer a commercial card feed?

If you're not eligible for a commercial card feed, connect company cards using a direct feed or through Plaid using your online banking credentials. [Learn how to set up a direct company card feed connection](/articles/new-expensify/connect-credit-cards/Set-up-a-Direct-Company-Card-Feed-Connection).
If you're not eligible for a commercial card feed, connect company cards using a direct feed or through Plaid using your online banking credentials. [Learn how to set up a direct company card feed connection](/articles/new-expensify/connect-credit-cards/Set-up-a-Direct-Company-Card-Feed-Connection). You can also [import company card transactions from a spreadsheet](/articles/new-expensify/connect-credit-cards/Import-Company-Card-Transactions-From-a-Spreadsheet).

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Anchor text violation: Per cross-linking standards in HELP_AUTHORING_GUIDELINES.md, anchor text must use descriptive formats such as "Learn how to [complete task]". Change [import company card transactions from a spreadsheet] to [learn how to import company card transactions from a spreadsheet] for consistency with the other cross-links in this PR.

@OSBotify

OSBotify commented Jun 1, 2026

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/brianlee-expensify in version: 9.3.90-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

@OSBotify

OSBotify commented Jun 2, 2026

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/lakchote in version: 9.3.90-3 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

HelpDot Apply this label if the issue relates to ExpensifyHelp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants