[Domain Control] Add wall gate for unvalidated domains in domain members#91170
Conversation
|
Hey, I noticed you changed If you want to automatically generate translations for other locales, an Expensify employee will have to:
Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running: npx ts-node ./scripts/generateTranslations.ts --helpTypically, you'd want to translate only what you changed by running |
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3779663649
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
@codex review |
|
Can I get the GitHub workflow for translations ran? 🙏 |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8cf6d2e9c8
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
ac7c341 to
560f3c1
Compare
…-wall-gate-for-unvalidated-domains
…' of github.com:software-mansion-labs/expensify-app-fork into jakubstec/domains/add-wall-gate-for-unvalidated-domains
|
@jakubstec I see, are you going to fix it in a separate PR? |
|
Conflicts |
It requires a lot of small changes in 10+ files, so maybe we should do it in a separate PR. (draft's here: #91747, waiting for this one to be merged first 😄) Also, i can take care of a small pre-existing domain verification bug i've found, (in this follow-up)
Screen.Recording.2026-05-26.at.16.38.27.mov |
…-wall-gate-for-unvalidated-domains
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
|
@mountiny no more conflicts :] |
|
Thank you! @dukenv0307 all yours |
|
That works for me - do we need to re-export new illustrations then? Just to make sure we get the consistent 1px stroke everywhere. |
|
Good point. Here's the new illustrations: illustrations.zip |
|
Those look good to me 👍 |
|
Same! |
|
Same. Thanks for the tweaking here @jakubstec |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppScreen.Recording.2026-05-28.at.09.35.39.movAndroid: mWeb ChromeScreen.Recording.2026-05-28.at.09.27.00.moviOS: HybridAppScreen.Recording.2026-05-28.at.09.30.47.moviOS: mWeb SafariScreen.Recording.2026-05-28.at.09.26.00.movMacOS: Chrome / SafariScreen.Recording.2026-05-28.at.09.23.44.mov |
|
🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/mountiny in version: 9.3.90-0 🚀
Bundle Size Analysis (Sentry): |
Help site review for this PRDocs update warranted — draft PR created: #92188 This PR adds an in-product wall gate on the Domain members page: for an unverified domain, users now see a prompt to verify the domain (feature list + Verify domain CTA) instead of an empty member list. The Manage Domain Members article already notes that a domain must be verified before managing members, but it didn't describe what users actually see on that page when the domain is unverified. I added a new section, "What you see if your domain isn't verified", to reflect the current behavior, using the exact UI labels from What I checked
@jakubstec, please review the linked help site PR and confirm it reflects the current behavior. Then mark the linked help site PR |
|
🚀 Deployed to production by https://github.com/lakchote in version: 9.3.90-3 🚀
|






Explanation of Change
Added a guard to prevent user from seeing an empty domain members page. Followed the design (discussed in issue).
Fixed Issues
$ #91081
PROPOSAL:
Tests
Offline tests
N/A
QA Steps
Same as Tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
MacOS: Chrome / Safari
Screen.Recording.2026-05-25.at.17.07.23.mov