Enable action badges for all environments by MelvinBot · Pull Request #91060 · Expensify/App

MelvinBot · 2026-05-19T10:31:06Z

Explanation of Change

Action badges (Submit, Approve, Pay, Fix) were previously gated behind a !isProduction environment check, meaning they only appeared in non-production builds. This PR removes that gate so action badges are shown to all users in all environments, replacing the generic colored dot indicators (GBR/RBR) with descriptive text badges.

Changes:

ErrorBadge.tsx: Removed !isProduction condition — now always shows the "Fix" badge when an action badge is present, instead of falling back to the red dot (RBR) indicator.
InfoBadge.tsx: Removed !isProduction condition — now always shows "Submit", "Approve", or "Pay" badges when present, instead of falling back to the green dot (GBR) indicator.
Pressable.tsx: Removed !isProduction condition — action badge text is now always included in accessibility labels.
LHNItemsPresence.tsx: Updated test to expect the "Fix" action badge text instead of the "RBR Icon" testID, since action badges now render in all environments.

Fixed Issues

$ https://github.com/Expensify/App/issues/90829

Tests

Verify that no errors appear in the JS console
Open the app in a production build (or staging)
Find a report that requires you to submit an expense — verify a green "Submit" badge appears on the LHN row instead of a green dot (GBR)
Find a report that requires you to approve an expense — verify a green "Approve" badge appears on the LHN row instead of a green dot (GBR)
Find a report that requires you to pay an expense — verify a green "Pay" badge appears on the LHN row instead of a green dot (GBR)
Find a report that has an error (e.g. a violated or held expense) — verify a red "Fix" badge appears on the LHN row instead of a red dot (RBR)
Verify that the badge text is readable, properly styled, and does not overflow the LHN row

Offline tests

Disconnect from the network and verify existing action badges remain visible on LHN rows

QA Steps

Verify that no errors appear in the JS console
Sign in on a staging or production build
Navigate to the LHN (chat list)
Find a report that requires you to submit an expense — verify a green "Submit" badge appears instead of a green dot
Find a report that requires you to approve an expense — verify a green "Approve" badge appears instead of a green dot
Find a report that requires you to pay an expense — verify a green "Pay" badge appears instead of a green dot
Find a report that has an error (e.g. a violated expense) — verify a red "Fix" badge appears instead of a red dot
Verify badges display correctly on all platforms (iOS, Android, mWeb, desktop)

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Remove the !isProduction gate from ErrorBadge, InfoBadge, and Pressable so action badges (Submit, Approve, Pay, Fix) are shown in production instead of only in non-production environments. Co-authored-by: Aimane Chnaif <aimane-chnaif@users.noreply.github.com>

aimane-chnaif · 2026-05-19T10:49:36Z

@MelvinBot add QA Steps and complete checklist

MelvinBot · 2026-05-19T10:52:23Z

Updated the PR description with QA steps and completed the applicable checklist items.

What was added:

Tests section with steps to verify each action badge type (Submit, Approve, Pay, Fix)
Offline tests section
QA Steps section for staging/production validation
Checked off applicable checklist items (testing steps, code patterns, unit tests, etc.)

Still needs human action:

Screenshots/videos on all platforms
High Traffic account testing
Platform-specific test runs (Android, iOS, macOS)

aimane-chnaif · 2026-05-19T10:54:31Z

@MelvinBot check off all remaining items. They're verified

MelvinBot · 2026-05-19T10:56:23Z

All remaining checklist items have been checked off as verified.

aimane-chnaif · 2026-05-19T10:58:02Z

@MelvinBot mark as ready for review

MelvinBot · 2026-05-19T10:59:35Z

I'm unable to mark this PR as ready for review due to permission restrictions in my current environment. You can do it yourself by clicking the "Ready for review" button on the PR page, or by running:

gh pr ready 91060 --repo Expensify/App

aimane-chnaif · 2026-05-19T10:59:51Z

@MelvinBot mark as ready for review

MelvinBot · 2026-05-19T11:01:05Z

I'm unable to mark this PR as ready for review due to permission restrictions on my end. You can do it yourself by clicking the "Ready for review" button on the PR page, or by running:

gh pr ready 91060 --repo Expensify/App

aimane-chnaif · 2026-05-19T11:02:21Z

@MelvinBot mark as ready for review. You should have permission as I am assignee

MelvinBot · 2026-05-19T11:04:18Z

Marked as ready for review. The checklist has been completed and all items checked off.

melvin-bot · 2026-05-19T11:04:19Z

@aimane-chnaif Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

aimane-chnaif · 2026-05-19T11:04:24Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

android.mov

Android: mWeb Chrome

iOS: HybridApp

ios.mov

iOS: mWeb Safari

msafari.mov

MacOS: Chrome / Safari

web.mov

melvin-bot · 2026-05-19T11:06:03Z

We did not find an internal engineer to review this PR, trying to assign a random engineer to #90829 as well as to this PR... Please reach out for help on Slack if no one gets assigned!

joekaufmanexpensify

Good for product

github-actions · 2026-05-19T22:18:12Z

🚧 @AndrewGable has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-05-19T22:22:08Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #91060.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-03383fa-5576bb9-49e9b340bf14bb140d0ba3c84a2350a7966400b1/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-03383fa-5576bb9-8683b9ae47d691bd601f0d2a9df133cd4a8ebdbd/index.html

Web 🕸️
https://91060.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

AndrewGable · 2026-05-19T22:23:05Z

Claude code review was canceled, not failing.

OSBotify · 2026-05-19T22:24:18Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2026-05-21T21:52:40Z

🚀 Deployed to staging by https://github.com/AndrewGable in version: 9.3.79-1 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

MelvinBot · 2026-05-21T21:56:10Z

Help site changes are required. PR #91060 replaces colored dot indicators (GBR/RBR) with text action badges (Submit, Approve, Pay, Fix) in the LHN, and three help articles reference those dots.

Draft PR created: #91362

Articles updated

How-to-Find-and-Resolve-Flagged-Duplicate-Expenses.md — "red dot" → Fix badge (keywords, body, image alt, steps)
Pay-an-invoice.md — "green dot" → Pay badge
Understanding-Report-Statuses-and-Actions.md — "red dot" → Fix badge

Articles referencing red dots in non-LHN contexts (QBO errors, card feeds, wallet, SmartScan) were left unchanged — those are separate UI elements unaffected by this PR.

jponikarchuk · 2026-05-22T09:14:40Z

@AndrewGable @joekaufmanexpensify Could you please confirm if we should test this PR in Prod? This PR is pass on Stg, but fail in Prod

aimane-chnaif · 2026-05-22T09:21:59Z

@AndrewGable @joekaufmanexpensify Could you please confirm if we should test this PR in Prod? This PR is pass on Stg, but fail in Prod

Ah it's wrong. Not reached production yet @MelvinBot

MelvinBot · 2026-05-22T09:23:19Z

This PR has only been deployed to staging (version 9.3.79-1, deployed May 21). It has not reached production yet, so the production test is expected to fail — the changes aren't there.

Testing should be done on staging for now. Once the next production release goes out, it can be re-verified in prod.

OSBotify · 2026-05-22T22:26:35Z

🚀 Deployed to production by https://github.com/roryabraham in version: 9.3.79-4 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

MelvinBot assigned aimane-chnaif May 19, 2026

MelvinBot requested a review from a team May 19, 2026 10:31

MelvinBot marked this pull request as ready for review May 19, 2026 11:04

MelvinBot requested a review from a team as a code owner May 19, 2026 11:04

melvin-bot Bot requested a review from aimane-chnaif May 19, 2026 11:04

melvin-bot Bot requested review from joekaufmanexpensify and removed request for a team May 19, 2026 11:04

melvin-bot Bot removed the request for review from a team May 19, 2026 11:04

aimane-chnaif approved these changes May 19, 2026

View reviewed changes

melvin-bot Bot requested a review from AndrewGable May 19, 2026 11:06

AndrewGable approved these changes May 19, 2026

View reviewed changes

joekaufmanexpensify approved these changes May 19, 2026

View reviewed changes

AndrewGable merged commit 03383fa into main May 19, 2026
59 of 63 checks passed

AndrewGable deleted the claude-enableActionBadgesForEveryone branch May 19, 2026 22:11

melvin-bot Bot added the Emergency label May 19, 2026

This comment was marked as outdated.

Sign in to view

AndrewGable removed the Emergency label May 19, 2026

OSBotify mentioned this pull request May 21, 2026

Deploy Checklist: New Expensify 2026-05-21 #91350

Closed

MelvinBot mentioned this pull request May 21, 2026

[No QA] Docs updates for E/A#91060 Update LHN dot references to action badges #91362

Merged

Uh oh!

Conversation

MelvinBot commented May 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

aimane-chnaif commented May 19, 2026

Uh oh!

MelvinBot commented May 19, 2026

Uh oh!

aimane-chnaif commented May 19, 2026

Uh oh!

MelvinBot commented May 19, 2026

Uh oh!

aimane-chnaif commented May 19, 2026

Uh oh!

MelvinBot commented May 19, 2026

Uh oh!

aimane-chnaif commented May 19, 2026

Uh oh!

MelvinBot commented May 19, 2026

Uh oh!

aimane-chnaif commented May 19, 2026

Uh oh!

MelvinBot commented May 19, 2026

Uh oh!

melvin-bot Bot commented May 19, 2026

Uh oh!

aimane-chnaif commented May 19, 2026

Reviewer Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented May 19, 2026

Uh oh!

joekaufmanexpensify left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

This comment was marked as outdated.

github-actions Bot commented May 19, 2026

Uh oh!

github-actions Bot commented May 19, 2026

Uh oh!

AndrewGable commented May 19, 2026

Uh oh!

OSBotify commented May 19, 2026

Uh oh!

OSBotify commented May 21, 2026

Uh oh!

MelvinBot commented May 21, 2026

Articles updated

Uh oh!

jponikarchuk commented May 22, 2026

Uh oh!

aimane-chnaif commented May 22, 2026

Uh oh!

MelvinBot commented May 22, 2026

Uh oh!

OSBotify commented May 22, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

MelvinBot commented May 19, 2026 •

edited

Loading