Skip to content

fix(tests): resolve flaky fetch count assertions in MiddlewareTest #90724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ykd007 wants to merge 1 commit into from
Closed

fix(tests): resolve flaky fetch count assertions in MiddlewareTest #90724

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions tests/unit/MiddlewareTest.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,6 +144,12 @@ describe('Middleware', () => {
}));

SequentialQueue.unpause();
// Wait for the first request to complete and for Onyx to process the preexistingReportID
// update before the second request is dispatched. A single waitForNetworkPromises() call
// is not enough because the middleware re-queues the second request after the Onyx update
// resolves, which happens in a subsequent microtask/batch cycle.
await waitForNetworkPromises();
await waitForBatchedUpdates();
await waitForNetworkPromises();

expect(global.fetch).toHaveBeenCalledTimes(2);
Expand Down Expand Up @@ -338,7 +344,11 @@ describe('Middleware', () => {
}));

SequentialQueue.unpause();
// Both requests are sequential; we need to wait for all network activity to settle,
// including the second fetch triggered after Onyx processes preexistingReportID.
await waitForNetworkPromises();
await waitForBatchedUpdates();
await waitForNetworkPromises();

expect(global.fetch).toHaveBeenCalledTimes(2);

Expand Down