Skip to content

fix: scroll to right position on text insertion #9062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pecanoro merged 6 commits into from
Jul 5, 2022
Merged

fix: scroll to right position on text insertion #9062

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
efea0bb
fix: scroll to right position on text insertion
b1tjoy May 18, 2022
d97bb0b
move text input blur and focus code to Composer
b1tjoy May 22, 2022
f84d164
add comment for new code
b1tjoy May 24, 2022
780d767
Merge branch 'Expensify:main' into fix/8663-scroll-on-insertion
b1tjoy Jun 28, 2022
9f33935
Merge branch 'Expensify:main' into fix/8663-scroll-on-insertion
b1tjoy Jul 5, 2022
e5ad3f7
update comment and fix lint error
b1tjoy Jul 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/components/Composer/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,6 +239,10 @@ class Composer extends React.Component {
try {
document.execCommand('insertText', false, markdownText);
this.updateNumberOfLines();

// Pointer will go out of sight when a large paragraph is pasted on the web. Refocusing the input keeps the cursor in view.
this.textInput.blur();

@parasharrajat parasharrajat May 23, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A comment will be useful.

@b1tjoy b1tjoy May 24, 2022

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment added.

this.textInput.focus();
// eslint-disable-next-line no-empty
} catch (e) {}
}
Expand Down
2 changes: 0 additions & 2 deletions src/pages/home/report/ReportActionCompose.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -395,8 +395,6 @@ class ReportActionCompose extends React.Component {
if (newComment) {
this.debouncedBroadcastUserIsTyping();
}

this.textInput.scrollTop = this.textInput.scrollHeight;
}

/**
Expand Down