[No QA] Send addressStreet2 as separate param in UpdatePersonalBankAccountInfo by MelvinBot · Pull Request #90350 · Expensify/App

MelvinBot · 2026-05-12T15:27:50Z

Explanation of Change

The updatePersonalBankAccountInfo function was concatenating addressStreet and addressStreet2 with a newline character (\n) into a single addressStreet parameter before sending it to the backend. The WAF rejects newlines in that field, so any user with a second address line would get the error: "Unable to update bank account information. Please try again later."

This PR sends addressStreet2 as a separate API parameter instead of concatenating it into addressStreet.

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/636085

Tests

Sign in to an account with a personal bank account
Delete a required address field from the account in your database (e.g. addressStreet)
Refresh, click the GBR
Fill out the address form with a value in the Address 2 field
Confirm you do not see an error when the form submits

Verify that no errors appear in the JS console

Offline tests

QA Steps

QAing this is infeasible because you can't create an account in this state

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

MacOS: Chrome / Safari

addressStreet2.test.mp4

codecov · 2026-05-12T15:39:28Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/libs/actions/BankAccounts.ts	`11.34% <0.00%> (-0.05%)`	⬇️
... and 61 files with indirect coverage changes

…AccountInfo Previously, addressStreet and addressStreet2 were concatenated with a newline character into a single addressStreet parameter. The WAF rejects newlines in that field, causing the request to fail for users with a second address line. Co-authored-by: Chuck Dries <chuckdries@users.noreply.github.com>

MelvinBot · 2026-05-29T22:13:31Z

The failing check is unrelated to this PR.

Analysis: test (job 6) failed in tests/unit/MiddlewareTest.ts on the Middleware › HandleUnusedOptimisticID suite — expect(global.fetch).toHaveBeenCalledTimes(2) got 3 calls instead. This is a known flaky test that has had multiple fix attempts (see #90392, #90724, #90743, #90762, #91620).

Evidence: This PR only touches src/libs/API/parameters/UpdatePersonalBankAccountInfoParams.ts and src/libs/actions/BankAccounts.ts (bank account update params). The failing test covers AddComment / OpenReport request handling in the middleware — no shared code path with bank-account update logic.

The other failing check (PR Author Checklist) is expected — it's waiting on the human co-author to fill in the Tests/QA sections and tick the checklist.

MelvinBot · 2026-05-29T23:47:06Z

The failing test (job 6) check is unrelated to this PR — it's a known flaky test tracked in #90660.

Analysis:

This PR only modifies src/libs/API/parameters/UpdatePersonalBankAccountInfoParams.ts and src/libs/actions/BankAccounts.ts (bank account flow).
The failing tests (Middleware › HandleUnusedOptimisticID › Request with preexistingReportID and OpenReport to a chat with preexistingReportID and clean up optimistic participant data) live in tests/unit/MiddlewareTest.ts and exercise the AddComment / OpenReport middleware — neither of which touches bank account code.
The failure mode (expect(global.fetch).toHaveBeenCalledTimes(2) receiving 3) matches the symptoms documented in [Due for payment 2026-06-12] [Due for payment 2026-06-09] [$50] Flaky test: MiddlewareTest › HandleUnusedOptimisticID - fetch call count assertion fails intermittently #90660.

The other failing check, PR Author Checklist / checklist, is expected until the human co-author (chuckdries) fills out the Tests/QA sections and ticks the checklist items. No code fix needed from me — feel free to re-run test (job 6) to confirm it passes on retry.

…eet2Separately

MelvinBot · 2026-06-03T05:04:45Z

I analyzed the two failing checks. Neither is caused by this PR's code — no fix to push.

`test (job 6)` — flaky/stale, unrelated to this PR

The failure is in tests/unit/MiddlewareTest.ts (HandleUnusedOptimisticID — "Expected 2 calls, received 3"). That suite tests optimistic report-ID middleware and is not related to this PR, which only touches BankAccounts.ts and UpdatePersonalBankAccountInfoParams.ts.

I ran the suite locally on this exact branch HEAD (682ddba) and it passes:

PASS tests/unit/MiddlewareTest.ts (50.084 s)
  Middleware › HandleUnusedOptimisticID
    ✓ Request with preexistingReportID
    ✓ OpenReport to a chat with preexistingReportID and clean up optimistic participant data
Tests: 7 passed, 7 total

The HandleUnusedOptimisticID call-count assertions are a known order/state-dependent flake (they pass in isolation but can leak shared Onyx/mock state when run in a sharded CI job). The failing run is also from 2026-05-29 (~5 days stale). Per policy I don't push code for unrelated/flaky failures. Re-running test (job 6), or merging the latest main to trigger a fresh run, should clear it.

`checklist` — PR Author Checklist (expected)

This is the human-only PR Author Checklist, failing only because the boxes aren't ticked — expected while the PR is still on HOLD. The co-author should fill out Tests/QA and check the boxes before marking it ready for review.

Note: this PR is [HOLD web-e 52847], so it isn't mergeable until the linked Web-Expensify change lands regardless of these checks.

melvin-bot · 2026-06-03T05:09:28Z

@Pujan92 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

melvin-bot · 2026-06-03T05:09:33Z

@ShridharGoel Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

chuckdries · 2026-06-03T05:12:19Z

Gonna get someone internal to review this since it's impossible to test without modifying the database

melvin-bot · 2026-06-03T05:15:44Z

@mjasikowski Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

mjasikowski · 2026-06-03T09:21:49Z

    type AdditionalDataFields = Pick<BankAccountAdditionalData, 'firstName' | 'lastName' | 'addressStreet' | 'addressCity' | 'addressState' | 'addressZipCode' | 'companyPhone'>;

+    // The BE concatenates addressStreet2 into addressStreet with a newline, so mirror that here to match the stored value.
+    const formattedStreet = getFormattedStreet(accountData.addressStreet, accountData.addressStreet2);


What's the difference between having this here vs where it was before?
If none, then maybe leave it to reduce the diff?

Good call. I left the comment because the behavior feels a little non-obvious to me

melvin-bot · 2026-06-03T15:59:50Z

@mkhutornyi Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

chuckdries · 2026-06-03T16:01:09Z

Hi @mkhutornyi, you can disregard this PR as it will be impossible for you to test this flow

mkhutornyi · 2026-06-03T16:04:04Z

Sure. this flow is testable though

mjasikowski · 2026-06-03T19:45:52Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

github-actions · 2026-06-03T21:23:27Z

🚧 @mjasikowski has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-06-03T21:37:54Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #90350.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-8ee1e81e728-4b459aa-d337159e09d145055a574da3e5b38a6f8acc87b2/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-8ee1e81-4b459aa-62fbcd335aef7af587b5cce39bfd5eadd7ceee3c/index.html

Web 🕸️
https://90350.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-06-04T07:56:13Z

🚀 Deployed to staging by https://github.com/mjasikowski in version: 9.3.99-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

MelvinBot · 2026-06-04T07:57:52Z

🤖 Help site review — no changes required

I reviewed the changes in this PR and no updates to Expensify's help site files under App/docs/articles are required.

Why: This is an internal API/data-formatting fix. It changes how the second address line is sent to the backend — addressStreet2 is now sent as a separate API parameter instead of being concatenated into addressStreet with a newline (which the WAF was rejecting). It does not:

Add, remove, or rename any feature, tab, setting label, or button
Change the user-facing bank account form (the Address line 1 / Address line 2 fields already exist)
Alter any documented workflow

The relevant help article, Connect a Personal Bank Account, only describes entering your "name, address, and phone number" generically — content that remains accurate after this change. The fix simply makes submitting a two-line address succeed instead of erroring, with no change to the documented steps.

Because no documentation changes are needed, I did not create a draft help site PR.

OSBotify · 2026-06-05T17:49:47Z

🚀 Deployed to production by https://github.com/lakchote in version: 9.3.99-9 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

MelvinBot assigned chuckdries May 12, 2026

MelvinBot requested a review from a team May 12, 2026 15:27

MelvinBot and others added 2 commits May 29, 2026 14:58

Fix optimistic update for multiline addresses

682ddba

chuckdries force-pushed the claude-sendAddressStreet2Separately branch from 1a4ebae to 682ddba Compare May 29, 2026 22:03

chuckdries changed the title ~~Send addressStreet2 as separate param in UpdatePersonalBankAccountInfo~~ [HOLD web-e 52847] Send addressStreet2 as separate param in UpdatePersonalBankAccountInfo May 29, 2026

Merge remote-tracking branch 'origin/main' into claude-sendAddressStr…

19806e1

…eet2Separately

chuckdries changed the title ~~[HOLD web-e 52847] Send addressStreet2 as separate param in UpdatePersonalBankAccountInfo~~ [No QA] Send addressStreet2 as separate param in UpdatePersonalBankAccountInfo Jun 3, 2026

chuckdries marked this pull request as ready for review June 3, 2026 05:09

chuckdries requested a review from a team as a code owner June 3, 2026 05:09

melvin-bot Bot requested review from Pujan92 and flaviadefaria and removed request for a team June 3, 2026 05:09

melvin-bot Bot requested review from a team and ShridharGoel and removed request for a team June 3, 2026 05:09

chuckdries removed request for Pujan92 and ShridharGoel June 3, 2026 05:10

chuckdries requested a review from a team June 3, 2026 05:15

melvin-bot Bot requested review from mjasikowski and removed request for a team June 3, 2026 05:15

mjasikowski requested changes Jun 3, 2026

View reviewed changes

Move formattedStreet declaration back to previous location

7ebffa6

chuckdries requested a review from a team as a code owner June 3, 2026 15:59

melvin-bot Bot requested review from mkhutornyi and removed request for a team June 3, 2026 15:59

chuckdries removed the request for review from mkhutornyi June 3, 2026 16:00

mjasikowski approved these changes Jun 3, 2026

View reviewed changes

mjasikowski merged commit 8ee1e81 into main Jun 3, 2026
36 of 37 checks passed

mjasikowski deleted the claude-sendAddressStreet2Separately branch June 3, 2026 19:53

OSBotify mentioned this pull request Jun 4, 2026

Deploy Checklist: New Expensify 2026-06-04 #92626

Closed

100 tasks

Uh oh!

Conversation

MelvinBot commented May 12, 2026 • edited by chuckdries Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov Bot commented May 12, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

MelvinBot commented May 29, 2026

Uh oh!

MelvinBot commented May 29, 2026

Uh oh!

MelvinBot commented Jun 3, 2026

test (job 6) — flaky/stale, unrelated to this PR

checklist — PR Author Checklist (expected)

Uh oh!

melvin-bot Bot commented Jun 3, 2026

Uh oh!

melvin-bot Bot commented Jun 3, 2026

Uh oh!

chuckdries commented Jun 3, 2026

Uh oh!

melvin-bot Bot commented Jun 3, 2026

Uh oh!

mjasikowski Jun 3, 2026

Choose a reason for hiding this comment

Uh oh!

chuckdries Jun 3, 2026

Choose a reason for hiding this comment

Uh oh!

melvin-bot Bot commented Jun 3, 2026

Uh oh!

chuckdries commented Jun 3, 2026

Uh oh!

mkhutornyi commented Jun 3, 2026

Uh oh!

mjasikowski commented Jun 3, 2026

Reviewer Checklist

Screenshots/Videos

Uh oh!

Uh oh!

github-actions Bot commented Jun 3, 2026

Uh oh!

github-actions Bot commented Jun 3, 2026

Uh oh!

OSBotify commented Jun 4, 2026

Uh oh!

MelvinBot commented Jun 4, 2026

Uh oh!

OSBotify commented Jun 5, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

MelvinBot commented May 12, 2026 •

edited by chuckdries

Loading

codecov Bot commented May 12, 2026 •

edited by github-actions Bot

Loading

`test (job 6)` — flaky/stale, unrelated to this PR

`checklist` — PR Author Checklist (expected)