fix: resolve public room message send failure after app restart with emoji text by nabi-ebrahimi · Pull Request #90238 · Expensify/App

nabi-ebrahimi · 2026-05-11T17:47:19Z

Explanation of Change

This change makes the report action list keep any already-known newer messages visible when loading the default newest page. Previously, if the first fetched pagination page started at an older action, locally available newer actions before that page could be left out of the continuous chain, making the conversation appear to start later than the data we already had.

By widening the default chain to include those known newer actions, the UI can show the most complete current conversation state without waiting for another fetch. The report view also passes the newest fetched action ID into the loading hook so pagination decisions are based on the report’s actual fetch state. A unit test covers the case where a newer action exists before the first fetched page and verifies it stays included.

Fixed Issues

$ #89557
PROPOSAL: #89557 (comment)

Tests

Open a public room.
Open DevTools → Console.
Run the following script in the console:

async function removePaginationStartIDForReport(reportID) {
  const [pages] = await Onyx.get(`reportActionsPages_${reportID}`);
  Onyx.set(`reportActionsPages_${reportID}`, [
    pages.filter((page) => page !== "-1"),
  ]);
}

removePaginationStartIDForReport("paste_the_room_reportID_from_the_route_here");

Enter the following message:
g'morn, one for hourish then 🚴 to 🏦
Attempt to send the message.
Verify that the message is successfully posted in the room.

Verify that no errors appear in the JS console

Offline tests

Same as Tests.

QA Steps

Same as Tests.

// TODO: These must be filled out, or the issue title must include "[No QA]."

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Edited_20260511_231213.mp4

Android: mWeb Chrome

Recording_20260511_231643.mp4

iOS: Native

Screen.Recording.2026-05-11.at.11.46.11.PM.mov

iOS: mWeb Safari

Screen.Recording.2026-05-11.at.11.51.44.PM.mov

MacOS: Chrome / Safari

Screen.Recording.2026-05-11.at.10.26.58.PM.mov

…start

melvin-bot · 2026-05-11T19:41:30Z

@eVoloshchak Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 664cbee431

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-05-11T19:44:58Z

        transactionThreadReport,
        hasOlderActions,
        hasNewerActions,
+        newestFetchedReportActionID: reportPaginationState?.newestFetchedReportActionID,


Avoid skipping newer fetch for transaction thread report

Passing newestFetchedReportActionID here changes loadNewerChats() behavior for mixed report/transaction-thread views: in useLoadReportActions, the cursor path returns immediately after getNewerActions(reportID, newestFetchedReportActionID), so the fallback branch that also fetches transactionThreadReport.reportID never runs. In reports where reportActions combine both report-level and transaction-thread actions, newer thread messages can stop loading after initial pagination state is set, leaving the thread stale until a full reopen.

Useful? React with 👍 / 👎.

@nabi-ebrahimi this seems plausible to me - can you check if this is a valid issue?

@chuckdries I think its valid but couldn't reproduce this issue so i made these changes to make sure transactionThreadReport don't stop loading.

There is an early return here, but from my testing it doesn’t appear to cause the issue mentioned.

…local actions and preserving thread newer fetches

…ge-send-after-restart

eVoloshchak · 2026-05-14T08:36:59Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

video_2026-05-19_16-52-24.mp4

Android: mWeb Chrome

Screen.Recording.2026-05-19.at.16.42.06.mov

iOS: HybridApp

Screen.Recording.2026-05-19.at.16.40.02.mov

iOS: mWeb Safari

Screen.Recording.2026-05-19.at.16.37.56.mov

MacOS: Chrome / Safari

Screen.Recording.2026-05-19.at.16.35.16.mov

nabi-ebrahimi · 2026-05-14T11:07:18Z

@eVoloshchak Just to note, messages can get removed as violation

eVoloshchak · 2026-05-14T11:12:35Z

@nabi-ebrahimi, this doesn't work reliably right after you refresh the page

Refresh the page with a public room
Run the script in the console
Attempt to send the message
All the previous messages disappear, the message you've sent is the only message displayed on the screen. It can be stuck like that forever, or it "fixes itself" after a second

Screen.Recording.2026-05-14.at.13.08.57.mov

Screen.Recording.2026-05-14.at.12.59.45.mov

…pse report to a single message

nabi-ebrahimi · 2026-05-15T08:36:03Z

@eVoloshchak Thanks for reviewing.

After removing PAGINATION_START_ID ("-1") by running the snippet in the console, the newest action sit at index 0 while the cached page boundary still starts at index 1.
In linked-selection mode, that newest action is then seen as outside any cached page span, so it is classified as a gap link and the fallback returns a single-item chain ([linkedAction]) instead of the newest window.

The same bug reproducible on staging.

DEMO

I fixed it at this commit

…rtID

flaviadefaria

From a product standpoint, the fix looks good to me.

nabi-ebrahimi · 2026-05-19T06:19:19Z

@eVoloshchak, gentle bump. thanks

eVoloshchak

LGTM!

chuckdries · 2026-05-19T23:09:14Z

        transactionThreadReport,
        hasOlderActions,
        hasNewerActions,
+        newestFetchedReportActionID: reportPaginationState?.newestFetchedReportActionID,


@nabi-ebrahimi this seems plausible to me - can you check if this is a valid issue?

chuckdries · 2026-05-19T23:09:57Z

+
+            // Keep transaction thread in sync for mixed report+thread views.
+            if (isTransactionThreadReport) {
+                getNewerActions(transactionThreadReportID, transactionThreadNewestAction?.reportActionID);


Just for my understanding, can you explain what this change does?

I made this change to address codex feedback.

It ensures that newer messages in the transaction thread are also fetched.

I see. I think ideally we'd grab newestFetchedReportActionID for the transaction thread as well and pass it here, but that seems like a lot of work and I don't think it's strictly necessary? So we'll roll with this for now

codecov · 2026-05-23T11:46:08Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/hooks/useLoadReportActions.ts	`84.61% <100.00%> (-2.23%)`	⬇️
src/libs/PaginationUtils.ts	`95.28% <100.00%> (+0.10%)`	⬆️
src/pages/inbox/report/ReportActionsView.tsx	`93.33% <100.00%> (+0.22%)`	⬆️
... and 159 files with indirect coverage changes

chuckdries

chuckdries · 2026-05-28T23:14:32Z

Note for QA: since the test steps include pasting part of the URL into the console, this is only testable in desktop browsers

github-actions · 2026-05-28T23:17:12Z

🚧 @chuckdries has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-05-28T23:23:01Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #90238.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-4ec5c1cfee2-a82d62a-2370edf82225ab6911e96902043a1808897d9b69/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-4ec5c1c-a82d62a-6628fe7a7d6d8e69eae4c01430b3e024c567bc4a/index.html

Web 🕸️
https://90238.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-05-28T23:25:55Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2026-06-01T10:20:36Z

🚀 Deployed to staging by https://github.com/chuckdries in version: 9.3.90-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

MelvinBot · 2026-06-01T10:22:45Z

🤖 Help site review: no documentation changes required.

I reviewed the changes in this PR against the help site articles under App/docs/articles.

Conclusion: This is an internal bug fix to report-action pagination logic — it does not change any documented, user-facing feature, setting, or workflow, so no help site updates are needed and no draft docs PR was created.

Why no docs changes are needed

The PR modifies pagination internals so that locally-known newer messages stay visible when the default newest page starts at an older action:

src/libs/PaginationUtils.ts — widens the default continuous chain to include known newer items before the first fetched page.
src/hooks/useLoadReportActions.ts — keeps the transaction thread in sync for mixed report+thread views.
src/pages/inbox/report/ReportActionsView.tsx — passes the newest fetched action ID into the loading hook.
tests/unit/PaginationUtilsTest.ts — adds unit coverage.

These are behind-the-scenes correctness fixes (messages display as users already expect). There is no new UI, button, tab, setting, or feature to document. A search of App/docs/articles for message-loading / pagination / "show older messages" content returned no matching articles, confirming this behavior isn't documented on the help site.

@nabi-ebrahimi — since no help site changes are required, no draft docs PR was created, so there's nothing further to review here. If you believe a specific article should be updated, let me know which one and I'll take another look.

OSBotify · 2026-06-02T06:03:11Z

🚀 Deployed to production by https://github.com/lakchote in version: 9.3.90-3 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

fix: ensure messages with emoji are sent in public rooms after app re…

664cbee

…start

melvin-bot Bot assigned nabi-ebrahimi May 11, 2026

nabi-ebrahimi marked this pull request as ready for review May 11, 2026 19:41

nabi-ebrahimi requested review from a team as code owners May 11, 2026 19:41

melvin-bot Bot requested review from eVoloshchak and flaviadefaria and removed request for a team May 11, 2026 19:41

melvin-bot Bot removed the request for review from a team May 11, 2026 19:41

chatgpt-codex-connector Bot reviewed May 11, 2026

View reviewed changes

Nabi added 3 commits May 13, 2026 11:17

Fix invisible optimistic comments after reconnect by including newer …

7781c97

…local actions and preserving thread newer fetches

Merge remote-tracking branch 'origin/main' into fix/public-room-messa…

41d3bf4

…ge-send-after-restart

chore: run prettier

03f33e3

Nabi added 3 commits May 15, 2026 10:49

Fix linked pagination fallback so newer-than-page actions don’t colla…

372ab4d

…pse report to a single message

Merge branch 'main' into fix/public-room-message-send-after-restart

8f6d84f

fix ts err

2c07e24

Nabi added 2 commits May 18, 2026 10:42

Merge branch 'main' into fix/public-room-message-send-after-restart

7603ef3

fix: Replace transactionThreadReport usage with transactionThreadRepo…

58e8b88

…rtID

flaviadefaria previously approved these changes May 18, 2026

View reviewed changes

eVoloshchak approved these changes May 19, 2026

View reviewed changes

melvin-bot Bot requested a review from chuckdries May 19, 2026 14:53

chuckdries requested changes May 19, 2026

View reviewed changes

Merge branch 'main' into fix/public-room-message-send-after-restart

9e4c903

nabi-ebrahimi dismissed flaviadefaria’s stale review via 9e4c903 May 23, 2026 11:25

chore: prettier

d33c77a

chuckdries approved these changes May 28, 2026

View reviewed changes

chuckdries merged commit 4ec5c1c into Expensify:main May 28, 2026
38 checks passed

OSBotify mentioned this pull request Jun 1, 2026

Deploy Checklist: New Expensify 2026-06-01 #92180

Closed

69 tasks

melvin-bot Bot mentioned this pull request Jun 2, 2026

[Due for payment 2026-06-09] [$250] Message Not Sent in Public Room After App Restart (Specific Text with Emoji) #89557

Closed

7 tasks

Uh oh!

Conversation

nabi-ebrahimi commented May 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented May 11, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot May 11, 2026

Choose a reason for hiding this comment

Uh oh!

chuckdries May 19, 2026

Choose a reason for hiding this comment

Uh oh!

nabi-ebrahimi May 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

eVoloshchak commented May 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

nabi-ebrahimi commented May 14, 2026

Uh oh!

eVoloshchak commented May 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nabi-ebrahimi commented May 15, 2026

Uh oh!

flaviadefaria left a comment

Choose a reason for hiding this comment

Uh oh!

nabi-ebrahimi commented May 19, 2026

Uh oh!

eVoloshchak left a comment

Choose a reason for hiding this comment

Uh oh!

chuckdries May 19, 2026

Choose a reason for hiding this comment

Uh oh!

chuckdries May 19, 2026

Choose a reason for hiding this comment

Uh oh!

nabi-ebrahimi May 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

chuckdries May 28, 2026

Choose a reason for hiding this comment

Uh oh!

codecov Bot commented May 23, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

chuckdries left a comment

Choose a reason for hiding this comment

Uh oh!

chuckdries commented May 28, 2026

Uh oh!

Uh oh!

github-actions Bot commented May 28, 2026

Uh oh!

github-actions Bot commented May 28, 2026

Uh oh!

OSBotify commented May 28, 2026

Uh oh!

OSBotify commented Jun 1, 2026

Uh oh!

MelvinBot commented Jun 1, 2026

nabi-ebrahimi commented May 11, 2026 •

edited

Loading

nabi-ebrahimi May 23, 2026 •

edited

Loading

eVoloshchak commented May 14, 2026 •

edited

Loading

eVoloshchak commented May 14, 2026 •

edited

Loading

nabi-ebrahimi May 23, 2026 •

edited

Loading

codecov Bot commented May 23, 2026 •

edited by github-actions Bot

Loading