Skip to content

Pass report to isExported/hasExportError to fix primary action after failed export #90154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
madmax330 merged 2 commits into from
May 19, 2026
Merged

Pass report to isExported/hasExportError to fix primary action after failed export #90154

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d9b70d3
Pass report to isExported and hasExportError utility calls
MelvinBot May 11, 2026
ec0c0b3
Merge remote-tracking branch 'origin/main' into claude-fixExportPrima…
MelvinBot May 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/libs/ReportPrimaryActionUtils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,7 +203,7 @@ function isPrimaryPayAction({
const isReportApproved = isReportApprovedUtils({report});
const isReportClosed = isClosedReportUtils(report);
const isProcessingReport = isProcessingReportUtils(report);
const isExported = isExportedUtil(reportActions);
const isExported = isExportedUtil(reportActions, report);
const hasExportError = hasExportErrorUtil(reportActions, report);
const didExportFail = !isExported && hasExportError;

Expand Down Expand Up @@ -272,7 +272,7 @@ function isExportAction(report: Report, currentUserLogin: string, policy?: Polic
return false;
}

const hasExportError = hasExportErrorUtil(reportActions);
const hasExportError = hasExportErrorUtil(reportActions, report);
if (syncEnabled && !hasExportError) {
return false;
}
Expand Down
2 changes: 1 addition & 1 deletion src/pages/inbox/report/ReportDetailsExportPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ function ReportDetailsExportPage({route}: ReportDetailsExportPageProps) {

const iconToDisplay = getIntegrationIcon(connectionName, expensifyIcons);
const canBeExported = canBeExportedUtil(report);
const isExported = isExportedUtil(reportActions);
const isExported = isExportedUtil(reportActions, report);

const confirmExport = useCallback(
(type: ExportType) => {
Expand Down
Loading