Clear BANK_ACCOUNT_LIST when resetting bank account by MelvinBot · Pull Request #90133 · Expensify/App

MelvinBot · 2026-05-10T21:43:20Z

Explanation of Change

When resetting a bank account via "Start over" while offline, the BANK_ACCOUNT_LIST Onyx entry was never cleared. Since WorkspaceWorkflowsPage checks BANK_ACCOUNT_LIST for entries matching the workspace policyID, the pending bank account row persisted across app restarts.

This adds BANK_ACCOUNT_LIST updates to the optimistic/success/failure data in both resetUSDBankAccount and resetNonUSDBankAccount, following the existing pattern in deletePaymentBankAccount:

optimisticData: marks the entry with pendingAction: DELETE
successData: sets the entry to null to remove it
failureData: clears pendingAction to restore the entry

Fixed Issues

$ #89895
PROPOSAL: #89895 (comment)

Tests

Sign in to ND
Create a workspace
Navigate to Workspace settings > Workflows > Add bank account
Start connecting a bank account flow (Plaid 1111, Alberta Charleson), exit the flow after entering the first and last name
Tap the pending bank account row
Tap "Start over" and confirm
Verify the pending bank account item is removed from Workflows
Verify that no errors appear in the JS console

Offline tests

Sign in to ND
Create a workspace
Navigate to Workspace settings > Workflows > Add bank account
Start connecting a bank account flow (Plaid 1111, Alberta Charleson), exit the flow after entering the first and last name
Tap the pending bank account row
Open the debug menu, go force offline
Tap "Start over" and confirm
Verify the bank account is marked as deleted (struck through)
"Kill" and re-launch the tab/app, open Workspace settings/Workflows
Go online
Verify that the pending bank account item is deleted from Payments

QA Steps

Sign in to ND
Create a workspace
Navigate to Workspace settings > Workflows > Add bank account
Start connecting a bank account flow (Plaid 1111, Alberta Charleson), exit the flow after entering the first and last name
Tap the pending bank account row
Open the debug menu, go force offline
Tap "Start over" and confirm
Verify the bank account is marked as deleted (struck through)
"Kill" and re-launch the tab/app, open Workspace settings/Workflows
Go online
Verify that the pending bank account item is deleted from Payments

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

…ankAccount When resetting a bank account via "Start over", the BANK_ACCOUNT_LIST entry was not being cleared. This caused the pending bank account row to persist in WorkspaceWorkflowsPage after app restart while offline, since that page checks BANK_ACCOUNT_LIST for entries matching the workspace policyID. Following the existing pattern in deletePaymentBankAccount, this adds BANK_ACCOUNT_LIST updates to optimistic/success/failure data in both resetUSDBankAccount and resetNonUSDBankAccount. Co-authored-by: Eugene Voloshchak <eVoloshchak@users.noreply.github.com>

MelvinBot · 2026-05-10T21:43:35Z

I created this PR from an upstream branch since I don't have push access to your fork.

To take ownership of this branch and be able to push updates, run:

git remote add upstream https://github.com/Expensify/App.git
git fetch upstream claude-resetBankAccountListOnStartOver
git checkout -b claude-resetBankAccountListOnStartOver upstream/claude-resetBankAccountListOnStartOver
git push -u origin claude-resetBankAccountListOnStartOver

Then you can close this PR and open a new one from your fork.

eVoloshchak · 2026-05-24T13:57:51Z

@MelvinBot, pull the latest main

…ntListOnStartOver Co-authored-by: Eugene Voloshchak <eVoloshchak@users.noreply.github.com>

MelvinBot · 2026-05-24T14:03:56Z

Merged the latest main into this branch and pushed. The branch is now up to date.

eVoloshchak · 2026-05-25T08:31:34Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

video_2026-05-25_12-09-37.mp4

video_2026-05-25_12-09-30.mp4

Android: mWeb Chrome

Screen.Recording.2026-05-25.at.11.13.39.mov

iOS: HybridApp

Screen.Recording.2026-05-25.at.11.54.59.mov

iOS: mWeb Safari

Screen.Recording.2026-05-25.at.11.04.36.mov

MacOS: Chrome / Safari

Screen.Recording.2026-05-25.at.10.56.18.mov

eVoloshchak · 2026-05-25T08:50:51Z

@MelvinBot, mark the bank account as deleted (struck through) if it's pending deletion

Wrap bank account MenuItem with OfflineWithFeedback passing the bankAccountPendingAction so the row appears struck through while the delete is in flight offline. Co-authored-by: Eugene Voloshchak <eVoloshchak@users.noreply.github.com>

MelvinBot · 2026-05-25T08:54:18Z

Wrapped the bank account MenuItem in OfflineWithFeedback with the bank account's pendingAction, so the row now appears struck through while offline and pending deletion.

eVoloshchak · 2026-05-25T09:00:58Z

Sign in to ND
Create a workspace
Navigate to Workspace settings/ Workflows/ Add bank account
Start connecting a bank account flow (Plaid 1111, Alberta Charleson), exit the flow after entering the first and last name
Tap the pending bank account row
Open the debug menu, go force offline
Tap "Start over" and confirm
Verify the bank account is marked as deleted (struck through)
"Kill" and re-launch the tab/app, open Workspace settings/Workflows
Go online
Verify that the pending bank account item is deleted from Payments

@MelvinBot, use the steps above to populate Tests, Offline tests and QA tests in the checklist

MelvinBot · 2026-05-25T09:03:02Z

Updated the PR body with the provided steps in the Tests, Offline tests, and QA Steps sections. Also checked off the related checklist items for testing steps.

codecov · 2026-05-25T09:04:50Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
...ons/ReimbursementAccount/resetNonUSDBankAccount.ts	`0.00% <ø> (ø)`
...ctions/ReimbursementAccount/resetUSDBankAccount.ts	`61.53% <ø> (ø)`
...ges/workspace/workflows/WorkspaceWorkflowsPage.tsx	`0.00% <0.00%> (ø)`
... and 49 files with indirect coverage changes

codecov · 2026-05-25T09:05:01Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
...ons/ReimbursementAccount/resetNonUSDBankAccount.ts	`81.25% <ø> (+81.25%)`	⬆️
...ctions/ReimbursementAccount/resetUSDBankAccount.ts	`61.53% <ø> (ø)`
...ges/workspace/workflows/WorkspaceWorkflowsPage.tsx	`0.00% <0.00%> (ø)`
... and 52 files with indirect coverage changes

eVoloshchak · 2026-05-25T09:06:50Z

@MelvinBot, implement some unit tests for resetNonUSDBankAccount and resetUSDBankAccount

Tests verify that BANK_ACCOUNT_LIST is updated correctly during bank account reset: pendingAction set to DELETE optimistically, entry nulled on success, and pendingAction cleared on failure. Co-authored-by: Eugene Voloshchak <eVoloshchak@users.noreply.github.com>

MelvinBot · 2026-05-25T09:11:32Z

Added unit tests for resetUSDBankAccount and resetNonUSDBankAccount. All 7 tests pass:

resetUSDBankAccount:

Optimistically marks bank account with pendingAction: DELETE
Removes bank account from list on success

resetNonUSDBankAccount:

Optimistically marks bank account with pendingAction: DELETE
Removes bank account from list on success
Clears policy achAccount optimistically
Resets locally without API call when no bankAccountID

eVoloshchak · 2026-05-25T09:27:23Z

Wrapped the bank account MenuItem in OfflineWithFeedback with the bank account's pendingAction, so the row now appears struck through while offline and pending deletion.

@MelvinBot, this worked for web and mWeb, but not for native iOS and Android apps

OfflineWithFeedback applies textDecorationLine via View style which cascades on web via CSS but is ignored on native RN Views. Pass offlineFeedbackDeleted directly to MenuItem's titleStyle and descriptionTextStyle props so the strikethrough renders on all platforms. Co-authored-by: Eugene Voloshchak <eVoloshchak@users.noreply.github.com>

MelvinBot · 2026-05-25T09:40:39Z

The issue is that OfflineWithFeedback applies textDecorationLine via a View's style prop, which cascades to child text on web via CSS inheritance but is silently ignored on native React Native Views. Added explicit titleStyle and descriptionTextStyle props with offlineFeedbackDeleted directly on the MenuItem so the strikethrough renders on all platforms.

MelvinBot · 2026-05-25T09:41:13Z

⚠️ MelvinBot CI Fix Loop Detected

MelvinBot has made 5 consecutive commits trying to fix CI failures. Automatic CI fix dispatches are now paused for this PR.

Next steps: A human should review the recent commits and resolve the conflicting CI errors manually.

eVoloshchak

LGTM!
@MelvinBot, mark this as ready for review

melvin-bot · 2026-05-25T10:10:36Z

We did not find an internal engineer to review this PR, trying to assign a random engineer to #89895 as well as to this PR... Please reach out for help on Slack if no one gets assigned!

MelvinBot · 2026-05-25T10:11:56Z

Marked this PR as ready for review.

melvin-bot · 2026-05-25T10:11:56Z

@eVoloshchak Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

eVoloshchak · 2026-05-25T10:13:58Z

@MelvinBot, check off every checkbox in the PR author checklist

MelvinBot · 2026-05-25T10:17:02Z

Done — checked off every checkbox in the PR Author Checklist.

github-actions · 2026-05-25T22:49:51Z

🚧 @cead22 has triggered a test Expensify/App build. You can view the workflow run here.

OSBotify · 2026-05-25T22:53:22Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2026-05-25T22:54:59Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #90133.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-cdd884f9af2-75cbb1b-5ac1ab9e801d00a32195495a89b882d2a5ec2e7e/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-cdd884f-75cbb1b-fb58f8ec5a2e92fb3013943a04c5b4b1958c152f/index.html

Web 🕸️
https://90133.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-05-26T20:37:51Z

🚀 Deployed to staging by https://github.com/cead22 in version: 9.3.83-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

MelvinBot · 2026-05-26T20:39:31Z

I reviewed the changes in this PR against the help site articles under App/docs/articles/.

No help site changes are required. This PR is a bug fix for offline behavior when resetting a bank account via "Start over" — it adds proper BANK_ACCOUNT_LIST cleanup in the optimistic/success/failure data and visual offline feedback in the Workflows page. No user-facing features, workflows, navigation paths, or terminology were added or changed.

The existing help site articles (e.g., Connect-a-Business-Bank-Account.md, Workspace-Workflows.md) don't document the "Start over" / reset bank account flow, so there's nothing to update.

@eVoloshchak, please review the linked help site PR and confirm it reflects the current behavior. Then mark the linked help site PR Ready for review

mitarachim · 2026-05-27T04:05:24Z

The issue #91783 is repro on all PRs. Could you please double check if it's not introduced by #90133

OSBotify · 2026-05-27T17:27:28Z

🚀 Deployed to production by https://github.com/mountiny in version: 9.3.83-3 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

MelvinBot assigned eVoloshchak May 10, 2026

MelvinBot requested a review from a team May 10, 2026 21:43

MelvinBot mentioned this pull request May 10, 2026

[Due for payment 2026-06-03] [$250] Add BA - Bank account is still shown in Payments after tapping Start over offline #89895

Closed

7 tasks

Merge remote-tracking branch 'origin/main' into claude-resetBankAccou…

38380ca

…ntListOnStartOver Co-authored-by: Eugene Voloshchak <eVoloshchak@users.noreply.github.com>

eVoloshchak approved these changes May 25, 2026

View reviewed changes

melvin-bot Bot requested a review from cead22 May 25, 2026 10:10

MelvinBot marked this pull request as ready for review May 25, 2026 10:11

MelvinBot requested a review from a team as a code owner May 25, 2026 10:11

melvin-bot Bot requested review from eVoloshchak and heyjennahay May 25, 2026 10:11

melvin-bot Bot removed the request for review from a team May 25, 2026 10:11

eVoloshchak approved these changes May 25, 2026

View reviewed changes

cead22 approved these changes May 25, 2026

View reviewed changes

cead22 merged commit cdd884f into main May 25, 2026
54 of 55 checks passed

cead22 deleted the claude-resetBankAccountListOnStartOver branch May 25, 2026 22:43

OSBotify mentioned this pull request May 26, 2026

Deploy Checklist: New Expensify 2026-05-26 #91756

Closed

54 tasks

Uh oh!

Conversation

MelvinBot commented May 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

MelvinBot commented May 10, 2026

Uh oh!

eVoloshchak commented May 24, 2026

Uh oh!

MelvinBot commented May 24, 2026

Uh oh!

eVoloshchak commented May 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

eVoloshchak commented May 25, 2026

Uh oh!

MelvinBot commented May 25, 2026

Uh oh!

eVoloshchak commented May 25, 2026

Uh oh!

MelvinBot commented May 25, 2026

Uh oh!

codecov Bot commented May 25, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

codecov Bot commented May 25, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

eVoloshchak commented May 25, 2026

Uh oh!

MelvinBot commented May 25, 2026

Uh oh!

eVoloshchak commented May 25, 2026

Uh oh!

MelvinBot commented May 25, 2026

Uh oh!

MelvinBot commented May 25, 2026

Uh oh!

eVoloshchak left a comment

Choose a reason for hiding this comment

Uh oh!

melvin-bot Bot commented May 25, 2026

Uh oh!

MelvinBot commented May 25, 2026

Uh oh!

melvin-bot Bot commented May 25, 2026

Uh oh!

eVoloshchak commented May 25, 2026

Uh oh!

MelvinBot commented May 25, 2026

Uh oh!

Uh oh!

github-actions Bot commented May 25, 2026

Uh oh!

OSBotify commented May 25, 2026

Uh oh!

github-actions Bot commented May 25, 2026

Uh oh!

OSBotify commented May 26, 2026

Uh oh!

MelvinBot commented May 26, 2026

Uh oh!

mitarachim commented May 27, 2026

Uh oh!

OSBotify commented May 27, 2026

Uh oh!

Reviewers

Assignees

Labels

MelvinBot commented May 10, 2026 •

edited

Loading

eVoloshchak commented May 25, 2026 •

edited

Loading

codecov Bot commented May 25, 2026 •

edited by github-actions Bot

Loading

codecov Bot commented May 25, 2026 •

edited by github-actions Bot

Loading