Skip to content

Fix freeze when opening "Add approval workflow" on workspaces with many members #89268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mountiny merged 1 commit into from
May 1, 2026
Merged

Fix freeze when opening "Add approval workflow" on workspaces with many members #89268

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions src/pages/workspace/workflows/approvals/WorkspaceWorkflowsApprovalsExpensesFromPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@ function WorkspaceWorkflowsApprovalsExpensesFromPage({policy, isLoadingReportDat
const shouldShowListEmptyContent = !isLoadingApprovalWorkflow && approvalWorkflow?.availableMembers.length === 0;
const firstApprover = approvalWorkflow?.originalApprovers?.[0]?.email ?? '';
const isCreateAction = approvalWorkflow?.action === CONST.APPROVAL_WORKFLOW.ACTION.CREATE;
const policyMemberEmailsToAccountIDs = getMemberAccountIDsForWorkspace(policy?.employeeList);

// Build a map of member emails to their existing workflow's approver email (for non-default workflows only)
const membersInExistingWorkflows = (() => {
Expand Down Expand Up @@ -75,7 +76,6 @@ function WorkspaceWorkflowsApprovalsExpensesFromPage({policy, isLoadingReportDat
// eslint-disable-next-line react-hooks/set-state-in-effect
setSelectedMembers(
approvalWorkflow.members.map((member) => {
const policyMemberEmailsToAccountIDs = getMemberAccountIDsForWorkspace(policy?.employeeList);
const accountID = Number(policyMemberEmailsToAccountIDs[member.email] ?? '');

return {
Expand All @@ -95,15 +95,14 @@ function WorkspaceWorkflowsApprovalsExpensesFromPage({policy, isLoadingReportDat
};
}),
);
}, [approvalWorkflow?.members, policy?.employeeList, policy?.owner, translate, icons.FallbackAvatar]);
}, [approvalWorkflow?.members, policy?.employeeList, policy?.owner, policyMemberEmailsToAccountIDs, translate, icons.FallbackAvatar]);
Comment thread
TMisiukiewicz marked this conversation as resolved.

const approversEmail = approvalWorkflow?.approvers.map((member) => member?.email);
const allApprovers: SelectionListApprover[] = [...selectedMembers];

if (approvalWorkflow?.availableMembers) {
const availableMembers = approvalWorkflow.availableMembers
.map((member) => {
const policyMemberEmailsToAccountIDs = getMemberAccountIDsForWorkspace(policy?.employeeList);
const accountID = Number(policyMemberEmailsToAccountIDs[member.email] ?? '');

return {
Expand Down
Loading