[No QA] Add Coming from Expensify Classic help site article#88813
Conversation
Draft help site article mapping Classic features to New Expensify equivalents, per Expensify/Expensify#629165. Co-authored-by: Stephanie Elliott <stephanieelliott@users.noreply.github.com>
Co-authored-by: Stephanie Elliott <stephanieelliott@users.noreply.github.com>
|
Fixed the failing spellcheck: added |
This comment has been minimized.
This comment has been minimized.
|
The only failing check is the PR Author Checklist, which requires manual completion by the PR author — it's not a code issue. All code checks (ESLint, Prettier, spellcheck, etc.) are passing. The To resolve the checklist failure, complete the author checklist items in the PR description. |
|
The Failing check: Why it's unrelated: This PR only modifies The only other failing check is To proceed: Re-run the |
…ensify-Classic-for-Submitters-and-Approvers.md
Added a guide for Workspace Admins transitioning from Expensify Classic to New Expensify, detailing changes in workflows and features.
Co-authored-by: Stephanie Elliott <stephanieelliott@users.noreply.github.com>
|
Fixed the spellcheck failure: corrected typo The |
|
The failing Analysis: The build failed during "Set up job" with Evidence: The build run never reached the code checkout step. The error occurs at the runner level, not in any file this PR touches. Recommendation: Re-run the failed |
|
The failing Analysis: The build failed with Evidence: This PR only changes documentation files ( |
|
The failing Evidence: The failure occurs before any code is checked out or built. The PR only adds a markdown documentation file, and all code-related checks (ESLint, Prettier, spellcheck, verify) passed. Re-running the failed workflow should resolve it. |
Concierge reviewer checklist:
For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member? |
|
@parasharrajat @brianlee-expensify One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
The failing checks are unrelated to this documentation-only PR.
Recommendation: Re-run the failing checks. If |
| --- | ||
| title: Coming from Expensify Classic for Workspace Admins | ||
| description: Learn how familiar Workspace management, approval, reimbursement, company card, and policy workflows work in New Expensify. | ||
| keywords: [Expensify Classic admin, New Expensify Workspace Admin, company cards, approval workflows, Workspace rules, migration guide] |
There was a problem hiding this comment.
Terminology violation: The word "policy" should be "Workspace" to match current Expensify UI terminology (per HELPSITE_NAMING_CONVENTIONS.md). Suggested fix:
| keywords: [Expensify Classic admin, New Expensify Workspace Admin, company cards, approval workflows, Workspace rules, migration guide] | |
| description: Learn how familiar Workspace management, approval, reimbursement, company card, and Workspace rule workflows work in New Expensify. |
There was a problem hiding this comment.
@stephanieelliott thoughts on the suggested change?
HelpDot Documentation ReviewOverall AssessmentThis PR adds two new migration guides under Scores Summary
Key FindingsPositive aspects:
Issues to address:
Recommendations
Files Reviewed
|
|
A preview of your ExpensifyHelp changes have been deployed to https://1ee88044.helpdot.pages.dev ⚡️ Updated articles: |
HelpDot Documentation ReviewOverall AssessmentThis PR introduces two well-crafted migration guides for users transitioning from Expensify Classic to New Expensify — one for Submitters/Approvers and one for Workspace Admins. Both articles are clearly written, use effective comparison tables, and provide strong cross-linking to deeper feature articles. The articles follow governance standards closely with only a few items to address. Scores Summary
Key Findings
Recommendations
Files Reviewed
Note: Review based on governance files HELPSITE_NAMING_CONVENTIONS.md, HELP_AUTHORING_GUIDELINES.md, and TEMPLATE.md. |
|
Ok. ready for review now @brianlee-expensify! |
|
@brianlee-expensify looks like this was merged without a test passing. Please add a note explaining why this was done and remove the |
HelpDot Documentation ReviewOverall AssessmentThis PR adds two new migration guide articles for users transitioning from Expensify Classic to New Expensify -- one targeting submitters and approvers, and one targeting Workspace Admins. Both articles are well-structured, clearly written, and serve a genuine user need. The comparison table format is effective for orientation-style content. A few governance compliance items should be addressed. Scores Summary
Key FindingsIssues to address:
Positive aspects:
Recommendations
Files Reviewed
Note: Detailed line-by-line feedback has been provided as inline comments. |
|
🚀 Deployed to staging by https://github.com/brianlee-expensify in version: 9.3.83-0 🚀
Bundle Size Analysis (Sentry): |
|
🚀 Deployed to production by https://github.com/mountiny in version: 9.3.83-3 🚀
|
Explanation of Change
Adds a new help site article "Coming from Expensify Classic" under
docs/articles/new-expensify/getting-started/. This migration guide maps familiar Expensify Classic concepts and features to their New Expensify equivalents, helping transitioning users find what they need without contacting support.The article follows HELPSITE_NAMING_CONVENTIONS.md, HELP_AUTHORING_GUIDELINES.md, and TEMPLATE.md guidelines, including task-based headings, exact UI terminology, YAML metadata, and relative cross-links.
Fixed Issues
$ https://github.com/Expensify/Expensify/issues/629165
PROPOSAL:
Tests
// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.
Offline tests
N/A — this is a documentation-only change.
QA Steps
// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
// Please describe what QA needs to do to validate your changes and what areas do they need to test for regressions.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
N/A — documentation only
Android: mWeb Chrome
N/A — documentation only
iOS: Native
N/A — documentation only
iOS: mWeb Safari
N/A — documentation only
MacOS: Chrome / Safari
N/A — documentation only