Revert "Sage Intacct BT dynamic routes, part 1" (#87554) — fixes #88434 by neil-marcellini · Pull Request #88490 · Expensify/App

neil-marcellini · 2026-04-21T23:14:16Z

(Neil's AI agent)

Explanation of Change

Revert of #87554, identified via git bisect --first-parent as the first-bad commit that causes issue #88434 ("Split: 'Not here' page displayed when selecting split dates") on staging and main.

Root cause (sneaky cross-cutting bug):

#87554 added three new entries to DYNAMIC_ROUTES (in src/ROUTES.ts) with overly-generic path values:

POLICY_ACCOUNTING_SAGE_INTACCT_EXPORT_DATE:          { path: 'date',           entryScreens: [...SAGE_INTACCT_EXPORT] },
POLICY_ACCOUNTING_SAGE_INTACCT_REIMBURSABLE_EXPENSES:{ path: 'reimbursable',   entryScreens: [...SAGE_INTACCT_EXPORT] },
POLICY_ACCOUNTING_SAGE_INTACCT_NON_REIMBURSABLE_EXPENSES:{ path: 'nonreimbursable', entryScreens: [...SAGE_INTACCT_EXPORT] },

src/libs/Navigation/helpers/dynamicRoutesUtils/findMatchingDynamicSuffix.ts matches dynamic suffixes against a global dynamicRoutePaths Set, without consulting entryScreens. So 'date' is now globally registered as a dynamic suffix, and any URL whose tail segment is date gets matched.

The split-expense Date tab URL is /create/split-expense/overview/<reportID>/<transactionID>/<draftID>/date. When SplitExpenseCreateDateRagePage calls Navigation.goBack(backTo), the matcher sees date at the end and treats the URL as a Sage Intacct Export Date dynamic route, misrouting back-navigation. SplitExpensePage then falls through to its FullPageNotFoundView.

The same landmine exists for reimbursable and nonreimbursable — no known current collisions, but they're footguns.

Proper forward fix (for a follow-up PR by the original author): either make findMatchingDynamicSuffix scope to entryScreens, or enforce specific, globally-unique path values in DYNAMIC_ROUTES (e.g. sage-intacct-export-date). This revert is the short-term unblock.

Conflict: one merge conflict on src/libs/Navigation/linkingConfig/OldRoutes.ts; resolved by keeping a NetSuite redirect from a later unrelated PR and dropping only the two Sage Intacct redirects #87554 added.

Fixed Issues

$ #88434

Tests

Workspace chat → FAB → Create expense → enter amount → Next → submitter → create.
Open the expense → Details → Split.
Tap the Date tab → tap the Date cell on a split row.
Pick two dates → Save.
Verify you land back on the Split/Date view with all split rows intact (not on a "Not here" page).

Verify that no errors appear in the JS console

2026-04-21_16-19-09.mp4

Offline tests

N/A — pure revert.

QA Steps

Same as Tests.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

N/A see above

…xport-1" This reverts commit ae2d424, reversing changes made to 0d9f70c.

melvin-bot · 2026-04-21T23:20:52Z

@bernhardoj Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

codecov · 2026-04-21T23:23:44Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/SCREENS.ts	`100.00% <ø> (ø)`
src/libs/Navigation/linkingConfig/OldRoutes.ts	`100.00% <ø> (ø)`
...gation/linkingConfig/RELATIONS/WORKSPACE_TO_RHP.ts	`100.00% <ø> (ø)`
src/libs/Navigation/linkingConfig/config.ts	`76.92% <ø> (ø)`
...eIntacctNonReimbursableExpensesDestinationPage.tsx	`0.00% <ø> (ø)`
.../accounting/intacct/export/SageIntacctDatePage.tsx	`0.00% <0.00%> (ø)`
.../export/SageIntacctNonReimbursableExpensesPage.tsx	`0.00% <0.00%> (ø)`
...ntacct/export/SageIntacctPreferredExporterPage.tsx	`0.00% <0.00%> (ø)`
...SageIntacctReimbursableExpensesDestinationPage.tsx	`0.00% <0.00%> (ø)`
...cct/export/SageIntacctReimbursableExpensesPage.tsx	`0.00% <0.00%> (ø)`
... and 3 more
... and 9 files with indirect coverage changes

marcaaron · 2026-04-21T23:24:09Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f74be48d1c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-04-21T23:30:33Z

    '/workspaces/*/connections/netsuite/export/invoice-item-preference/invoice-item/select': '/workspaces/$1/connections/netsuite/export/invoice-item-preference/select/invoice-item/select',
-    '/workspaces/*/accounting/sage-intacct/export/preferred-exporter': '/workspaces/$1/accounting/sage-intacct/export/sage-preferred-exporter',
-    '/workspaces/*/accounting/sage-intacct/export/reimbursable/destination': '/workspaces/$1/accounting/sage-intacct/export/reimbursable-expenses',
    '/workspaces/*/connections/quickbooks-online/advanced/autosync/accounting-method':


Restore redirects for reverted Sage Intacct URLs

Removing the Sage Intacct entries from oldRoutes drops compatibility for URLs that were generated by the prior release (.../export/sage-preferred-exporter and .../export/reimbursable-expenses). After this revert, those paths are no longer present in either ROUTES or DYNAMIC_ROUTES, so reopening a bookmarked tab or refreshing on one of those URLs will route to Not Found instead of the restored screens. Keep legacy redirects in OldRoutes from the removed paths to the current routes (.../preferred-exporter and .../reimbursable/destination).

Useful? React with 👍 / 👎.

github-actions · 2026-04-21T23:32:02Z

🚧 @neil-marcellini has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-04-21T23:35:59Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #88490.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-8d953c1-cbc9c0e-849f1420ff68a2052e0984a54f05223990685749/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-8d953c1-cbc9c0e-9a8e132c52b69eea4087bcd14e7a0d46d06b82f7/index.html

Web 🕸️
https://88490.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-04-21T23:40:22Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

Revert "Sage Intacct BT dynamic routes, part 1" (#87554) — fixes #88434 (cherry picked from commit 8d953c1) (cherry-picked to staging by marcaaron)

…752440269-1 🍒 Cherry pick PR #88490 to staging 🍒

OSBotify · 2026-04-22T01:19:30Z

🚀 Cherry-picked to staging by https://github.com/neil-marcellini in version: 9.3.61-2 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

MelvinBot · 2026-04-22T01:20:58Z

No help site changes are required for this PR.

This is a pure code-level revert of internal navigation routing for Sage Intacct export pages. It doesn't change any user-facing features, UI labels, settings, or functionality — it only reverts how dynamic route paths were registered internally to fix a navigation bug. The existing Sage Intacct help articles remain accurate.

OSBotify · 2026-04-23T20:03:00Z

🚀 Deployed to production by https://github.com/marcaaron in version: 9.3.61-4 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-04-23T20:21:36Z

🚀 Cherry-picked to staging by https://github.com/neil-marcellini in version: 9.3.62-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

OSBotify · 2026-04-28T01:41:40Z

🚀 Cherry-picked to staging by https://github.com/neil-marcellini in version: 9.3.64-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

MelvinBot · 2026-04-28T01:42:55Z

No help site changes are required for this PR.

This is a pure revert of internal navigation routing code (dynamic route paths and screen names for Sage Intacct export pages). It fixes a navigation bug but does not change any user-facing features, UI labels, settings, or functionality documented in docs/articles.

OSBotify · 2026-04-30T22:48:54Z

🚀 Deployed to production by https://github.com/arosiclair in version: 9.3.64-31 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Revert "Merge pull request #87554 from mananjadhav/mj-83845-bt-sage-e…

f74be48

…xport-1" This reverts commit ae2d424, reversing changes made to 0d9f70c.

melvin-bot Bot assigned neil-marcellini Apr 21, 2026

neil-marcellini marked this pull request as ready for review April 21, 2026 23:20

neil-marcellini requested review from a team as code owners April 21, 2026 23:20

melvin-bot Bot requested review from bernhardoj and removed request for a team April 21, 2026 23:20

melvin-bot Bot requested review from flaviadefaria and removed request for a team April 21, 2026 23:20

neil-marcellini requested a review from marcaaron April 21, 2026 23:20

marcaaron approved these changes Apr 21, 2026

View reviewed changes

marcaaron removed request for bernhardoj and flaviadefaria April 21, 2026 23:24

chatgpt-codex-connector Bot reviewed Apr 21, 2026

View reviewed changes

neil-marcellini merged commit 8d953c1 into main Apr 21, 2026
48 of 51 checks passed

neil-marcellini deleted the neil/revert-87554-fix-88434 branch April 21, 2026 23:31

os-botify Bot mentioned this pull request Apr 21, 2026

🍒 Cherry pick PR #88490 to staging 🍒 #88494

Merged

50 tasks

OSBotify added the CP Staging marks PRs that have been CP'd to staging label Apr 21, 2026

roryabraham added a commit that referenced this pull request Apr 22, 2026

Merge pull request #88494 from Expensify/cherry-pick-staging-88490-24…

ce2c02c

…752440269-1 🍒 Cherry pick PR #88490 to staging 🍒

OSBotify mentioned this pull request Apr 22, 2026

Deploy Checklist: New Expensify 2026-04-21 #88394

Closed

melvin-bot Bot mentioned this pull request Apr 30, 2026

[Due for payment 2026-05-07] Split: “Not here” page displayed when selecting split dates #88434

Closed

7 tasks

Uh oh!

Conversation

neil-marcellini commented Apr 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Apr 21, 2026

Uh oh!

codecov Bot commented Apr 21, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

marcaaron commented Apr 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Apr 21, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions Bot commented Apr 21, 2026

Uh oh!

github-actions Bot commented Apr 21, 2026

Uh oh!

OSBotify commented Apr 21, 2026

Uh oh!

OSBotify commented Apr 22, 2026

Uh oh!

MelvinBot commented Apr 22, 2026

Uh oh!

OSBotify commented Apr 23, 2026

Uh oh!

OSBotify commented Apr 23, 2026

Uh oh!

OSBotify commented Apr 28, 2026

Uh oh!

MelvinBot commented Apr 28, 2026

Uh oh!

OSBotify commented Apr 30, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

neil-marcellini commented Apr 21, 2026 •

edited

Loading

codecov Bot commented Apr 21, 2026 •

edited by github-actions Bot

Loading

marcaaron commented Apr 21, 2026 •

edited

Loading