Fix - Expensify Card - Issue card button is unresponsive when attempting to issue a second card#88141
Conversation
…button becoming unresponsive
|
@Krishna2323 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
@roryabraham Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
🚧 @francoisl has triggered a test Expensify/App build. You can view the workflow run here. |
This comment has been minimized.
This comment has been minimized.
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / Safariandroid_hybrid.mp4 |
…6-fix-issue-card-unresponsive Fix - Expensify Card - Issue card button is unresponsive when attempting to issue a second card (cherry picked from commit b051dc6) (cherry-picked to staging by francoisl)
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Cherry-picked to staging by https://github.com/francoisl in version: 9.3.60-9 🚀
Bundle Size Analysis (Sentry): |
|
No help site changes required. This PR is a purely internal bug fix — it renames an Onyx key ( |
|
🚧 @francoisl has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Cherry-picked to staging by https://github.com/francoisl in version: 9.3.60-10 🚀
Bundle Size Analysis (Sentry): |
|
No help site changes are required for this PR. The changes are purely internal — renaming an Onyx storage key from |
|
🚀 Deployed to production by https://github.com/mountiny in version: 9.3.60-22 🚀
|
|
🚀 Cherry-picked to staging by https://github.com/francoisl in version: 9.3.61-0 🚀
Bundle Size Analysis (Sentry): |
|
No help site documentation changes are required for this PR. The changes are purely internal — renaming an Onyx storage key ( |
|
🚀 Deployed to production by https://github.com/marcaaron in version: 9.3.61-4 🚀
|
Explanation of Change
This PR removes the changes from #87254 that caused the bug. The key will be migrated in part 3.
Simulator.Screen.Recording.-.iPhone.16.Pro.-.2026-04-16.at.19.30.07.mp4
Fixed Issues
$ #88106
PROPOSAL: N/A
Tests
Offline tests
N/A
QA Steps
Same as Tests section above.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari