Allow decimal values in Chronos Schedule OOO duration input#88042
Conversation
Change decimals prop from 0 to 2 on the AmountForm component in ChronosScheduleOOOPage to allow users to enter non-round duration amounts like 1.5 hours. The existing validation regex already supports decimal values. Co-authored-by: Francois Laithier <francoisl@users.noreply.github.com>
|
For some reason Chronos doesn't work in dev, going to try with an ad-hoc build... |
|
🚧 @francoisl has triggered a test Expensify/App build. You can view the workflow run here. |
This comment has been minimized.
This comment has been minimized.
|
@ikevin127 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
No need for C+ review on this one, thanks |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / Safari |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚧 @francoisl has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/francoisl in version: 9.3.61-0 🚀
Bundle Size Analysis (Sentry): |
|
No help site changes are required for this PR. The Chronos "Schedule OOO" feature is an internal tool with no corresponding documentation under |
|
Did Internal QA for this pass @francoisl ? |
|
Yes, sorry I could have sworn I checked it off the checklist yesterday but apparently not. Checked it now. |
|
🚀 Deployed to production by https://github.com/marcaaron in version: 9.3.61-4 🚀
|
Explanation of Change
The Duration input in the Chronos "Schedule Out of Office" page (
ChronosScheduleOOOPage.tsx) haddecimals={0}on theAmountFormcomponent, which restricted input to integer values only. Since the available time units are Hour, Day, Week, and Month (no minutes), users need to enter decimal values like1.5hours. This changesdecimalsfrom0to2to allow up to 2 decimal places. The existing validation regex already supports decimal values.Fixed Issues
$ https://github.com/Expensify/Expensify/issues/624907
Tests
Same as QA
Offline tests
N/A — this change only affects input validation, no network calls involved.
QA Steps
ooo remove <event ID from step 3>PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
MacOS: Chrome / Safari
Screen.Recording.2026-04-16.at.15.45.10.mov