Skip to content

Fix Page scrolls to the top after switching to landscape mode & entering number#87656

Merged
mjasikowski merged 4 commits into
Expensify:mainfrom
software-mansion-labs:@GCyganek/landscape-mode/number-with-symbol-form-fixes
Apr 16, 2026
Merged

Fix Page scrolls to the top after switching to landscape mode & entering number#87656
mjasikowski merged 4 commits into
Expensify:mainfrom
software-mansion-labs:@GCyganek/landscape-mode/number-with-symbol-form-fixes

Conversation

@GCyganek

@GCyganek GCyganek commented Apr 10, 2026

Copy link
Copy Markdown
Contributor

Explanation of Change

Allowing focus in landscape mode for NumberWithSymbolForm text input, adjusting the layout to make sure that key pad & text input are always visible together to fix the problem with auto scrolling to the input.

Fixed Issues

$ #87364, #87314, #87333

PROPOSAL: N/A

Tests

  1. Launch Expensify app in landscape mode.

  2. Open FAB > Create expense > Manual.

  3. Verify cursor will auto appear on amount input page in landscape mode.

  4. Launch Expensify app in portrait mode.

  5. Open FAB > Create expense > Manual.

  6. Switch to landscape mode.

  7. Tap any number.

  8. Verify that there are no weird scroll behaviours

  9. Launch Expensify app in landscape mode.

  10. Open FAB > Create expense > Manual.

  11. Without entering amount, tap Next.

  12. Verify Amount error message appears below the amount, similar to portrait mode.

  • Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

Same as Tests

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Screen.Recording.2026-04-10.at.18.46.15.mov
image
iOS: Native
Screen.Recording.2026-04-10.at.18.45.27.mov

@GCyganek GCyganek requested review from a team as code owners April 10, 2026 16:48
@melvin-bot

melvin-bot Bot commented Apr 10, 2026

Copy link
Copy Markdown

Hey! I see that you made changes to our Form component. Make sure to update the docs in FORMS.md accordingly. Cheers!

@melvin-bot melvin-bot Bot requested review from heyjennahay and truph01 and removed request for a team April 10, 2026 16:48
@melvin-bot

melvin-bot Bot commented Apr 10, 2026

Copy link
Copy Markdown

@truph01 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot Bot removed the request for review from a team April 10, 2026 16:48
@GCyganek

Copy link
Copy Markdown
Contributor Author

@codex review

@GCyganek

GCyganek commented Apr 10, 2026

Copy link
Copy Markdown
Contributor Author

@Expensify/design could you take a look?

There was a problem that when the big number pad was below the input then in landscape mode you had to scroll to get to some of the buttons and input was not visible when scrolled down. I changed the layout and moved the number pad to the right, ensuring that the text input has at least 400px width of space to make sure there are no overflows. This fixes one of the issues reported for this component. The layout may not be perfect, but I was focused on improving the current situation in any way by fixing the reported bug so I was just focused on making sure the input is always visible when using the number pad, we can later adjust the layout for all screens with number pads to make sure they all look fine

Just to make sure, this layout change is only for the landscape mode, portrait mode is without any changes

It was also reported as a bug that there is no auto focus on this input (no cursor visible on it after opening the screen with the input + number pad), so I enabled auto focus for this one only, as we decided to disable it for all inputs globally to make sure keyboard is not opening every time user navigates to a screen with an input. This one does not open a keyboard, so I think we can make an exception here

@codecov

codecov Bot commented Apr 10, 2026

Copy link
Copy Markdown

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines Coverage Δ
src/components/BigNumberPad.tsx 83.33% <100.00%> (+3.33%) ⬆️
...nput/BaseTextInput/implementation/index.native.tsx 80.99% <100.00%> (+0.08%) ⬆️
src/styles/index.ts 48.78% <ø> (ø)
src/components/NumberWithSymbolForm.tsx 49.77% <12.50%> (-2.86%) ⬇️
... and 10 files with indirect coverage changes

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 4bcd7d8d6b

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread src/components/NumberWithSymbolForm.tsx
Comment thread src/components/NumberWithSymbolForm.tsx
@shawnborton

Copy link
Copy Markdown
Contributor

I think that looks fine to me, but we do have a version of this with smaller buttons (if your viewport is portrait mode and short), so just note that you could try a layout with smaller numberpad buttons that might allow us to have this view with no scrolling?

CleanShot 2026-04-13 at 08 06 27@2x CleanShot 2026-04-13 at 08 08 14@2x

@GCyganek

Copy link
Copy Markdown
Contributor Author

@shawn got it! Updated the buttons:

Screenshot 2026-04-13 at 09 38 19 Screenshot 2026-04-13 at 08 50 59

@shawnborton

Copy link
Copy Markdown
Contributor

Okay cool, let's see if the @Expensify/design is okay with that or if they prefer the larger buttons where we scroll the whole viewport. The larger buttons feel more friendly for accessibility so I wonder if that was the better path now...

@dannymcclain

Copy link
Copy Markdown
Contributor

Slightly tough call! The bigger buttons are obviously more easy to tap, but using the smaller buttons makes the whole screen read better IMO. I would probably lean towards the smaller buttons, but I'm curious if @dubielzyk-expensify has any concerns with that.

@dubielzyk-expensify

Copy link
Copy Markdown
Contributor

The smaller buttons still fit the minimum touch target so no a11y issues with it as long as we're not scaling them smaller than our small size. Just being aware that many different screen sizes so there's no guarantee of it being like that for everyone anyways. I think keeping them small to avoid isn't a bad shout. No feelings from me though

@shawnborton

Copy link
Copy Markdown
Contributor

Sounds good, thanks for the gut check. I say we roll with the smaller buttons then so it makes the page layout look better.

@GCyganek

Copy link
Copy Markdown
Contributor Author

@truph01 can you take a look?

@GCyganek

Copy link
Copy Markdown
Contributor Author

#87333 fixed here:

image

@truph01

truph01 commented Apr 15, 2026

Copy link
Copy Markdown
Contributor

@truph01 can you take a look?

Sure, I am on it now

@truph01

truph01 commented Apr 16, 2026

Copy link
Copy Markdown
Contributor

@GCyganek Could you merge main?

@truph01

truph01 commented Apr 16, 2026

Copy link
Copy Markdown
Contributor

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained ""why"" the code was doing something instead of only explaining ""what"" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named ""index.js"". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
Screen.Recording.2026-04-16.at.15.29.20.mov
Android: mWeb Chrome
iOS: HybridApp
Screen.Recording.2026-04-16.at.15.45.32.mov
iOS: mWeb Safari
MacOS: Chrome / Safari

@melvin-bot melvin-bot Bot requested a review from mjasikowski April 16, 2026 08:46
@GCyganek

Copy link
Copy Markdown
Contributor Author

@GCyganek Could you merge main?

Done

@mjasikowski mjasikowski merged commit e1e043b into Expensify:main Apr 16, 2026
32 checks passed
@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@github-actions

Copy link
Copy Markdown
Contributor

🚧 @mjasikowski has triggered a test Expensify/App build. You can view the workflow run here.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/mjasikowski in version: 9.3.61-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

@MelvinBot

Copy link
Copy Markdown
Contributor

No help site changes are required for this PR.

The changes are internal UI fixes for landscape mode on mobile (number pad button sizing, layout adjustments, and text input auto-focus behavior). They don't introduce new features, change any user-facing terminology, or alter documented workflows — the help articles describe expense creation at a high level and don't reference device orientation or number pad layout details.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/marcaaron in version: 9.3.61-4 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants