Fix task button truncation and bottom border radius in search tables#87619
Conversation
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
…ated style Signed-off-by: krishna2323 <belivethatkg@gmail.com>
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
…t item Signed-off-by: krishna2323 <belivethatkg@gmail.com>
|
Thanks for tackling these so quickly! |
|
🚧 @shawnborton has triggered a test Expensify/App build. You can view the workflow run here. |
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: cddaac5fd1
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
|
🤖 Code Review — PR #87619 All three fixes look correct and consistent. A few observations: Fix 1 (Task ACTION column 68→80px): The wider column is applied in three places — Fix 2 ( Fix 3 ( Re: Codex bot comment — the concern about No correctness issues found. LGTM. |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppScreen.Recording.2026-04-10.at.7.55.24.PM.moviOS: mWeb SafariMacOS: Chrome / Safariweb.mov |
|
@Krishna2323 @situchan I'm not going to CP this. Lets demote the blockers this fixes, since they are minor, and wait for the next deploy to get this in |
|
🚧 @JS00001 has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
luacmartins
left a comment
There was a problem hiding this comment.
Thanks for fixing it!
|
🚀 Deployed to staging by https://github.com/JS00001 in version: 9.3.59-0 🚀
Bundle Size Analysis (Sentry): |
|
No help site changes are needed for this PR. The changes are purely internal UI/styling fixes (action column width for task rows, bottom border radius, and overflow clipping). There are no new features, renamed UI elements, or modified user flows that would affect any documentation under |
|
🚀 Deployed to production by https://github.com/AndrewGable in version: 9.3.59-4 🚀
|
Explanation of Change
Fix 1: Task "Complete" button truncated (#87591)
The ACTION column was globally set to 68px, which is too narrow for the "Complete" button text in task rows. Added
isActionColumnWideparam togetReportTableColumnStylesso tasks use 80px while expenses/reports stay at 68px.Fix 2: Last item bottom border radius missing (#87581)
Reanimated animated styles always override static styles. The highlight animation was setting
borderRadius: 0on large screens, which overrode the staticsearchTableBottomRadius(12px bottom corners) on the last item. Fixed by passingshouldApplyOtherStyles: falseon large screens, so the animated style only controlsbackgroundColorandopacity— letting the static corner-specific radii take effect.Fix 3:
On large screens, the last search list item's wrapper has
searchTableBottomRadius(12px bottom corners). When the item is selected, the inner Pressable's greenactiveComponentBGbackground was visually overflowing past those rounded corners becauseborderRadiuson a parent doesn't automatically clip children in React Native for web. AddingoverflowHiddento the wrapper ensures the selected background is clipped at the rounded corners. This only applies to the last item on large screens, so narrow/medium layouts are unaffected.Fixed Issues
$ #87591
$ #87581
PROPOSAL:
Tests
Test 1:
Test 2:
Offline tests
QA Steps
Same as Tests
Verify that no errors appear in the JS console
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Monosnap.screencast.2026-04-10.18-36-36.mp4