Use ActivityIndicator instead of FullscreenLoadingIndicator in OnfidoPrivacy#87586
Merged
Conversation
…ivacy OnfidoPrivacy is rendered inside OnfidoStep which has a HeaderWithBackButton. When shouldUseGoBackButton is enabled by default on FullscreenLoadingIndicator, users would see two back controls. Replace with ActivityIndicator wrapped in a View that reproduces the same layout and background styling. Co-authored-by: Situ Chandra Shil <situchan@users.noreply.github.com>
…ject Co-authored-by: Situ Chandra Shil <situchan@users.noreply.github.com>
Contributor
Author
|
Fixed the failing check: replaced deprecated |
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
situchan
reviewed
Apr 10, 2026
Comment on lines
+81
to
+92
| <View style={[StyleSheet.absoluteFill, styles.fullScreenLoading, styles.w100]}> | ||
| <View style={styles.w100}> | ||
| <ActivityIndicator | ||
| size={CONST.ACTIVITY_INDICATOR_SIZE.LARGE} | ||
| reasonAttributes={{ | ||
| context: 'OnfidoPrivacy', | ||
| hasAcceptedPrivacyPolicy, | ||
| isLoading, | ||
| }} | ||
| /> | ||
| </View> | ||
| </View> |
Contributor
There was a problem hiding this comment.
Suggested change
| <View style={[StyleSheet.absoluteFill, styles.fullScreenLoading, styles.w100]}> | |
| <View style={styles.w100}> | |
| <ActivityIndicator | |
| size={CONST.ACTIVITY_INDICATOR_SIZE.LARGE} | |
| reasonAttributes={{ | |
| context: 'OnfidoPrivacy', | |
| hasAcceptedPrivacyPolicy, | |
| isLoading, | |
| }} | |
| /> | |
| </View> | |
| </View> | |
| <View style={[StyleSheet.absoluteFill, styles.fullScreenLoading]}> | |
| <ActivityIndicator | |
| size={CONST.ACTIVITY_INDICATOR_SIZE.LARGE} | |
| reasonAttributes={{ | |
| context: 'OnfidoPrivacy', | |
| hasAcceptedPrivacyPolicy, | |
| isLoading, | |
| }} | |
| /> | |
| </View> |
Contributor
Author
There was a problem hiding this comment.
Applied! Removed the extra styles.w100 and the inner <View> wrapper. d04af71
Remove unnecessary styles.w100 and inner View wrapper per review feedback. Co-authored-by: Situ Chandra Shil <situchan@users.noreply.github.com>
Contributor
Author
|
Code Review — LGTM ✅ The replacement is functionally equivalent to
No issues found. |
Contributor
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppios.moviOS: mWeb SafariMacOS: Chrome / Safariweb.movweb2.mov |
|
Codex Review: Didn't find any major issues. Breezy! ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
Contributor
|
@MelvinBot mark as ready for review |
Contributor
Author
|
PR has been marked as ready for review. |
melvin-bot
Bot
requested review from
joekaufmanexpensify and
situchan
and removed request for
a team
situchan
approved these changes
Apr 10, 2026
Contributor
|
🚧 @Julesssss has triggered a test Expensify/App build. You can view the workflow run here. |
Contributor
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
89 tasks
Contributor
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
Contributor
|
🚀 Deployed to staging by https://github.com/Julesssss in version: 9.3.59-0 🚀
Bundle Size Analysis (Sentry): |
Contributor
Author
|
No help site changes are needed for this PR. The change is purely technical — swapping one internal loading indicator component ( |
Contributor
|
🚀 Deployed to production by https://github.com/AndrewGable in version: 9.3.59-4 🚀
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Replace
FullscreenLoadingIndicatorwithActivityIndicator(wrapped in aViewwith identical styling) inOnfidoPrivacy.tsx. This is part of the loading indicator standardization effort —OnfidoPrivacyis rendered insideOnfidoStep, which already displays aHeaderWithBackButton. WhenshouldUseGoBackButtonis enabled by default onFullscreenLoadingIndicator, users would see two back controls. UsingActivityIndicatordirectly avoids this conflict while preserving the exact same visual output (same background color, opacity, centered large spinner).The replacement
Viewwrapper appliesStyleSheet.absoluteFillObject,styles.fullScreenLoading, andstyles.w100— the same styles thatFullscreenLoadingIndicatoruses internally.Fixed Issues
$ #85380
Tests
Offline tests
N/A — The loading state is shown while the Onfido flow initializes and requires network. No offline-specific behavior is affected by this change.
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
N/A — visual output is identical (same styles applied)
Android: mWeb Chrome
N/A — visual output is identical (same styles applied)
iOS: Native
N/A — visual output is identical (same styles applied)
iOS: mWeb Safari
N/A — visual output is identical (same styles applied)
MacOS: Chrome / Safari
N/A — visual output is identical (same styles applied)
Checks run