[No QA] refactor: add selector to AccountManagerBanner for PERSONAL_DETAILS_LIST by BartekObudzinski · Pull Request #87558 · Expensify/App

BartekObudzinski · 2026-04-10T06:39:57Z

Explanation of Change

Split from #87479.

AccountManagerBanner was subscribing to the entire PERSONAL_DETAILS_LIST Onyx key and then extracting a single account manager's personal details using getPersonalDetailsForAccountIDs. This caused the component to re-render whenever any user's personal details changed, even though it only needs the account manager's data.

This change replaces that full subscription with a targeted useOnyx selector that extracts only the account manager's personal details by account ID. The getPersonalDetailsForAccountIDs helper and its import are no longer needed and have been removed.

Fixed Issues

$ #87633
PROPOSAL:

Tests

Verify that no errors appear in the JS console
Verify AccountManagerBanner still renders correctly when an account manager is assigned
Verify no regressions in Inbox screen loading

Offline tests

N/A

QA Steps

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

melvin-bot · 2026-04-10T14:37:40Z

@ZhenjaHorbach Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

BartekObudzinski · 2026-04-10T14:38:13Z

@codex review

ZhenjaHorbach · 2026-04-10T14:39:11Z

-    const [personalDetails] = useOnyx(ONYXKEYS.PERSONAL_DETAILS_LIST);
+    const accountManagerAccountID = getParticipantsAccountIDsForDisplay(accountManagerReport, false, true)?.at(0) ?? -1;
+    const [participantPersonalDetail] = useOnyx(ONYXKEYS.PERSONAL_DETAILS_LIST, {
+        selector: (details) => details?.[accountManagerAccountID],


Let's create a selector in the selectors folder and then write tests for this selector

Done, reused the existing personalDetailsSelector from src/selectors/PersonalDetails.ts. Tests for it already exist.

ZhenjaHorbach · 2026-04-10T14:40:08Z

    const [accountManagerReportID] = useOnyx(ONYXKEYS.ACCOUNT_MANAGER_REPORT_ID);
    const [accountManagerReport] = useOnyx(`${ONYXKEYS.COLLECTION.REPORT}${getNonEmptyStringOnyxID(accountManagerReportID)}`);
-    const [personalDetails] = useOnyx(ONYXKEYS.PERSONAL_DETAILS_LIST);
+    const accountManagerAccountID = getParticipantsAccountIDsForDisplay(accountManagerReport, false, true)?.at(0) ?? -1;


Let's use DEFAULT_MISSING_ID instead -1

Done, switched to CONST.DEFAULT_MISSING_ID.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c9b7a584bf

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

ZhenjaHorbach · 2026-04-13T09:32:20Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

2026-04-13.11.47.27.mov

ZhenjaHorbach · 2026-04-13T09:56:56Z

LGTM!

trjExpensify · 2026-04-13T10:59:11Z

PR doesn’t need product input as a refactor PR. Unassigning and unsubscribing myself.

github-actions · 2026-04-13T11:37:42Z

🚧 @JS00001 has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-04-13T11:42:47Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #87558.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-f5bdf41-08ff3fc-04451a178139ff3470d2e24b3c6115cdb2a6aebe/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-f5bdf41-08ff3fc-7d1a95eb7751d7cae4988e2d4baeac7a1bbd45f3/index.html

Web 🕸️
https://87558.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-04-13T11:45:23Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2026-04-13T20:34:26Z

🚀 Deployed to staging by https://github.com/JS00001 in version: 9.3.59-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	cancelled 🔪
🍎 iOS 🍎	cancelled 🔪

Bundle Size Analysis (Sentry):

Android

MelvinBot · 2026-04-13T20:35:38Z

No help site changes are required for this PR.

This is a pure internal performance refactoring — it replaces a broad Onyx subscription with a targeted useOnyx selector in AccountManagerBanner.tsx (6 lines changed). No user-facing features, UI text, settings, or behavior were added, removed, or modified. There is nothing to document on the help site.

OSBotify · 2026-04-16T03:31:08Z

🚀 Deployed to production by https://github.com/AndrewGable in version: 9.3.59-4 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

refactor: add selector to AccountManagerBanner for PERSONAL_DETAILS_LIST

c9b7a58

melvin-bot Bot assigned BartekObudzinski Apr 10, 2026

BartekObudzinski changed the title ~~refactor: add selector to AccountManagerBanner for PERSONAL_DETAILS_LIST~~ refactor: add selector to AccountManagerBanner for PERSONAL_DETAILS_LIST [No QA] Apr 10, 2026

BartekObudzinski changed the title ~~refactor: add selector to AccountManagerBanner for PERSONAL_DETAILS_LIST [No QA]~~ [No QA] refactor: add selector to AccountManagerBanner for PERSONAL_DETAILS_LIST Apr 10, 2026

This was referenced Apr 10, 2026

[WIP] refactor: Onyx cleanup in AccountManagerBanner and ReportNotFoundGuard #87479

Closed

[Metrics] Improve ManualNavigateToInboxTab #77175

Open

JS00001 mentioned this pull request Apr 10, 2026

[Due for payment 2026-04-23] Add selector to AccountManagerBanner for PERSONAL_DETAILS_LIST #87633

Closed

BartekObudzinski marked this pull request as ready for review April 10, 2026 14:37

BartekObudzinski requested review from a team as code owners April 10, 2026 14:37

melvin-bot Bot requested review from ZhenjaHorbach and removed request for a team April 10, 2026 14:37

melvin-bot Bot requested review from trjExpensify and removed request for a team April 10, 2026 14:37

ZhenjaHorbach reviewed Apr 10, 2026

View reviewed changes

chatgpt-codex-connector Bot reviewed Apr 10, 2026

View reviewed changes

Comment thread src/pages/inbox/AccountManagerBanner.tsx

refactor: use personalDetailsSelector and DEFAULT_MISSING_ID

865496c

ZhenjaHorbach approved these changes Apr 13, 2026

View reviewed changes

melvin-bot Bot requested a review from JS00001 April 13, 2026 09:57

trjExpensify removed their request for review April 13, 2026 10:59

JS00001 approved these changes Apr 13, 2026

View reviewed changes

JS00001 merged commit f5bdf41 into Expensify:main Apr 13, 2026
32 checks passed

OSBotify mentioned this pull request Apr 13, 2026

Deploy Checklist: New Expensify 2026-04-13 #87792

Closed

89 tasks

Uh oh!

Conversation

BartekObudzinski commented Apr 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Apr 10, 2026

Uh oh!

BartekObudzinski commented Apr 10, 2026

Uh oh!

ZhenjaHorbach Apr 10, 2026

Choose a reason for hiding this comment

Uh oh!

BartekObudzinski Apr 13, 2026

Choose a reason for hiding this comment

Uh oh!

ZhenjaHorbach Apr 10, 2026

Choose a reason for hiding this comment

Uh oh!

BartekObudzinski Apr 13, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

ZhenjaHorbach commented Apr 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

ZhenjaHorbach commented Apr 13, 2026

Uh oh!

trjExpensify commented Apr 13, 2026

Uh oh!

Uh oh!

github-actions Bot commented Apr 13, 2026

Uh oh!

github-actions Bot commented Apr 13, 2026

Uh oh!

OSBotify commented Apr 13, 2026

Uh oh!

OSBotify commented Apr 13, 2026

Uh oh!

MelvinBot commented Apr 13, 2026

Uh oh!

OSBotify commented Apr 16, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

BartekObudzinski commented Apr 10, 2026 •

edited

Loading

ZhenjaHorbach commented Apr 13, 2026 •

edited

Loading