Fix The emoji bar is overlapped by the notch on landscape#87485
Conversation
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
JmillsExpensify
left a comment
There was a problem hiding this comment.
No product review required on this one.
on it |
|
|
|
@truph01 the PR we were waiting for was merged so I merged main here
|
|
@GCyganek Could you revert patch commit since we already have it in main? |
Oh, yeah, sure, I pushed it by mistake |
b44a41b to
be44259
Compare
f3d02ab to
a586eae
Compare
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppScreen.Recording.2026-04-16.at.06.07.28.movAndroid: mWeb ChromeiOS: HybridAppScreen.Recording.2026-04-15.at.16.54.55.moviOS: mWeb SafariMacOS: Chrome / Safari |
|
@truph01 did you make sure to rebuild the android with the new patch? Was it working before for you? I just checked and everything is working fine on Pixel 8 simulator and my physical Pixel 8
|
I just tested again, and it works well. Not sure why it doesn't work in my 1st attempt, it looks like a cache issue. |
|
🚧 @mjasikowski has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/mjasikowski in version: 9.3.61-0 🚀
Bundle Size Analysis (Sentry): |
|
No help site changes are needed for this PR. The change is a purely technical UI fix (adjusting the native EmojiPickerMenu width to account for safe area insets in landscape mode). It does not affect any user-facing features, workflows, settings, or terminology documented on the help site. |
|
🚀 Deployed to production by https://github.com/marcaaron in version: 9.3.61-4 🚀
|




Explanation of Change
Fixing EmojiPickerMenu width by taking into consideration safe area padding
Fixed Issues
$ #87316
PROPOSAL: N/A
Tests
Offline tests
N/A
QA Steps
Same as Tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
iOS: Native
Screen.Recording.2026-04-09.at.13.25.00.mov