Skip to content

[No QA] Fix iOS bundle command #87464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
roryabraham merged 2 commits into from
Apr 11, 2026
Merged

[No QA] Fix iOS bundle command #87464

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b1493b2
Fix bundle command
j-piasecki Apr 9, 2026
9489927
Use eval
j-piasecki Apr 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ios/bundle-react-native-code-and-images.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,4 +29,4 @@ if [[ -z "$BUNDLE_COMMAND" ]]; then
export BUNDLE_COMMAND="bundle"
fi

"$NODE_BINARY" --print "require('path').dirname(require.resolve('react-native/package.json')) + '/scripts/react-native-xcode.sh'"
eval "$("$NODE_BINARY" --print "require('path').dirname(require.resolve('react-native/package.json')) + '/scripts/react-native-xcode.sh'")"

@chatgpt-codex-connector chatgpt-codex-connector Bot Apr 9, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Run resolved React Native script without eval

Using eval here re-parses the resolved script path as shell code, so paths containing spaces or shell metacharacters (for example, a checkout under /Users/.../Work Projects/...) can fail to execute or be interpreted unexpectedly. This makes iOS bundling brittle on valid local environments; execute the resolved path directly instead of passing it through eval.

Useful? React with 👍 / 👎.

Loading