refactor: PureReportActionItem, add ApprovalFlowContent#87462
Conversation
e7b84f1 to
a157e87
Compare
|
@ikevin127 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
a157e87 to
d6e1400
Compare
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
|
@codex review |
|
Codex Review: Didn't find any major issues. Keep them coming! ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
Reviewer Checklist
Screenshots/VideosScreen.Recording.2026-04-13.at.17.35.48.mov |
ikevin127
left a comment
There was a problem hiding this comment.
✅ LGTM
The refactoring successfully achieves phase 2 goals. Component complexity is reduced, test coverage is adequate, and all functionality is preserved.
- Risk Level: Low 🟢 - refactoring with comprehensive test coverage
- Regression Risk: Minimal 🟢 - tested action types are standard approval flows
- Merge Readiness: Ready 🟢
…to perf-send-message-phase-2-3
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/cristipaval in version: 9.3.60-0 🚀
Bundle Size Analysis (Sentry): |
|
No help site changes are required for this PR. This is a pure internal code refactoring — it extracts existing approval flow rendering logic (submit, approve, forward actions) from |
|
🚀 Deployed to production by https://github.com/mountiny in version: 9.3.60-22 🚀
|
Explanation of Change
Part of phase 2 of splitting the PureReportActionItem component.
Unit tests: #87347
Fixed Issues
$ #87886
PROPOSAL:
Tests
Few smoke tests:
Test 1: Submit an Expense
Test 2: Automatic Approve via Workspace Rules
Offline tests
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
Screen.Recording.2026-04-09.at.09.38.29.mov
iOS: mWeb Safari
MacOS: Chrome / Safari
Screen.Recording.2026-04-09.at.09.53.46.mov