refactor: PureReportActionItem, add PaymentContent#87399
Conversation
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
7c95e6c to
10a8a9d
Compare
|
@ZhenjaHorbach Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Reviewer Checklist
Screenshots/VideosAndroid: HybridApp324.movAndroid: mWeb Chrome123.moviOS: HybridApp324.moviOS: mWeb Safari123.movMacOS: Chrome / Safari2026-04-14.09.43.36.mov |
|
LGTM! |
…to perf-send-message-phase-2-2
|
@LukasMod, could you please resolve conflicts here? 🙏 |
…to perf-send-message-phase-2-2
|
@cristipaval conflicts resolved |
|
🚧 @cristipaval has triggered a test Expensify/App build. You can view the workflow run here. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/cristipaval in version: 9.3.60-0 🚀
Bundle Size Analysis (Sentry): |
|
This PR is a pure internal refactor — it extracts payment rendering logic from No help site updates are required. |
|
🚀 Deployed to production by https://github.com/mountiny in version: 9.3.60-22 🚀
|
Explanation of Change
Part of phase 2 of splitting the PureReportActionItem component.
Unit tests: #87347
Fixed Issues
$ #87885
PROPOSAL:
Tests
Few smoke tests:
Test 1: Test Pay message
Test 2: Regular workspace expenses
Offline tests
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
Screen.Recording.2026-04-08.at.17.36.11.mov
iOS: mWeb Safari
MacOS: Chrome / Safari
Screen.Recording.2026-04-08.at.17.37.33.mov