perf: Optimize getTransactionsSections and getReportSections by jmusial · Pull Request #87363 · Expensify/App

jmusial · 2026-04-08T11:30:16Z

Explanation of Change

This PR optimizesgetReportSections and getTransactionsSections by replacing 7 iterations over dataset with a single pass that produces every derived structure at once. In addition a new computeViolationFlags() merges the two violation checks into one loop with early exit.

Performance gains

Timing function execution

Function	Previous Avg (ms)	Current Avg (ms)	Δ (ms)	Improvement
getReportSections	~10.9	~8.55	-2.35	~21.6%
getTransactionsSections	~0.96	~0.75	-0.21	~21.9%

Span times for Home -> Reports nav and got this:

Main (11 samples): 1212 + 2273 + 1984 + 1302 + 1185 + 1224 + 1371 + 1329 + 1317 + 1244 + 1941 = 16382
Avg: 16382 / 11 = 1489.3 ms

Branch (11 samples): 1169 + 1189 + 1440 + 1246 + 1223 + 2388 + 1229 + 1941 + 1210 + 1200 + 1155 = 15390
Avg: 15390 / 11 = 1399.1 ms

Avg duration
Main 1489.3 ms
Branch 1399.1 ms
Difference -90.2 ms (~6% faster)

Fixed Issues

$ #87521
PROPOSAL: on Slack

Tests

This is a refactor, it should not alter anything apart from boosting perf.

Open app
Navigate to Reports
Verify that data shown is the same as on prod

Offline tests

Same as tests

QA Steps

Same as tests

PR Author Checklist

Screenshots/Videos

MacOS: Chrome / Safari

Screen.Recording.2026-04-10.at.13.36.17.mov

codecov · 2026-04-08T11:38:44Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/libs/SearchUIUtils.ts	`65.93% <79.69%> (-0.40%)`	⬇️
... and 11 files with indirect coverage changes

jmusial · 2026-04-10T11:15:04Z

@codex review

chatgpt-codex-connector · 2026-04-10T11:25:07Z

Codex Review: Didn't find any major issues. What shall we delve into next?

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

melvin-bot · 2026-04-10T11:39:35Z

@dmkt9 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

JmillsExpensify

No product review required.

mountiny · 2026-04-11T01:04:31Z

@dmkt9 can you prioritize this review please?

@jmusial there are conflicts now

dmkt9 · 2026-04-11T03:13:21Z

+    // Optimistic: works when report-action keys precede transaction keys (common case).
+    // resolveExportedYearFlags() re-checks after the export map is fully built.
+    if (!ctx.shouldShowYearExported) {
+        const exportedAction = transaction.reportID ? ctx.lastExportedActionByReportID.get(transaction.reportID) : undefined;
+        if (exportedAction?.created && DateUtils.doesDateBelongToAPastYear(exportedAction.created)) {
+            ctx.shouldShowYearExported = true;
+        }
+    }


NAB:

We might not need to call resolveExportedYearFlags to re-check via backward checking:

Idea

When encountering a reportActionEntry: still build lastExportedActionByReportID

When encountering a reportEntry

add the reportID to seenReportIDs

if lastExportedActionByReportID already contains this reportID and passes validation, then set:

shouldShowYearExported = true

shouldShowYearExportedReport = true

When encountering a transactionEntry

add transaction.reportID to seenTransactionReportIDs

if lastExportedActionByReportID already contains transaction.reportID and passes validation, then set:

shouldShowYearExported = true

Conversely, if a reportActionEntry comes after a reportEntry / transactionEntry

perform a backward check:

if seenReportIDs.has(reportID), then set both flags

if seenTransactionReportIDs.has(reportID), then set shouldShowYearExported

This approach could eliminate the need to loop through reportKeys and transactionKeys, but it would require an additional O(k) memory overhead, so I’m leaving it as a proposal for now.

dmkt9 · 2026-04-11T04:01:27Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

android.hybrid.mp4

Android: mWeb Chrome

android.chrome.mp4

iOS: HybridApp

ios.hybrid.mp4

iOS: mWeb Safari

ios.safari.mp4

MacOS: Chrome / Safari

mac.safari.mp4

github-actions · 2026-04-13T15:05:45Z

🚧 @luacmartins has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-04-13T15:10:30Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #87363.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-54ded1a-08ff3fc-04451a178139ff3470d2e24b3c6115cdb2a6aebe/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-54ded1a-08ff3fc-7d1a95eb7751d7cae4988e2d4baeac7a1bbd45f3/index.html

Web 🕸️
https://87363.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-04-13T15:15:07Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2026-04-13T20:33:29Z

🚀 Deployed to staging by https://github.com/luacmartins in version: 9.3.59-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	cancelled 🔪
🍎 iOS 🍎	cancelled 🔪

Bundle Size Analysis (Sentry):

Android

MelvinBot · 2026-04-13T20:34:41Z

This PR is a pure performance refactor of internal search utility functions (getReportSections and getTransactionsSections) — no user-facing behavior, terminology, or workflow changes.

No help site changes are required.

OSBotify · 2026-04-16T03:30:08Z

🚀 Deployed to production by https://github.com/AndrewGable in version: 9.3.59-4 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

initial refactor

5888ac6

melvin-bot Bot assigned jmusial Apr 8, 2026

jmusial added 6 commits April 9, 2026 17:42

Merge branch 'main' into perf/refactor-get-report-sections

f1a4417

Merge branch 'main' into perf/refactor-get-report-sections

c377550

add tests

6c5c9d3

refactror to be more readable

3e99ff8

remove redundant type

921f71b

fix AI review findings

89b5534

jmusial marked this pull request as ready for review April 10, 2026 11:39

jmusial requested review from a team as code owners April 10, 2026 11:39

melvin-bot Bot requested review from JmillsExpensify and dmkt9 and removed request for a team April 10, 2026 11:39

melvin-bot Bot removed the request for review from a team April 10, 2026 11:39

jmusial mentioned this pull request Apr 10, 2026

[Due for payment 2026-04-23] [$250] Optimize getTransactionsSections and getReportSections #87521

Closed

JmillsExpensify reviewed Apr 10, 2026

View reviewed changes

dmkt9 reviewed Apr 11, 2026

View reviewed changes

dmkt9 approved these changes Apr 11, 2026

View reviewed changes

melvin-bot Bot requested a review from luacmartins April 11, 2026 04:04

Merge branch 'main' into perf/refactor-get-report-sections

4d15757

luacmartins approved these changes Apr 13, 2026

View reviewed changes

luacmartins merged commit 54ded1a into Expensify:main Apr 13, 2026
31 checks passed

OSBotify mentioned this pull request Apr 13, 2026

Deploy Checklist: New Expensify 2026-04-13 #87792

Closed

89 tasks

MelvinBot mentioned this pull request Apr 14, 2026

Steph's chat with Melvin #87829

Closed

Uh oh!

Conversation

jmusial commented Apr 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Performance gains

Timing function execution

Span times for Home -> Reports nav and got this:

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov Bot commented Apr 8, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

jmusial commented Apr 10, 2026

Uh oh!

chatgpt-codex-connector Bot commented Apr 10, 2026

Uh oh!

melvin-bot Bot commented Apr 10, 2026

Uh oh!

JmillsExpensify left a comment

Choose a reason for hiding this comment

Uh oh!

mountiny commented Apr 11, 2026

Uh oh!

dmkt9 Apr 11, 2026

Choose a reason for hiding this comment

Uh oh!

dmkt9 commented Apr 11, 2026

Reviewer Checklist

Screenshots/Videos

Uh oh!

Uh oh!

github-actions Bot commented Apr 13, 2026

Uh oh!

github-actions Bot commented Apr 13, 2026

Uh oh!

OSBotify commented Apr 13, 2026

Uh oh!

OSBotify commented Apr 13, 2026

Uh oh!

MelvinBot commented Apr 13, 2026

Uh oh!

OSBotify commented Apr 16, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

jmusial commented Apr 8, 2026 •

edited

Loading

codecov Bot commented Apr 8, 2026 •

edited by github-actions Bot

Loading