Fix Different typing mode when rotating device from portrait to landscape#87338
Conversation
|
Hey! I see that you made changes to our Form component. Make sure to update the docs in FORMS.md accordingly. Cheers! |
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
|
@GCyganek, are you able to reproduce this issue (latest main) in the Android simulator? I can't. When switching from portrait to landscape, the keyboard is automatically closed: Screen.Recording.2026-04-08.at.16.58.32.mov |
Yeah I had the same problem, sometimes the input loses focus in the first orientation change and on the second orientation change the keyboard is hidden. Maybe it differs across devices, because the person that reported this has focused input all the time when the orientation changes 2 times, still, this PR fixes the problem where rotating from portrait to landscape with focused input triggers fullscreen keyboard UI which is what was reported |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppoutput.mp4Android: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / Safari |
|
@mjasikowski All yours! |
|
🚧 @mjasikowski has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/mjasikowski in version: 9.3.59-0 🚀
Bundle Size Analysis (Sentry): |
|
No help site changes are required for this PR. The change sets |
|
Deploy Blocker #87807 was identified to be related to this PR. |
|
🚀 Deployed to production by https://github.com/AndrewGable in version: 9.3.59-4 🚀
|
Explanation of Change
setting
disableFullscreenUIprop totruealways, not only in landscape mode, as it breaks when user has focused input in portrait mode and then rotates to landscape mode, as fullscreen ui is shown in landscape mode which shouldn't happenFixed Issues
$ #87310
PROPOSAL: N/A
Tests
Offline tests
N/A
QA Steps
Same as Tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen.Recording.2026-04-08.at.09.41.00.mov