Skip to content

[No QA] [Payment due @ZhenjaHorbach] Update Discover section help docs to explain visibility behavior#87251

Closed
MelvinBot wants to merge 1 commit into
mainfrom
melvin-update-discover-section-docs
Closed

[No QA] [Payment due @ZhenjaHorbach] Update Discover section help docs to explain visibility behavior#87251
MelvinBot wants to merge 1 commit into
mainfrom
melvin-update-discover-section-docs

Conversation

@MelvinBot

Copy link
Copy Markdown
Contributor

Explanation of Change

Updates the Expensify Home Overview help article to document that the Discover section on Home disappears after the user watches the demo. Also adds a FAQ entry ("Why don't I see the Discover section?") for consistency with other conditional Home sections (Time-sensitive, Spend over time, Assigned cards) that already have such FAQ entries.

Fixed Issues

$ #87224

Tests

  1. Review the changes in docs/articles/new-expensify/getting-started/Expensify-Home-Overview.md
  2. Verify the new paragraph under the Discover section accurately describes the behavior
  3. Verify the new FAQ entry is consistent with existing FAQ entries for other conditional sections
  • Verify that no errors appear in the JS console

Offline tests

N/A (docs-only change)

QA Steps

N/A (docs-only change)

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

N/A (docs-only change)

Co-authored-by: ZhenjaHorbach 68128028+ZhenjaHorbach@users.noreply.github.com

Add documentation that the Discover section disappears after the user watches the demo, and add a corresponding FAQ entry for consistency with other conditional Home sections.

Co-authored-by: Yauheni Horbach <ZhenjaHorbach@users.noreply.github.com>
@melvin-bot melvin-bot Bot changed the title Update Discover section help docs to explain visibility behavior [Payment due @ZhenjaHorbach] Update Discover section help docs to explain visibility behavior Apr 7, 2026
@melvin-bot

melvin-bot Bot commented Apr 7, 2026

Copy link
Copy Markdown

🎯 @ZhenjaHorbach, thanks for reviewing and testing this PR! 🎉

A payment issue will be created for your review once this PR is deployed to production.
E/E issue linked to the PR - no internal issue.

If payment is not needed (e.g., regression PR review fix etc), react with 👎 to this comment to prevent the payment issue from being created.


This section includes a short demo that introduces key areas of the app and shows how different parts fit together. This can be helpful when you’re getting started or returning after some time away.

Once you watch the demo, the Discover section is automatically removed from Home.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Naming and style: "Discover" refers to a UI section and should be bolded as Discover to match the formatting used throughout the rest of this article (e.g., lines 84, 37, 136). Per HELPSITE_NAMING_CONVENTIONS.md, section names must use exact UI text with bold formatting.

Suggested change
Once you watch the demo, the Discover section is automatically removed from Home.
Once you watch the demo, the **Discover** section is automatically removed from Home.

@github-actions

github-actions Bot commented Apr 7, 2026

Copy link
Copy Markdown
Contributor

HelpDot Documentation Review

Overall Assessment

This PR adds two small pieces of content to the Expensify Home Overview article: (1) a clarifying sentence in the Discover section explaining that it disappears after watching the demo, and (2) a new FAQ entry addressing why the Discover section might not be visible. Both additions are well-written, concise, and consistent with the existing article's tone and structure.

Scores Summary

  • Readability: 9/10 - The new content is clear, concise, and scannable. The FAQ answer is direct and informative. Minor note: the inline addition and the FAQ answer are slightly redundant with each other, but this is a reasonable pattern given the FAQ format (users may jump directly to the FAQ).
  • AI Readiness: 9/10 - The new FAQ heading "Why don't I see the Discover section?" follows the question-word pattern required by the authoring guidelines, uses the exact feature name, and matches the established pattern of other FAQ entries in this article. The YAML metadata already includes "Discover" in keywords, which supports retrieval.
  • Style Compliance: 10/10 - Bold formatting on Discover is used correctly and consistently. The language is precise and matches existing UI terminology. No prohibited language patterns are present.

Key Findings

  • The new FAQ heading correctly starts with a question word ("Why"), satisfying the task-based heading requirement.
  • Bold formatting on section names (Discover) follows the naming conventions for UI element references.
  • The placement of the new FAQ entry is logically ordered -- it appears after "Spend over time" and before "Assigned cards", which mirrors the order of the content sections in the article body.
  • The inline addition ("Once you watch the demo, the Discover section is automatically removed from Home.") and the FAQ answer convey overlapping information. This is acceptable since FAQ sections serve readers who skip directly to them, but the wording could be slightly varied to add value in the FAQ (e.g., mentioning that it cannot be restored).

Recommendations

  • Consider whether the FAQ answer should mention if there is any way to re-trigger the Discover section (e.g., "There is no way to bring it back" or "Contact support to reset it"), as users asking "Why don't I see it?" may want to know if they can get it back. This would make the FAQ answer more complete.
  • No structural or compliance issues need to be addressed. This PR is ready to merge from a documentation standards perspective.

Files Reviewed

  • docs/articles/new-expensify/getting-started/Expensify-Home-Overview.md - Two additions: one inline clarification in the Discover section, one new FAQ entry. Both comply with governance standards.

@github-actions github-actions Bot changed the title [Payment due @ZhenjaHorbach] Update Discover section help docs to explain visibility behavior [No QA] [Payment due @ZhenjaHorbach] Update Discover section help docs to explain visibility behavior Apr 7, 2026
@OSBotify

OSBotify commented Apr 7, 2026

Copy link
Copy Markdown
Contributor

A preview of your ExpensifyHelp changes have been deployed to https://72af698c.helpdot.pages.dev ⚡️

Updated articles:

@stephanieelliott

Copy link
Copy Markdown
Contributor

Looking at this change I think it is not necessary to document

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants