Migrate Workspace - NetSuite Advanced + Sage #87226
Conversation
|
@mananjadhav Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
…pace-netsuite-advanced-sage
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
…pace-netsuite-advanced-sage
…pace-netsuite-advanced-sage
…pace-netsuite-advanced-sage
…pace-netsuite-advanced-sage
…pace-netsuite-advanced-sage
…pace-netsuite-advanced-sage
…pace-netsuite-advanced-sage
…pace-netsuite-advanced-sage
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppandroid-bt-netsuite-and-sage.movAndroid: mWeb Chromemweb-chrome-bt-netsuite-and-sage.moviOS: HybridAppios-bt-netsuite-and-sage.moviOS: mWeb Safarimweb-safari-bt-sage-prereq.movmweb-safari-bt-net-suite-adv.movMacOS: Chrome / Safariweb-bt-sage-prereq.movweb-bt-net-suite-adv.mov |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚧 @mjasikowski has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/mjasikowski in version: 9.3.61-0 🚀
Bundle Size Analysis (Sentry): |
|
I reviewed the changes in this PR. This is a purely internal navigation refactoring that migrates three workspace accounting pages (NetSuite Auto Sync, NetSuite Accounting Method, and Sage Intacct Prerequisites) from static routes to dynamic routes. No user-facing features, UI labels, settings, or behaviors are changed — the screens render identically. Only the internal navigation plumbing was updated ( No help site changes are required. |
|
Hi @huult Could you please share link for staging, step 5? Thanks
|
|
@huult Also, this part only for Web, right? iOS & Android app crashes after following this link from Expensify.
Screenrecording.04-22-2026.7-43-50.Am.1.mp4
|
|
@izarutskaya I've updated the test steps. Sorry for the confusion. |
|
🚀 Deployed to production by https://github.com/marcaaron in version: 9.3.61-4 🚀
|

Explanation of Change
Fixed Issues
$ #83866
PROPOSAL:
Tests
Same QA step
Offline tests
QA Steps
WORKSPACE_ACCOUNTING_NETSUITE_AUTO_SYNC
Precondition: The workspace is connected to a NetSuite account.
WORKSPACE_ACCOUNTING_NETSUITE_ACCOUNTING_METHOD
Precondition: The workspace is connected to a NetSuite account.
POLICY_ACCOUNTING_SAGE_INTACCT_PREREQUISITES
Precondition: The workspace is not connected to any accounting account.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Screen.Recording.2026-04-07.at.14.39.29.mov