Skip to content

[No QA] Update help site: Discover section hidden after tour#87191

Merged
stephanieelliott merged 1 commit into
mainfrom
claude-hideDiscoverAfterTour
Apr 16, 2026
Merged

[No QA] Update help site: Discover section hidden after tour#87191
stephanieelliott merged 1 commit into
mainfrom
claude-hideDiscoverAfterTour

Conversation

@MelvinBot

Copy link
Copy Markdown
Contributor

Explanation of Change

Updates the Expensify Home Overview help site article to reflect the behavior change from #86726, where the Discover section on Home is now hidden once the user has watched the tour demo.

Changes:

  • Marked the Discover section as "(when applicable)" in the Home sections list
  • Added a note explaining the section is hidden after watching the demo
  • Added an FAQ entry: "Why don't I see the Discover section?"

Fixed Issues

$ #86445

Tests

  • Verify that no errors appear in the JS console
  1. Open the help site article at docs/articles/new-expensify/getting-started/Expensify-Home-Overview.md
  2. Verify the Discover bullet in the "What Home shows" list says "(when applicable)"
  3. Verify the Discover section explanation includes a sentence about it being hidden after watching the demo
  4. Verify a new FAQ entry "Why don't I see the Discover section?" exists

Offline tests

N/A — documentation-only change.

QA Steps

  1. Open the help site article at docs/articles/new-expensify/getting-started/Expensify-Home-Overview.md
  2. Verify the Discover bullet in the "What Home shows" list says "(when applicable)"
  3. Verify the Discover section explanation includes a sentence about it being hidden after watching the demo
  4. Verify a new FAQ entry "Why don't I see the Discover section?" exists

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

N/A — documentation-only change.

Android: mWeb Chrome

N/A — documentation-only change.

iOS: Native

N/A — documentation-only change.

iOS: mWeb Safari

N/A — documentation-only change.

MacOS: Chrome / Safari

N/A — documentation-only change.

Reflects the change from PR #86726 where the Discover section on Home
is now hidden once the user has watched the tour demo.

Co-authored-by: Georgia Monahan <grgia@users.noreply.github.com>
@MelvinBot MelvinBot requested a review from a team April 7, 2026 01:29
@MelvinBot MelvinBot mentioned this pull request Apr 7, 2026
52 tasks
@github-actions github-actions Bot changed the title Update help site: Discover section hidden after tour [No QA] Update help site: Discover section hidden after tour Apr 7, 2026
@OSBotify

OSBotify commented Apr 7, 2026

Copy link
Copy Markdown
Contributor

A preview of your ExpensifyHelp changes have been deployed to https://a51bfdd5.helpdot.pages.dev ⚡️

Updated articles:

@grgia grgia marked this pull request as ready for review April 15, 2026 13:46
@grgia grgia requested a review from stephanieelliott as a code owner April 15, 2026 13:46
@melvin-bot

melvin-bot Bot commented Apr 15, 2026

Copy link
Copy Markdown

Concierge reviewer checklist:

  • I have verified the accuracy of the article
    • The article is within a hub that makes sense, and the navigation is correct
    • All processes, screenshots, and examples align with current product behavior.
    • All links within the doc have been verified for correct destination and functionality.
  • I have verified the readability of the article
    • The article's language is clear, concise, and free of jargon.
    • The grammar, spelling, and punctuation are correct.
    • The article contains at least one image, or that an image is not necessary
  • I have verified the formatting of the article
    • The article has consistent formatting (headings, bullet points, etc.) with other HelpDot articles and that aligns with the HelpDot formatting standards.
    • The article has proper text spacing and breaks for readability.
  • I have verified the article has the appropriate tone and style
    • The article's tone is professional, friendly, and suitable for the target audience.
    • The article's tone, terminology, and voice are consistent throughout.
  • I have verified the overall quality of the article
    • The article is not missing any information, nor does it contain redundant information.
    • The article fully addresses user needs.
  • I have verified that all requested improvements have been addressed

For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member?

cc @NicMendonca

@melvin-bot melvin-bot Bot requested review from NicMendonca and removed request for a team April 15, 2026 13:46
@melvin-bot

melvin-bot Bot commented Apr 15, 2026

Copy link
Copy Markdown

@NicMendonca Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@github-actions

Copy link
Copy Markdown
Contributor

HelpDot Documentation Review

Overall Assessment

This PR makes a small, focused documentation update to the Expensify Home Overview article, reflecting a product behavior change where the Discover section is hidden after a user watches the tour demo. The changes are minimal (7 additions, 1 deletion) and limited to one file. The edits are clear, consistent with the existing article style, and correctly placed.

Scores Summary

  • Readability: 9/10 - The added content is concise, scannable, and follows the same sentence patterns used elsewhere in the article. The new FAQ entry provides a direct answer without unnecessary phrasing.
  • AI Readiness: 9/10 - The new FAQ heading ("Why don't I see the Discover section?") is question-based and searchable, consistent with the governance requirement that headings start with an action verb or question word. The heading includes the feature name ("Discover section"), aiding semantic retrieval.
  • Style Compliance: 9/10 - UI element names (Discover, Home) are correctly bolded. The new content mirrors the established patterns of adjacent FAQ entries (e.g., "Why don't I see the Spend over time section?", "Why don't I see the Assigned cards section?"). Terminology is consistent with the rest of the article.

Key Findings

  • The "(when applicable)" qualifier added to the Discover bullet is consistent with how other conditional sections (Time-sensitive alerts, Spend over time, Assigned cards) are already annotated in the same list.
  • The new FAQ entry follows the exact same structure as the surrounding FAQ entries, maintaining consistency.
  • The explanatory sentence added after the Discover section description ("Once you've watched the demo, the Discover section is automatically hidden from Home.") is well-placed and clearly explains the behavior change.
  • No governance violations were found in the proposed changes.

Recommendations

  • No blocking issues. The changes are ready to merge from a documentation quality perspective.
  • Minor consideration: The FAQ answer says "only appears until you've watched the demo," while the inline note says "Once you've watched the demo, the Discover section is automatically hidden." Both convey the same meaning, but using identical phrasing in both locations would be slightly more consistent. This is optional.

Files Reviewed

  • docs/articles/new-expensify/getting-started/Expensify-Home-Overview.md - Clean update; all changes comply with governance standards.

Comment on lines +134 to +136
## Why don’t I see the Discover section?

The **Discover** section only appears until you’ve watched the demo. Once you’ve completed it, the section is automatically hidden from Home.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Readability / structure: This FAQ answer repeats the sentence added in the Discover section above (line 89) almost verbatim. Per the authoring guidelines, each section should add value rather than restate content from elsewhere in the same article. Consider differentiating the FAQ answer — for example, by briefly noting where the demo appears or what triggers it — so the FAQ adds information beyond what the body section already says.

@stephanieelliott stephanieelliott merged commit 0fae9fd into main Apr 16, 2026
23 checks passed
@stephanieelliott stephanieelliott deleted the claude-hideDiscoverAfterTour branch April 16, 2026 06:35
@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/stephanieelliott in version: 9.3.61-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/marcaaron in version: 9.3.61-4 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants