Skip to content

Navigate back to taxes list when tax detail RHN can't find tax #87175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stitesExpensify merged 8 commits into from
Apr 20, 2026
Merged

Navigate back to taxes list when tax detail RHN can't find tax #87175

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
31c972a
Navigate back to taxes list when tax not found in RHN
allgandalf Apr 6, 2026
d4d5c87
Merge branch 'Expensify:main' into fix-tax-detail-rhn-fallback-redirect
allgandalf Apr 7, 2026
3c17012
Merge branch 'Expensify:main' into fix-tax-detail-rhn-fallback-redirect
allgandalf Apr 9, 2026
78ea972
Merge branch 'Expensify:main' into fix-tax-detail-rhn-fallback-redirect
allgandalf Apr 10, 2026
0983ac3
Merge branch 'Expensify:main' into fix-tax-detail-rhn-fallback-redirect
allgandalf Apr 14, 2026
356c7da
Return null instead of NotFoundPage when tax is missing but taxes are…
allgandalf Apr 14, 2026
0d70ac4
Merge branch 'Expensify:main' into fix-tax-detail-rhn-fallback-redirect
allgandalf Apr 15, 2026
17b583e
Merge branch 'Expensify:main' into fix-tax-detail-rhn-fallback-redirect
allgandalf Apr 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions src/pages/workspace/taxes/WorkspaceEditTaxPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,13 @@ function WorkspaceEditTaxPage({
Navigation.setParams({taxID: currentTaxID});
}, [taxID, currentTaxID]);

useEffect(() => {
if (currentTaxRate || !policy?.taxRates?.taxes) {
return;
}
Navigation.goBack(ROUTES.WORKSPACE_TAXES.getRoute(policyID));
}, [currentTaxRate, policy?.taxRates?.taxes, policyID]);

const deleteTaxRate = () => {
if (!policyID) {
return;
Expand All @@ -67,6 +74,9 @@ function WorkspaceEditTaxPage({
};

if (!currentTaxRate) {
if (policy?.taxRates?.taxes) {
return null;
}
return <NotFoundPage />;
}
const taxCodeToShow = isControlPolicy(policy) ? taxID : '';
Expand Down
Loading