Skip to content

BT - Migrate NET SUITE Part 1#87172

Merged
mjasikowski merged 16 commits into
Expensify:mainfrom
mananjadhav:mj-83843-bt-net-suite-1
Apr 17, 2026
Merged

BT - Migrate NET SUITE Part 1#87172
mjasikowski merged 16 commits into
Expensify:mainfrom
mananjadhav:mj-83843-bt-net-suite-1

Conversation

@mananjadhav

@mananjadhav mananjadhav commented Apr 6, 2026

Copy link
Copy Markdown
Collaborator

Explanation of Change

Fixed Issues

$ #83843
PROPOSAL:

Tests

Same as QA tests.

  • Verify that no errors appear in the JS console

Offline tests

Same as QA steps

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

Precondition

  • A workspace is connected to NetSuite.
  • You are a workspace admin (or have access to Accounting export settings).
  • For each test, remove the backTo param and

Case 1: Preferred exporter (dynamic route + back path)

  1. Open Expensify.
  2. Navigate to the NetSuite-connected workspace.
  3. Go to AccountingExport.
  4. Open Preferred exporter.
  5. Verify the Preferred exporter selection screen opens.
  6. Press Back.
  7. Verify you return to Accounting → Export (NetSuite export configuration).

Case 2: Export date (dynamic route + back path)

  1. Open Expensify.
  2. Navigate to the NetSuite-connected workspace.
  3. Go to AccountingExport.
  4. Open Export date.
  5. Verify the Export date selection screen opens.
  6. Press Back.
  7. Verify you return to Accounting → Export.

Case 3: Export out-of-pocket → default vendor (dynamic route + back path)

  1. Open Expensify.
  2. Go to the NetSuite-connected workspace.
  3. Navigate to Accounting → Export → Export out-of-pocket.
  4. Open Default vendor (if that row is visible for your configuration).
  5. Confirm the vendor selection screen opens.
  6. Press Back.
  7. Confirm you return to Export out-of-pocket (not the main Accounting → Export hub).

Case 4: Export out-of-pocket → payable account (dynamic route + back path)

  1. Open Expensify.
  2. Go to the NetSuite-connected workspace.
  3. Navigate to Accounting → Export → Export out-of-pocket.
  4. Open Non-reimbursable journal posting account or Reimbursable journal posting account, whichever is shown.
  5. Confirm the payable account selection screen opens.
  6. Press Back.
  7. Confirm you return to Export out-of-pocket.

Case 5: Export company card — same dynamic sub-flows as Cases 4–6

  1. Open Expensify.
  2. Go to the NetSuite-connected workspace.
  3. Navigate to Accounting → Export → Export company card.
  4. For each visible row (Default vendor, payable account rows, Journal posting preference), open the screen, then press Back.
  5. Confirm Back always returns to Export company card (not skipping to Accounting → Export unless product behavior explicitly does so).
  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
android-bt-net-suite.mov
Android: mWeb Chrome
mweb-chrome-bt-net-suite.mov
iOS: Native
ios-bt-net-suite.mov
iOS: mWeb Safari
mweb-safari-bt-net-suite-1.mov
MacOS: Chrome / Safari
web-bt-net-suite-1.mov
web-bt-net-suite-export-expense-type.mov

@codecov

codecov Bot commented Apr 6, 2026

Copy link
Copy Markdown

@mananjadhav mananjadhav force-pushed the mj-83843-bt-net-suite-1 branch from c856f79 to 7b01cbb Compare April 7, 2026 14:07
@mananjadhav mananjadhav marked this pull request as ready for review April 7, 2026 16:35
@mananjadhav mananjadhav requested review from a team as code owners April 7, 2026 16:35
@melvin-bot melvin-bot Bot requested review from huult and removed request for a team April 7, 2026 16:35
@melvin-bot

melvin-bot Bot commented Apr 7, 2026

Copy link
Copy Markdown

@huult Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot Bot requested review from joekaufmanexpensify and removed request for a team April 7, 2026 16:35

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 27739cb787

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@joekaufmanexpensify joekaufmanexpensify left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good for product

Comment thread src/ROUTES.ts Outdated
@huult

huult commented Apr 10, 2026

Copy link
Copy Markdown
Contributor

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
Screen.Recording.2026-04-16.at.15.58.32.mp4
Android: mWeb Chrome
Screen.Recording.2026-04-16.at.16.00.13.mp4
iOS: HybridApp
Screen.Recording.2026-04-16.at.16.02.54.mp4
iOS: mWeb Safari
Screen.Recording.2026-04-16.at.16.03.35.mp4
MacOS: Chrome / Safari
Screen.Recording.2026-04-16.at.15.55.36.mp4

Comment thread src/libs/Navigation/AppNavigator/ModalStackNavigators/index.tsx
@huult

huult commented Apr 10, 2026

Copy link
Copy Markdown
Contributor
POLICY_ACCOUNTING_NETSUITE_EXPORT
POLICY_ACCOUNTING_NETSUITE_EXPORT_EXPENSES
POLICY_ACCOUNTING_NETSUITE_EXPORT_EXPENSES_DESTINATION_SELECT

@mananjadhav I reviewed the 3 route paths above, and I think we can migrate all 3 in this PR. Could you help migrate them here as well? If there are any questions or reasons why some routes can't be migrated in this PR, please let me know.

@mananjadhav

Copy link
Copy Markdown
Collaborator Author

Yes with the path params support I've now migrated all the routes.

Comment thread src/libs/Navigation/AppNavigator/ModalStackNavigators/index.tsx Outdated
Comment thread src/libs/Navigation/AppNavigator/ModalStackNavigators/index.tsx Outdated
Comment thread src/libs/Navigation/types.ts Outdated
Comment thread src/libs/Navigation/types.ts Outdated
onPress: !policyID
? undefined
: () => Navigation.navigate(ROUTES.POLICY_ACCOUNTING_NETSUITE_EXPORT_EXPENSES.getRoute(policyID, CONST.NETSUITE_EXPENSE_TYPE.REIMBURSABLE, Navigation.getActiveRoute())),
onPress: !policyID ? undefined : () => Navigation.navigate(createDynamicRoute(`expenses/${CONST.NETSUITE_EXPENSE_TYPE.REIMBURSABLE}`)),

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why don’t we create the expenses/reimbursable path in the dynamic route and add an entry screen for it?

onPress: !policyID
? undefined
: () => Navigation.navigate(ROUTES.POLICY_ACCOUNTING_NETSUITE_EXPORT_EXPENSES.getRoute(policyID, CONST.NETSUITE_EXPENSE_TYPE.NON_REIMBURSABLE, Navigation.getActiveRoute())),
onPress: !policyID ? undefined : () => Navigation.navigate(createDynamicRoute(`expenses/${CONST.NETSUITE_EXPENSE_TYPE.NON_REIMBURSABLE}`)),

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why don’t we create the expenses/nonreimbursable path in the dynamic route and add an entry screen for it?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've updated the getRoute. Let me know if this works.

Comment thread src/ROUTES.ts Outdated
Comment thread src/SCREENS.ts Outdated
Comment thread src/SCREENS.ts Outdated

@huult huult left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@melvin-bot melvin-bot Bot requested a review from mjasikowski April 16, 2026 09:04
@mjasikowski mjasikowski merged commit cfc826b into Expensify:main Apr 17, 2026
33 of 34 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

🚧 @mjasikowski has triggered a test Expensify/App build. You can view the workflow run here.

@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/mjasikowski in version: 9.3.61-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

@MelvinBot

Copy link
Copy Markdown
Contributor

No help site changes are required for this PR.

This PR migrates internal NetSuite export navigation routes to dynamic route patterns (refactoring ROUTES.ts, SCREENS.ts, linking config, and page components). It does not change any user-facing behavior, UI labels, feature names, or workflows — it's purely a navigation/routing code refactor. The existing NetSuite help site articles under App/docs/articles/new-expensify/connections/netsuite/ remain accurate as-is.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/marcaaron in version: 9.3.61-4 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants