perf: add selectors to derived hooks, export IOU getters#87081
Closed
rinej wants to merge 2 commits into
Closed
Conversation
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
This is PR 1 of 5 in the IOURequestStepScan decomposition series (see #85571 for the full split plan).
Adds Onyx selectors to derived hooks to prevent full-collection re-renders:
useReportIsArchived: usesisArchivedReportas selector for stable boolean outputuseDefaultExpensePolicy: extractsgetSingleGroupPolicyIDselector, replaces collection iteration with selector + per-key lookupusePolicyForMovingExpenses: extractsgetPolicyQualificationResultselector returning only IDs and flagsuseReportAttributes: addsuseReportAttributesByIDfor single-report lookups with cheap deep comparisonAlso exports two getter functions from IOU actions (
getAllTransactionDrafts,getAllReportNameValuePairs) needed by downstream variant components.No user-visible behavior changes — return types and values are preserved.
Fixed Issues
$ #85583
Tests
Offline tests
N/A — no offline behavior changes
QA Steps
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssection