Skip to content

[No QA] Update Personal-Cards.md for R2 broken connections#87058

Merged
stephanieelliott merged 2 commits into
mainfrom
claude-personalCardR2HelpSite
Apr 3, 2026
Merged

[No QA] Update Personal-Cards.md for R2 broken connections#87058
stephanieelliott merged 2 commits into
mainfrom
claude-personalCardR2HelpSite

Conversation

@MelvinBot

Copy link
Copy Markdown
Contributor

Summary

Updates the existing Personal-Cards.md help article for Release 2 of the personal card import project (Expensify/Expensify#574406).

Added sections:

  • Why a personal card connection can break — common causes (credential changes, MFA expiry, revoked access, bank outages)
  • How to fix a broken personal card connection — Fix card flow, Update card fallback, Concierge DM notification, RBR indicator
  • How the broken connection violation works — violation on receipt-scanned cash expenses, how it resolves, hyperlink to fix flow
  • New FAQ entry — "Why do I see a broken connection violation on my expenses?"
  • Updated capabilities list and metadata/keywords

Test plan

  • Verify Personal-Cards.md renders correctly on HelpDot staging
  • Review content accuracy against R2 product specs and design doc
  • Verify compliance with help authoring guidelines (task-based headings, metadata, single workflow per article)

cc @stephanieelliott

Add sections covering broken personal card connections: why connections
break, how to fix them (Fix card / Update card), Concierge DM
notification, RBR indicator, and the broken connection violation on
receipt-scanned cash expenses.

Co-authored-by: Stephanie Elliott <stephanieelliott@users.noreply.github.com>
@stephanieelliott stephanieelliott marked this pull request as ready for review April 3, 2026 08:47
@stephanieelliott stephanieelliott self-requested a review as a code owner April 3, 2026 08:47
@github-actions

github-actions Bot commented Apr 3, 2026

Copy link
Copy Markdown
Contributor

HelpDot Documentation Review

Overall Assessment

This PR updates Personal-Cards.md to add broken card connection content for Release 2. The additions are well-structured, with clear task-based headings, updated metadata, and logically organized sections. A few style compliance items need attention, but the overall quality is strong.

Scores Summary

  • Readability: 9/10 - New sections are well-organized with clear step formatting, effective bullet lists, and good scannability. Steps are sequential and action-oriented.
  • AI Readiness: 9/10 - All new headings are task-based and start with appropriate question words (How, Why, What, When). Keywords and internalScope metadata are properly updated to reflect new coverage. Feature name "personal card" is used consistently in headings.
  • Style Compliance: 7/10 - Navigation instructions are mostly correct, but there is an inconsistency between steps. One action verb ("Choose") does not match the standard set (Click/Select/Tap). The screenshot placeholder is missing required fields. See details below.

Key Findings

Positive aspects:

  • Headings follow task-based conventions consistently across all new sections
  • Metadata (description, keywords, internalScope) properly updated to reflect expanded scope
  • Navigation instructions updated from the vague "Navigate to" to the correct unified format in most places
  • FAQ entries use appropriate question words and are specific to the feature
  • The broken connection violation section clearly explains cause, effect, and resolution

Issues to address:

  1. Inconsistent navigation phrasing (Step 1 of "How to fix a broken personal card connection"): The step reads In the navigation tabs (on the left on web, on the bottom on mobile) navigate to **Account > Wallet**. Per HELPSITE_NAMING_CONVENTIONS.md, the required format is: Click the navigation tabs (on the left on web, on the bottom on mobile), then select **Account > Wallet**. The other two updated steps use the correct "Click" format, making this one inconsistent.

  2. Non-standard action verb "Choose": Step 3 of the fix flow reads Choose **Fix card**. The governance examples consistently use Click, Select, or Tap. Recommend changing to Select **Fix card**. or Click **Fix card**.

  3. Screenshot placeholder missing required fields: Per HELP_AUTHORING_GUIDELINES.md Section 8, the screenshot comment must include Suggestion:, Location:, and Purpose: fields. The current placeholder only has Suggestion: and a Design request: line. Add the missing Location: and Purpose: fields.

  4. Platform-specific language "tap": The sentence "You can tap the hyperlinked text in the violation..." uses "tap" which is mobile-specific. Consider using "click" for web or providing platform-neutral phrasing (e.g., "Select the hyperlinked text...").

  5. Trailing whitespace: Several added lines have trailing spaces (e.g., after "How to know when a personal card connection is broken", "How to fix a broken personal card connection", and in the fix steps). While cosmetic, these should be cleaned up.

Recommendations

  1. [Must fix] Update the navigation instruction in "How to fix a broken personal card connection" Step 1 to use the standard Click the navigation tabs... format for consistency with the other steps in this same PR.
  2. [Must fix] Replace Choose **Fix card** with Select **Fix card** or Click **Fix card** to match governance action verb standards.
  3. [Should fix] Add Location: and Purpose: fields to the screenshot placeholder comment per Section 8 of the authoring guidelines.
  4. [Should fix] Replace "tap the hyperlinked text" with platform-neutral or dual-platform phrasing.
  5. [Nice to have] Remove trailing whitespace from affected lines.

Files Reviewed

  • docs/articles/new-expensify/connect-credit-cards/Personal-Cards.md - Good overall quality with 4 new content sections and 3 new FAQ entries. Needs minor style compliance fixes as noted above.

keywords: [personal cards, Wallet, reimbursable, credit card import, Expensify Classic, New Expensify, assigned cards, card details]
internalScope: Audience is members with personal credit cards already connected to their account. Covers viewing and managing existing personal cards in the Wallet, including reimbursable settings. Does not cover adding new personal cards or company card programs.
description: Learn how to view, manage, and fix broken connections for personal credit cards in New Expensify.
keywords: [New Expensify, personal cards, Wallet, reimbursable, credit card import, Expensify Classic, New Expensify, assigned cards, card details, broken connection, fix card]

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Metadata issue: "New Expensify" appears twice in the keywords array. Remove the duplicate to keep metadata clean.

Suggested change
keywords: [New Expensify, personal cards, Wallet, reimbursable, credit card import, Expensify Classic, New Expensify, assigned cards, card details, broken connection, fix card]
keywords: [New Expensify, personal cards, Wallet, reimbursable, credit card import, Expensify Classic, assigned cards, card details, broken connection, fix card]

- A red dot indicator on **Wallet** in the navigation tabs.
- A red dot indicator on the card in **Wallet** leading to the error.

<!-- SCREENSHOT:

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot placeholder format violation: Per HELP_AUTHORING_GUIDELINES.md Section 8, screenshot placeholders must include Location: and Purpose: fields in addition to Suggestion:. The Design request: field is not part of the required format.

Expected structure:



## How to fix a broken personal card connection

1. In the navigation tabs (on the left on web, on the bottom on mobile) navigate to **Account > Wallet**.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Navigation phrasing inconsistency: This step uses "In the navigation tabs... navigate to" while other steps in this article (lines 24 and 50) use "Click the navigation tabs... then select". Per HELPSITE_NAMING_CONVENTIONS.md, use the standard unified phrasing consistently throughout the article. Also, "navigate to" is a prohibited vague navigation phrase.

Suggested change
1. In the navigation tabs (on the left on web, on the bottom on mobile) navigate to **Account > Wallet**.
1. Click the navigation tabs (on the left on web, on the bottom on mobile), then select **Account > Wallet**.


1. In the navigation tabs (on the left on web, on the bottom on mobile) navigate to **Account > Wallet**.
2. Under **Assigned cards**, select the card with the broken connection.
3. Choose **Fix card**.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Naming and style: "Choose" is not a standard action verb used in Expensify HelpDot articles. Use "Click", "Tap", or "Select" to match UI interaction conventions and maintain consistency with the rest of the article.

Suggested change
3. Choose **Fix card**.
3. Select **Fix card**.

3. Choose **Fix card**.
4. Log into your bank when prompted to re-authenticate the connection.

If logging into your bank doesn't resolve the issue, tap **Update card** to attempt a manual refresh.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Naming and style: "tap" should be capitalized as "Tap" or changed to "select" for consistency. More importantly, this mixes platform-specific language ("tap" implies mobile) without qualification. Since the article addresses both web and mobile, consider using "select" or "click" which are more platform-neutral, or specify the platform.

Suggested change
If logging into your bank doesn't resolve the issue, tap **Update card** to attempt a manual refresh.
If logging into your bank doesn't resolve the issue, select **Update card** to attempt a manual refresh.


To resolve the violation, fix the broken card connection by following the steps above. The violation is automatically removed from affected expenses once the connection is restored.

You can tap the hyperlinked text in the violation to go directly to the **Card details** page in **Wallet** where you can fix the connection.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Naming and style: Same issue as above -- "tap" implies mobile only. Since this article covers both web and mobile, use a platform-neutral verb like "click" or "select".

Suggested change
You can tap the hyperlinked text in the violation to go directly to the **Card details** page in **Wallet** where you can fix the connection.
You can click the hyperlinked text in the violation to go directly to the **Card details** page in **Wallet** where you can fix the connection.


- Logging into your bank successfully re-authenticates the connection.
- Tapping Update card successfully refreshes the card.
- Expensify's daily automatic card refresh succeeds.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Naming and style: "Update card" is a UI button label and should be bolded per HELPSITE_NAMING_CONVENTIONS.md button naming standards.

Suggested change
- Expensify's daily automatic card refresh succeeds.
- Tapping **Update card** successfully refreshes the card.

@OSBotify

OSBotify commented Apr 3, 2026

Copy link
Copy Markdown
Contributor

A preview of your ExpensifyHelp changes have been deployed to https://ab4bd120.helpdot.pages.dev ⚡️

Updated articles:

@joekaufmanexpensify joekaufmanexpensify left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @stephanieelliott are the bot review items something you want actioned before I merge this?

@stephanieelliott

Copy link
Copy Markdown
Contributor

@joekaufmanexpensify oh shoot yea I forgot those. They're all minor internal style things -- I'll merge this now to get the content out there, then will follow up with another PR to make those edits.

@stephanieelliott stephanieelliott merged commit 3c635b9 into main Apr 3, 2026
19 checks passed
@stephanieelliott stephanieelliott deleted the claude-personalCardR2HelpSite branch April 3, 2026 20:56
@OSBotify

OSBotify commented Apr 7, 2026

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/stephanieelliott in version: 9.3.53-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 failure ❌
🍎 iOS 🍎 failure ❌

Bundle Size Analysis (Sentry):

1 similar comment
@OSBotify

OSBotify commented Apr 7, 2026

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/stephanieelliott in version: 9.3.53-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 failure ❌
🍎 iOS 🍎 failure ❌

Bundle Size Analysis (Sentry):

@OSBotify

OSBotify commented Apr 7, 2026

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/roryabraham in version: 9.3.53-7 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants