[Payment due @eVoloshchak] Add 1-4 and 5-10 company sizes to onboarding flow#86694
Conversation
🦜 Polyglot Parrot! 🦜Squawk! Looks like you added some shiny new English strings. Allow me to parrot them back to you in other tongues: View the translation diffdiff --git a/src/languages/de.ts b/src/languages/de.ts
index 7e35f724..99df0f13 100644
--- a/src/languages/de.ts
+++ b/src/languages/de.ts
@@ -2785,9 +2785,9 @@ ${amount} für ${merchant} – ${date}`,
},
employees: {
title: 'Wie viele Mitarbeitende haben Sie?',
- [CONST.ONBOARDING_COMPANY_SIZE.MICRO_SMALL]: '1-4',
- [CONST.ONBOARDING_COMPANY_SIZE.MICRO_MEDIUM]: '5-10',
- [CONST.ONBOARDING_COMPANY_SIZE.MICRO]: '1–10 Beschäftigte',
+ [CONST.ONBOARDING_COMPANY_SIZE.MICRO_SMALL]: '1–4 Mitarbeitende',
+ [CONST.ONBOARDING_COMPANY_SIZE.MICRO_MEDIUM]: '5–10 Mitarbeitende',
+ [CONST.ONBOARDING_COMPANY_SIZE.MICRO]: '1–10 Mitarbeitende',
[CONST.ONBOARDING_COMPANY_SIZE.SMALL]: '11–50 Mitarbeitende',
[CONST.ONBOARDING_COMPANY_SIZE.MEDIUM_SMALL]: '51–100 Mitarbeitende',
[CONST.ONBOARDING_COMPANY_SIZE.MEDIUM]: '101–1.000 Mitarbeitende',
diff --git a/src/languages/fr.ts b/src/languages/fr.ts
index b3956a59..21996956 100644
--- a/src/languages/fr.ts
+++ b/src/languages/fr.ts
@@ -2792,13 +2792,13 @@ ${amount} pour ${merchant} - ${date}`,
},
employees: {
title: 'Combien d’employés avez-vous ?',
- [CONST.ONBOARDING_COMPANY_SIZE.MICRO_SMALL]: '1-4',
- [CONST.ONBOARDING_COMPANY_SIZE.MICRO_MEDIUM]: '5-10',
+ [CONST.ONBOARDING_COMPANY_SIZE.MICRO_SMALL]: '1 à 4 employés',
+ [CONST.ONBOARDING_COMPANY_SIZE.MICRO_MEDIUM]: '5 à 10 employés',
[CONST.ONBOARDING_COMPANY_SIZE.MICRO]: '1 à 10 employés',
[CONST.ONBOARDING_COMPANY_SIZE.SMALL]: '11 à 50 employés',
[CONST.ONBOARDING_COMPANY_SIZE.MEDIUM_SMALL]: '51 à 100 employés',
[CONST.ONBOARDING_COMPANY_SIZE.MEDIUM]: '101 à 1 000 employés',
- [CONST.ONBOARDING_COMPANY_SIZE.LARGE]: 'Plus de 1 000 employés',
+ [CONST.ONBOARDING_COMPANY_SIZE.LARGE]: 'Plus de 1 000 employés',
},
accounting: {
title: 'Utilisez-vous un logiciel de comptabilité ?',
diff --git a/src/languages/it.ts b/src/languages/it.ts
index ffe7b4aa..156f2b32 100644
--- a/src/languages/it.ts
+++ b/src/languages/it.ts
@@ -2779,12 +2779,12 @@ ${amount} per ${merchant} - ${date}`,
},
employees: {
title: 'Quanti dipendenti hai?',
- [CONST.ONBOARDING_COMPANY_SIZE.MICRO_SMALL]: '1-4',
- [CONST.ONBOARDING_COMPANY_SIZE.MICRO_MEDIUM]: '5-10',
+ [CONST.ONBOARDING_COMPANY_SIZE.MICRO_SMALL]: '1-4 dipendenti',
+ [CONST.ONBOARDING_COMPANY_SIZE.MICRO_MEDIUM]: '5-10 dipendenti',
[CONST.ONBOARDING_COMPANY_SIZE.MICRO]: '1-10 dipendenti',
[CONST.ONBOARDING_COMPANY_SIZE.SMALL]: '11-50 dipendenti',
[CONST.ONBOARDING_COMPANY_SIZE.MEDIUM_SMALL]: '51-100 dipendenti',
- [CONST.ONBOARDING_COMPANY_SIZE.MEDIUM]: '101-1.000 dipendenti',
+ [CONST.ONBOARDING_COMPANY_SIZE.MEDIUM]: 'Da 101 a 1.000 dipendenti',
[CONST.ONBOARDING_COMPANY_SIZE.LARGE]: 'Più di 1.000 dipendenti',
},
accounting: {
diff --git a/src/languages/ja.ts b/src/languages/ja.ts
index 1fdb0977..514e0ba2 100644
--- a/src/languages/ja.ts
+++ b/src/languages/ja.ts
@@ -2753,13 +2753,13 @@ ${date} の ${merchant} への ${amount}`,
},
employees: {
title: '従業員は何人いますか？',
- [CONST.ONBOARDING_COMPANY_SIZE.MICRO_SMALL]: '1-4',
- [CONST.ONBOARDING_COMPANY_SIZE.MICRO_MEDIUM]: '5-10',
+ [CONST.ONBOARDING_COMPANY_SIZE.MICRO_SMALL]: '1～4名の従業員',
+ [CONST.ONBOARDING_COMPANY_SIZE.MICRO_MEDIUM]: '5～10人の従業員',
[CONST.ONBOARDING_COMPANY_SIZE.MICRO]: '従業員数 1～10 人',
- [CONST.ONBOARDING_COMPANY_SIZE.SMALL]: '従業員数 11～50 人',
- [CONST.ONBOARDING_COMPANY_SIZE.MEDIUM_SMALL]: '従業員数 51～100 人',
+ [CONST.ONBOARDING_COMPANY_SIZE.SMALL]: '11～50名の従業員',
+ [CONST.ONBOARDING_COMPANY_SIZE.MEDIUM_SMALL]: '51～100人の従業員',
[CONST.ONBOARDING_COMPANY_SIZE.MEDIUM]: '101～1,000人の従業員',
- [CONST.ONBOARDING_COMPANY_SIZE.LARGE]: '1,000人を超える従業員',
+ [CONST.ONBOARDING_COMPANY_SIZE.LARGE]: '1,000人超の従業員',
},
accounting: {
title: '会計ソフトを利用していますか？',
diff --git a/src/languages/nl.ts b/src/languages/nl.ts
index 96358c40..28ea3d2e 100644
--- a/src/languages/nl.ts
+++ b/src/languages/nl.ts
@@ -2777,13 +2777,13 @@ ${amount} voor ${merchant} - ${date}`,
[CONST.ONBOARDING_CHOICES.LOOKING_AROUND]: 'Iets anders',
},
employees: {
- title: 'Hoeveel werknemers heb je?',
- [CONST.ONBOARDING_COMPANY_SIZE.MICRO_SMALL]: '1-4',
- [CONST.ONBOARDING_COMPANY_SIZE.MICRO_MEDIUM]: '5-10',
- [CONST.ONBOARDING_COMPANY_SIZE.MICRO]: '1-10 werknemers',
+ title: 'Hoeveel medewerkers heb je?',
+ [CONST.ONBOARDING_COMPANY_SIZE.MICRO_SMALL]: '1-4 medewerkers',
+ [CONST.ONBOARDING_COMPANY_SIZE.MICRO_MEDIUM]: '5-10 medewerkers',
+ [CONST.ONBOARDING_COMPANY_SIZE.MICRO]: '1-10 medewerkers',
[CONST.ONBOARDING_COMPANY_SIZE.SMALL]: '11-50 medewerkers',
- [CONST.ONBOARDING_COMPANY_SIZE.MEDIUM_SMALL]: '51-100 werknemers',
- [CONST.ONBOARDING_COMPANY_SIZE.MEDIUM]: '101–1.000 werknemers',
+ [CONST.ONBOARDING_COMPANY_SIZE.MEDIUM_SMALL]: '51-100 medewerkers',
+ [CONST.ONBOARDING_COMPANY_SIZE.MEDIUM]: '101-1.000 werknemers',
[CONST.ONBOARDING_COMPANY_SIZE.LARGE]: 'Meer dan 1.000 medewerkers',
},
accounting: {
diff --git a/src/languages/pl.ts b/src/languages/pl.ts
index 630c12e1..7a3c0c23 100644
--- a/src/languages/pl.ts
+++ b/src/languages/pl.ts
@@ -2771,8 +2771,8 @@ ${amount} dla ${merchant} - ${date}`,
},
employees: {
title: 'Ilu masz pracowników?',
- [CONST.ONBOARDING_COMPANY_SIZE.MICRO_SMALL]: '1-4',
- [CONST.ONBOARDING_COMPANY_SIZE.MICRO_MEDIUM]: '5-10',
+ [CONST.ONBOARDING_COMPANY_SIZE.MICRO_SMALL]: '1–4 pracowników',
+ [CONST.ONBOARDING_COMPANY_SIZE.MICRO_MEDIUM]: '5–10 pracowników',
[CONST.ONBOARDING_COMPANY_SIZE.MICRO]: '1–10 pracowników',
[CONST.ONBOARDING_COMPANY_SIZE.SMALL]: '11–50 pracowników',
[CONST.ONBOARDING_COMPANY_SIZE.MEDIUM_SMALL]: '51–100 pracowników',
diff --git a/src/languages/pt-BR.ts b/src/languages/pt-BR.ts
index 9f7a558f..f61549ef 100644
--- a/src/languages/pt-BR.ts
+++ b/src/languages/pt-BR.ts
@@ -2770,11 +2770,11 @@ ${amount} para ${merchant} - ${date}`,
},
employees: {
title: 'Quantos funcionários você tem?',
- [CONST.ONBOARDING_COMPANY_SIZE.MICRO_SMALL]: '1-4',
- [CONST.ONBOARDING_COMPANY_SIZE.MICRO_MEDIUM]: '5-10',
- [CONST.ONBOARDING_COMPANY_SIZE.MICRO]: '1–10 funcionários',
+ [CONST.ONBOARDING_COMPANY_SIZE.MICRO_SMALL]: '1–4 funcionários',
+ [CONST.ONBOARDING_COMPANY_SIZE.MICRO_MEDIUM]: '5–10 funcionários',
+ [CONST.ONBOARDING_COMPANY_SIZE.MICRO]: '1-10 funcionários',
[CONST.ONBOARDING_COMPANY_SIZE.SMALL]: '11–50 funcionários',
- [CONST.ONBOARDING_COMPANY_SIZE.MEDIUM_SMALL]: '51–100 funcionários',
+ [CONST.ONBOARDING_COMPANY_SIZE.MEDIUM_SMALL]: '51 a 100 funcionários',
[CONST.ONBOARDING_COMPANY_SIZE.MEDIUM]: '101–1.000 funcionários',
[CONST.ONBOARDING_COMPANY_SIZE.LARGE]: 'Mais de 1.000 funcionários',
},
diff --git a/src/languages/zh-hans.ts b/src/languages/zh-hans.ts
index d444e806..a7ede158 100644
--- a/src/languages/zh-hans.ts
+++ b/src/languages/zh-hans.ts
@@ -2707,11 +2707,11 @@ ${amount}，商户：${merchant} - 日期：${date}`,
},
employees: {
title: '您有多少名员工？',
- [CONST.ONBOARDING_COMPANY_SIZE.MICRO_SMALL]: '1-4',
- [CONST.ONBOARDING_COMPANY_SIZE.MICRO_MEDIUM]: '5-10',
- [CONST.ONBOARDING_COMPANY_SIZE.MICRO]: '1–10 名员工',
- [CONST.ONBOARDING_COMPANY_SIZE.SMALL]: '11-50 名员工',
- [CONST.ONBOARDING_COMPANY_SIZE.MEDIUM_SMALL]: '51-100 名员工',
+ [CONST.ONBOARDING_COMPANY_SIZE.MICRO_SMALL]: '1–4 名员工',
+ [CONST.ONBOARDING_COMPANY_SIZE.MICRO_MEDIUM]: '5–10 名员工',
+ [CONST.ONBOARDING_COMPANY_SIZE.MICRO]: '1-10 名员工',
+ [CONST.ONBOARDING_COMPANY_SIZE.SMALL]: '11–50 名员工',
+ [CONST.ONBOARDING_COMPANY_SIZE.MEDIUM_SMALL]: '51–100 名员工',
[CONST.ONBOARDING_COMPANY_SIZE.MEDIUM]: '101–1,000 名员工',
[CONST.ONBOARDING_COMPANY_SIZE.LARGE]: '超过 1,000 名员工',
},
Note You can apply these changes to your branch by copying the patch to your clipboard, then running |
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
neil-marcellini
changed the title
|
@codex please review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3f335de3a9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Splits the existing 1-10 (MICRO) bracket into two granular options: - 1-4 (MICRO_SMALL): assigned to Concierge - 5-10 (MICRO_MEDIUM): assigned to a human Guide Updates CONST, translations, HeaderView webinar/guide-booking checks, RHP variant experiment detection, and onboarding employee size picker to filter out the legacy 1-10 option from the UI while preserving backward compatibility for existing users. Made-with: Cursor
Updates all non-English translation files with proper localized strings for the 1-4 and 5-10 employee count options from the OSBotify translation suggestion. Made-with: Cursor
Made-with: Cursor
Made-with: Cursor
neil-marcellini
force-pushed
the
claude-addGranularCompanySizeBrackets
branch
from
3f335de to
925afe8
Compare
|
(Neil's AI agent) @codex please review |
neil-marcellini
changed the title
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 925afe887f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Made-with: Cursor
The previous comment was misleading — it implied that the granular sizes (1-4, 5-10) were "SMB-only" and only appeared for SMB users, when in fact the opposite is true: they are hidden for SMB users. Reworded to accurately describe the filter behavior. Made-with: Cursor
OnyxInputOrEntry was removed from react-native-onyx@3.0.58. Replace with OnyxEntry which covers the same nullable pattern. Made-with: Cursor
neil-marcellini
changed the title
melvin-bot
Bot
requested review from
JmillsExpensify and
eVoloshchak
and removed request for
a team
|
@eVoloshchak Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
melvin-bot
Bot
changed the title
|
🎯 @eVoloshchak, thanks for reviewing and testing this PR! 🎉 A payment issue will be created for your review once this PR is deployed to production. If payment is not needed (e.g., regression PR review fix etc), react with 👎 to this comment to prevent the payment issue from being created. |
neil-marcellini
changed the title
Combine the variantOverride parameter and TRACK_EXPENSES_WITH_CONCIERGE early return from main with our MICRO_SMALL company size check. Made-with: Cursor
This type was removed from react-native-onyx in a recent main merge but the import was left behind, causing an ESLint no-unused-vars error. Made-with: Cursor
|
We have some conflicts |
Resolve merge conflicts with main and reset the Mobile-Expensify submodule pointer to match main, removing the unintentional submodule change from this PR. Made-with: Cursor
Made-with: Cursor
|
🚧 @Gonals has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
Hi @neil-marcellini Do we need check something here? Thank you
|
|
🚀 Deployed to staging by https://github.com/Gonals in version: 9.3.61-0 🚀
Bundle Size Analysis (Sentry): |
|
I reviewed the changes in this PR and searched all help site articles under No help site changes are required. The PR modifies the onboarding company size selection (splitting "1-10" into "1-4" and "5-10"), but the help site does not document the specific company size options shown during the signup/onboarding flow. No existing articles reference these options. |
|
🚀 Deployed to production by https://github.com/marcaaron in version: 9.3.61-4 🚀
|
|
According to #86694 (comment):
This was deployed to production on 23 Apr, but the payment issue was never created |
9 participants
(Neil's AI agent)
Explanation of Change
Adds two new granular company size brackets (
1-4and5-10) to the onboarding flow, replacing the existing1-10option. This gives more precise lead qualification for small teams:1-4(MICRO_SMALL): Assigned to Concierge (same as legacy1-10)5-10(MICRO_MEDIUM): Assigned to a human Guide (same as11-50and above)1-10(MICRO): Preserved for backward compatibility with existing users but hidden from the UICompanion PRs (must deploy first):
Fixed Issues
$ https://github.com/Expensify/Expensify/issues/613539
Tests
Note: Guide assignment (Concierge vs human guide) cannot easily be verified on dev because the dev environment has no guides policy populated. Guide routing correctness is covered by automated tests. Full end-to-end guide assignment will be verified in the issue after all PRs have deployed. I have set a reminder for this.
Dev testing (UI and data persistence):
introSelectedNVP hascompanySize: "1-4"stored correctly (see query below)introSelectedNVP hascompanySize: "5-10"stored correctlySQL query to check the NVP value on dev (replace
<email>with the test user's email):2026-03-30_14-58-24.mp4
10+ employee sign up
2026-04-06_07-36-33.mp4
Offline tests
No offline-specific behavior changes — company size selection is part of the onboarding flow which requires connectivity.
QA Steps
Note: Guide assignment logic can't be easily QAed because we skip it for the applause domain and test accounts. We will test on prod as mentioned above.
On staging (full guide assignment verification):
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Covered by automated CI build check.
Android: mWeb Chrome
Covered by automated CI build check.
iOS: Native
Covered by automated CI build check.
iOS: mWeb Safari
Covered by automated CI build check.
MacOS: Chrome / Safari
See video in Tests section above.