[No QA] perf: remove unused props and subscriptions from LHN rendering pipeline by BartekObudzinski · Pull Request #86227 · Expensify/App

BartekObudzinski · 2026-03-24T14:02:34Z

Explanation of Change

Strips unused props and subscriptions from the LHN rendering pipeline to reduce unnecessary work per item.

OptionRowLHNData: Removed deepEqual + useRef memoization of optionItem. React Compiler auto-memoizes each expression in the downstream OptionRowLHN independently, so stabilizing the whole object reference is unnecessary. Also removed remaining useMemo for finalOptionItem (pure derivation the compiler handles).

LHNOptionsList: Removed 7 unused props passed to OptionRowLHNData that were never consumed:

reportActions, iouReportReportActions (report action collections)
transaction, lastReportActionTransaction (transaction objects)
transactionViolations (collection subscription)
preferredLocale, activePolicyID (scalar values)

This also eliminates 2 useOnyx subscriptions (transactionViolations, activePolicyID) and related computation in renderItem.

OptionsListUtils createOption: Refactored from 11 positional parameters to a single named-params object for readability and to eliminate undefined placeholder arguments at call sites.

Benchmark: getFilteredOptions with search value improved by 86% (12.1ms to 1.7ms). LHN functions neutral with no regressions.

Fixed Issues

$ #86311
PROPOSAL:

Tests

Internal refactor removing unused props and subscriptions. No user-facing behavior changes.

Verify that no errors appear in the JS console

Offline tests

No changes to offline behavior.

QA Steps

No QA needed. Internal refactor only, no user-facing changes.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

…sed-props-and-subscriptions # Conflicts: # src/components/LHNOptionsList/LHNOptionsList.tsx # src/components/LHNOptionsList/OptionRowLHNData.tsx # src/components/LHNOptionsList/types.ts

melvin-bot · 2026-03-25T11:17:37Z

@ShridharGoel Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 1d3013dbd5

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

JS00001 · 2026-03-25T11:45:08Z

Theres a bunch of conflicts

…sed-props-and-subscriptions # Conflicts: # src/components/LHNOptionsList/LHNOptionsList.tsx # src/components/LHNOptionsList/OptionRowLHNData.tsx # src/components/LHNOptionsList/types.ts

ShridharGoel · 2026-03-25T21:51:52Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2026-03-20.at.12.47.42.AM.mov

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

Keep branch's removal of unused props/subscriptions and deepEqual pattern. Upstream added itemReportActions (unused), areReportErrorsEqual (redundant with React Compiler), and extra type imports (for removed props).

github-actions · 2026-03-26T12:23:55Z

🚧 @JS00001 has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-03-26T12:28:22Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #86227.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-89ff0e5-23e70e6-1499fe4b3727545e9a9a0a4f1b166514b55ab6e7/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-89ff0e5-23e70e6-78af505a931d03be02d452fb006d4b15c9fdcebd/index.html

Web 🕸️
https://86227.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-03-26T12:31:55Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2026-03-26T14:42:53Z

🚀 Deployed to staging by https://github.com/JS00001 in version: 9.3.49-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

OSBotify · 2026-03-27T12:25:01Z

🚀 Deployed to production by https://github.com/grgia in version: 9.3.49-2 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

perf: remove deepEqual and phantom props from LHN rendering

01354ae

melvin-bot Bot assigned BartekObudzinski Mar 24, 2026

Merge remote-tracking branch 'upstream/main' into perf/lhn-remove-unu…

1d3013d

…sed-props-and-subscriptions # Conflicts: # src/components/LHNOptionsList/LHNOptionsList.tsx # src/components/LHNOptionsList/OptionRowLHNData.tsx # src/components/LHNOptionsList/types.ts

BartekObudzinski mentioned this pull request Mar 24, 2026

[Metrics] Improve ManualNavigateToInboxTab #77175

Open

BartekObudzinski changed the title ~~perf: remove unused props and subscriptions from LHN rendering pipeline~~ perf: remove unused props and subscriptions from LHN rendering pipeline [No QA] Mar 25, 2026

BartekObudzinski changed the title ~~perf: remove unused props and subscriptions from LHN rendering pipeline [No QA]~~ [No QA] perf: remove unused props and subscriptions from LHN rendering pipeline Mar 25, 2026

JS00001 mentioned this pull request Mar 25, 2026

[Due For Payment 2026-04-16] Remove unnecessary subscriptions from the LHN #86311

Closed

BartekObudzinski marked this pull request as ready for review March 25, 2026 11:17

BartekObudzinski requested review from a team as code owners March 25, 2026 11:17

melvin-bot Bot requested a review from ShridharGoel March 25, 2026 11:17

melvin-bot Bot requested review from heyjennahay and removed request for a team March 25, 2026 11:17

JS00001 self-requested a review March 25, 2026 11:26

chatgpt-codex-connector Bot reviewed Mar 25, 2026

View reviewed changes

Comment thread src/components/LHNOptionsList/LHNOptionsList.tsx

JS00001 previously approved these changes Mar 25, 2026

View reviewed changes

Merge remote-tracking branch 'upstream/main' into perf/lhn-remove-unu…

4481aa8

…sed-props-and-subscriptions # Conflicts: # src/components/LHNOptionsList/LHNOptionsList.tsx # src/components/LHNOptionsList/OptionRowLHNData.tsx # src/components/LHNOptionsList/types.ts

BartekObudzinski dismissed JS00001’s stale review via 4481aa8 March 25, 2026 11:57

ShridharGoel approved these changes Mar 25, 2026

View reviewed changes

melvin-bot Bot requested a review from JS00001 March 25, 2026 21:52

BartekObudzinski added 3 commits March 26, 2026 11:15

merge: resolve conflicts with upstream/main

fd7967a

Keep branch's removal of unused props/subscriptions and deepEqual pattern. Upstream added itemReportActions (unused), areReportErrorsEqual (redundant with React Compiler), and extra type imports (for removed props).

fix: remove duplicate reportAttributes dependency

afb406a

fix: remove duplicate reportAttributes props in types

5e92ccd

JS00001 approved these changes Mar 26, 2026

View reviewed changes

JS00001 merged commit 89ff0e5 into Expensify:main Mar 26, 2026
31 checks passed

OSBotify mentioned this pull request Mar 26, 2026

Deploy Checklist: New Expensify 2026-03-26 #86439

Closed

29 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[No QA] perf: remove unused props and subscriptions from LHN rendering pipeline#86227

[No QA] perf: remove unused props and subscriptions from LHN rendering pipeline#86227
JS00001 merged 6 commits into
Expensify:mainfrom
callstack-internal:perf/lhn-remove-unused-props-and-subscriptions

BartekObudzinski commented Mar 24, 2026 •

edited

Loading

Uh oh!

melvin-bot Bot commented Mar 25, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

Uh oh!

JS00001 commented Mar 25, 2026 •

edited

Loading

Uh oh!

ShridharGoel commented Mar 25, 2026

Uh oh!

Uh oh!

github-actions Bot commented Mar 26, 2026

Uh oh!

github-actions Bot commented Mar 26, 2026

Uh oh!

OSBotify commented Mar 26, 2026

Uh oh!

OSBotify commented Mar 26, 2026

Uh oh!

OSBotify commented Mar 27, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

BartekObudzinski commented Mar 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Mar 25, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

JS00001 commented Mar 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ShridharGoel commented Mar 25, 2026

Reviewer Checklist

Screenshots/Videos

Uh oh!

Uh oh!

github-actions Bot commented Mar 26, 2026

Uh oh!

github-actions Bot commented Mar 26, 2026

Uh oh!

OSBotify commented Mar 26, 2026

Uh oh!

OSBotify commented Mar 26, 2026

Uh oh!

OSBotify commented Mar 27, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

BartekObudzinski commented Mar 24, 2026 •

edited

Loading

JS00001 commented Mar 25, 2026 •

edited

Loading