[No QA] refactor: replace deprecated getReportName with getReportNameFromDerived in sidebar sorting by BartekObudzinski · Pull Request #86193 · Expensify/App

BartekObudzinski · 2026-03-24T11:22:06Z

Explanation of Change

The deprecated getReportName function was used in two places in sidebar sorting and welcome message generation: categorizeReportsForLHN and getRoomWelcomeMessage. This function requires a conciergeReportID parameter and has been marked deprecated in favor of getReportNameFromDerived, which reads from the pre-computed reportAttributes derived value.

This change replaces both call sites with getReportNameFromDerived, passes reportAttributes from useReportAttributes() through the call chain, and removes the now-unnecessary conciergeReportID Onyx subscription from useSidebarOrderedReports. The DebugReportActions component also gets the same update to stay consistent.

The internal helper functions categorizeReportsForLHN, sortCategorizedReports, and combineReportCategories are no longer exported on the default object — they are now exported as named underscore-prefixed exports for unit testing only, which makes the public API of SidebarUtils cleaner.

Reassure benchmark on 15k reports shows an 11.1% improvement on getReportsToDisplayInLHN (default mode: 68.9ms to 61.2ms) with no regressions.

Fixed Issues

$ #86312
PROPOSAL:

Tests

Open the app and navigate to the LHN (inbox/sidebar). Verify report names display correctly for all report types (chat rooms, expense reports, policy expense chats, invoices, DMs).
Switch between Default and Focus (GSD) priority modes and verify the LHN sort order is correct in both modes.
Pin a report and verify it appears at the top of the LHN.
Open a chat room. Verify the welcome message text renders correctly (including room name substitution).
Open the Debug screen for a report and verify the action list renders without errors.

Verify that no errors appear in the JS console

Offline tests

N/A - This is a pure refactor with no changes to offline behavior. The derived value fallback (report.reportName) ensures names display even when derived data is not yet populated.

QA Steps

No QA needed. This is a pure internal refactor that replaces a deprecated function call with its recommended replacement. No user-facing behavior changes. All existing unit tests pass with updated signatures.

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

…ved in sidebar sorting

codecov · 2026-03-24T11:41:51Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/components/ReportWelcomeText.tsx	`94.44% <ø> (ø)`
src/hooks/useSidebarOrderedReports.tsx	`96.17% <100.00%> (-0.03%)`	⬇️
src/libs/SidebarUtils.ts	`80.13% <100.00%> (-0.11%)`	⬇️
...bs/actions/OnyxDerived/configs/reportAttributes.ts	`96.79% <100.00%> (+0.04%)`	⬆️
src/pages/Debug/Report/DebugReportActions.tsx	`96.42% <0.00%> (ø)`
... and 245 files with indirect coverage changes

BartekObudzinski · 2026-03-24T11:43:37Z

@MelvinBot please measure actual performance (this branch vs main) with high-traffic test data

melvin-bot · 2026-03-25T11:19:31Z

@dmkt9 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6d5db0e055

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-03-25T11:35:19Z


    const getOrderedReportIDs = useCallback(
-        () => SidebarUtils.sortReportsToDisplayInLHN(reportsToDisplayInLHN, priorityMode, localeCompare, hasDraftByReportID, reportNameValuePairs, conciergeReportID),
+        () => SidebarUtils.sortReportsToDisplayInLHN(reportsToDisplayInLHN, priorityMode, localeCompare, hasDraftByReportID, reportNameValuePairs, reportAttributes),


Keep concierge ID as a sort invalidation signal

This change removes the CONCIERGE_REPORT_ID subscription from sidebar ordering and replaces it with reportAttributes, but REPORT_ATTRIBUTES derivation does not list ONYXKEYS.CONCIERGE_REPORT_ID as a dependency (src/libs/actions/OnyxDerived/configs/reportAttributes.ts dependencies block). If concierge ID is loaded after initial report hydration, report attributes are not recomputed, so this sorter keeps using stale/empty concierge display names (especially when report.reportName is empty) and the LHN order/text can stay incorrect until some unrelated report update happens. Before this commit, concierge ID changes directly invalidated sorting.

Useful? React with 👍 / 👎.

Good catch. Added ONYXKEYS.CONCIERGE_REPORT_ID to reportAttributes dependencies and it now triggers a full recompute when the value changes.

JS00001 · 2026-03-25T12:53:11Z

@dmkt9 would you mind reviewing this one?

dmkt9 · 2026-03-25T14:05:59Z

@dmkt9 would you mind reviewing this one?

@JS00001 Thank you for the reminder. I'm on it now.

dmkt9 · 2026-03-25T14:18:27Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

android.hybrid.mp4

Android: mWeb Chrome

iOS: HybridApp

ios.hybrid.mp4

iOS: mWeb Safari

MacOS: Chrome / Safari

mac.safari.mp4

dmkt9

LGTM

github-actions · 2026-03-25T16:27:24Z

🚧 @JS00001 has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-03-25T16:32:04Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #86193.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-4cbb26b-9fdeaab-6b8372544757bc383c0fd4b0bc10462f0d511c68/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-4cbb26b-9fdeaab-caada2ec727050957ff831c5e075969efb6b2720/index.html

Web 🕸️
https://86193.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-03-26T14:42:50Z

🚀 Deployed to staging by https://github.com/JS00001 in version: 9.3.49-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

OSBotify · 2026-03-27T12:24:58Z

🚀 Deployed to production by https://github.com/grgia in version: 9.3.49-2 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

refactor: replace deprecated getReportName with getReportNameFromDeri…

2c731f5

…ved in sidebar sorting

melvin-bot Bot assigned BartekObudzinski Mar 24, 2026

BartekObudzinski changed the title ~~refactor: replace deprecated getReportName with getReportNameFromDerived in sidebar sorting~~ [No QA] refactor: replace deprecated getReportName with getReportNameFromDerived in sidebar sorting Mar 24, 2026

fix: provide reportAttributes in archived welcome message tests

6d5db0e

BartekObudzinski mentioned this pull request Mar 24, 2026

[Metrics] Improve ManualNavigateToInboxTab #77175

Open

JS00001 mentioned this pull request Mar 25, 2026

[Due for payment 2026-04-03] Replace deprecated getReportName with getReportNameFromDerived #86312

Closed

BartekObudzinski marked this pull request as ready for review March 25, 2026 11:19

BartekObudzinski requested review from a team as code owners March 25, 2026 11:19

melvin-bot Bot requested a review from dmkt9 March 25, 2026 11:19

melvin-bot Bot requested review from JmillsExpensify and removed request for a team March 25, 2026 11:19

JS00001 self-requested a review March 25, 2026 11:26

chatgpt-codex-connector Bot reviewed Mar 25, 2026

View reviewed changes

JS00001 previously approved these changes Mar 25, 2026

View reviewed changes

fix: add CONCIERGE_REPORT_ID to reportAttributes dependencies

f00e0ff

BartekObudzinski dismissed JS00001’s stale review via f00e0ff March 25, 2026 12:48

dmkt9 approved these changes Mar 25, 2026

View reviewed changes

melvin-bot Bot requested a review from JS00001 March 25, 2026 16:04

JS00001 approved these changes Mar 25, 2026

View reviewed changes

JS00001 merged commit 4cbb26b into Expensify:main Mar 25, 2026
32 of 33 checks passed

OSBotify mentioned this pull request Mar 26, 2026

Deploy Checklist: New Expensify 2026-03-26 #86439

Closed

29 tasks

Uh oh!

Conversation

BartekObudzinski commented Mar 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov Bot commented Mar 24, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

BartekObudzinski commented Mar 24, 2026

Uh oh!

melvin-bot Bot commented Mar 25, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Mar 25, 2026

Choose a reason for hiding this comment

Uh oh!

BartekObudzinski Mar 25, 2026

Choose a reason for hiding this comment

Uh oh!

JS00001 commented Mar 25, 2026

Uh oh!

dmkt9 commented Mar 25, 2026

Uh oh!

dmkt9 commented Mar 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

dmkt9 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions Bot commented Mar 25, 2026

Uh oh!

github-actions Bot commented Mar 25, 2026

Uh oh!

OSBotify commented Mar 26, 2026

Uh oh!

OSBotify commented Mar 27, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

BartekObudzinski commented Mar 24, 2026 •

edited

Loading

codecov Bot commented Mar 24, 2026 •

edited by github-actions Bot

Loading

dmkt9 commented Mar 25, 2026 •

edited

Loading