Perf: extract action buttons from MoneyRequestReportPreviewContent into isolated components by TMisiukiewicz · Pull Request #85949 · Expensify/App

TMisiukiewicz · 2026-03-20T13:51:45Z

Explanation of Change

Extracted action button logic from MoneyRequestReportPreviewContent into isolated components to reduce re-renders.

Architecture:

ReportPreviewActionButton (router) — determines which button to show, conditionally renders only the active one
SubmitActionButton / ApproveActionButton / PayActionButton — self-contained components with their own Onyx subscriptions, only mounted when needed
Export/View/AddExpense stay inline in the router (lightweight)
ProcessMoneyReportHoldMenu stays in the parent at its original DOM position

Key benefits:

Only the active button's hooks run — no wasted subscriptions for buttons that aren't shown
~14 Onyx subscriptions removed from the parent component
When action-button-related data changes, only the button area re-renders — carousel, header, and preview message are untouched
All components subscribe by ID instead of receiving full objects as props

Fixed Issues

$ #86111
PROPOSAL:

Tests

Create a new workspace
Go to Workspace chat
(+) -> Submit expense
Add manual expense
Verify the expense appeared in the chat with Submit button
Press Submit button
Verify it changed into Submitted and then transitioned into Approve button
Press Approve button
Verify it transitioned into Pay button
Press Pay button
Use Mark as paid option
Verify the button transitioned into View button

Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

ios.mov

iOS: mWeb Safari

MacOS: Chrome / Safari

web.mov

codecov · 2026-03-20T14:07:28Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
...RequestReportPreview/ReportPreviewActionButton.tsx	`100.00% <100.00%> (ø)`
.../MoneyRequestReportPreview/ApproveActionButton.tsx	`0.00% <0.00%> (ø)`
...m/MoneyRequestReportPreview/SubmitActionButton.tsx	`0.00% <0.00%> (ø)`
...ReportPreview/MoneyRequestReportPreviewContent.tsx	`61.29% <20.00%> (-1.32%)`	⬇️
...Item/MoneyRequestReportPreview/PayActionButton.tsx	`0.00% <0.00%> (ø)`
... and 19 files with indirect coverage changes

TMisiukiewicz · 2026-03-20T14:14:37Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ef89f48a86

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

…report-preview-action-buttons

melvin-bot · 2026-03-23T15:43:02Z

@Eskalifer1 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ef2421672e

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Krishna2323 · 2026-03-23T15:58:44Z

Please address the comments from github-actions and codex review. I'll start reviewing this shortly.

Krishna2323 · 2026-03-23T20:47:37Z

Reviewing...

…report-preview-action-buttons # Conflicts: # src/components/ReportActionItem/MoneyRequestReportPreview/MoneyRequestReportPreviewContent.tsx

…rBillingGraceEndPeriod

…erBillingGraceEndPeriod

…leans

TMisiukiewicz · 2026-03-24T09:17:54Z

addressed all comments

Krishna2323 · 2026-03-24T16:02:46Z

Reviewing...

trjExpensify · 2026-03-24T18:21:36Z

PR doesn’t need product input as a performance PR. Unassigning and unsubscribing myself.

Krishna2323 · 2026-03-25T18:41:07Z

@TMisiukiewicz we have conflicts. Please also check the review comments above.

…EW beta Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

adhorodyski · 2026-03-26T11:56:56Z

@Krishna2323 updated the PR and addressed your feedback

Krishna2323 · 2026-03-26T14:40:20Z

Reviewing...

Krishna2323 · 2026-03-26T15:12:55Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

android_hybrid.mp4

Android: mWeb Chrome

android_mWebchrome.mp4

iOS: HybridApp

ios_native.mp4

iOS: mWeb Safari

ios_safari.mp4

MacOS: Chrome / Safari

web_chrome.mp4

Krishna2323

LGTM and works well! 🚀

Krishna2323 · 2026-03-26T15:14:41Z

Create a new workspace

Go to Workspace chat

-> Submit expense

Add manual expense

Verify the expense appeared in the chat with Submit button

Press Submit button

Verify it changed into Submitted and then transitioned into Approve button

Press Approve button

Verify it transitioned into Pay button

Press Pay button

Use Mark as paid option

Verify the button transitioned into View button

@TMisiukiewicz could you please update the step 3

github-actions · 2026-03-26T15:32:58Z

🚧 @rlinoz has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-03-26T15:37:58Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #85949.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-b1ed132-3063164-d1443296f91b9af0d96cf759e96e3ccf9d4bbb73/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-b1ed132-3063164-62fec11c9b2d2531c8dcd405eaf337042fb5edeb/index.html

Web 🕸️
https://85949.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-03-26T15:40:33Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2026-03-27T12:51:34Z

🚀 Deployed to staging by https://github.com/rlinoz in version: 9.3.50-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

MelvinBot · 2026-03-27T12:52:42Z

I have failed to help you. I let you down and for that I am sorry. Please try again later. This may be due to a Claude outage (check here).

Failure details: https://github.com/Expensify/Expensify/actions/runs/23647062021

OSBotify · 2026-03-31T21:51:24Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.3.50-8 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

TMisiukiewicz added 2 commits March 20, 2026 13:12

decompose buttons for preview content

62c8a51

Merge origin/main

ef89f48

melvin-bot Bot assigned TMisiukiewicz Mar 20, 2026

TMisiukiewicz mentioned this pull request Mar 20, 2026

[No QA] Perf: lazily compute B2B invoice report lookup on payment instead of every render #85813

Closed

52 tasks

chatgpt-codex-connector Bot reviewed Mar 20, 2026

View reviewed changes

Comment thread src/components/ReportActionItem/MoneyRequestReportPreview/MoneyRequestReportPreviewContent.tsx Outdated

Comment thread src/components/ReportActionItem/MoneyRequestReportPreview/ReportPreviewActionButton.tsx Outdated

TMisiukiewicz added 3 commits March 20, 2026 15:46

Remove inline selectors, use getReportTransactions instead

e3dc574

Fix hold menu amounts and filter optimistically deleted transactions

d63a471

Merge remote-tracking branch 'origin/main' into tomasz/money-request-…

ef24216

…report-preview-action-buttons

TMisiukiewicz marked this pull request as ready for review March 23, 2026 15:42

TMisiukiewicz requested review from a team as code owners March 23, 2026 15:42

melvin-bot Bot requested review from Eskalifer1 and trjExpensify and removed request for a team and Eskalifer1 March 23, 2026 15:43

melvin-bot Bot removed the request for review from a team March 23, 2026 15:43

github-actions Bot reviewed Mar 23, 2026

View reviewed changes

Comment thread src/components/ReportActionItem/MoneyRequestReportPreview/ReportPreviewActionButton.tsx

github-actions Bot reviewed Mar 23, 2026

View reviewed changes

Comment thread src/components/ReportActionItem/MoneyRequestReportPreview/ReportPreviewActionButton.tsx

github-actions Bot reviewed Mar 23, 2026

View reviewed changes

Comment thread src/components/ReportActionItem/MoneyRequestReportPreview/PayActionButton.tsx Outdated

github-actions Bot reviewed Mar 23, 2026

View reviewed changes

Comment thread src/components/ReportActionItem/MoneyRequestReportPreview/PayActionButton.tsx Outdated

rlinoz mentioned this pull request Mar 23, 2026

[$250] Extract action buttons from MoneyRequestReportPreviewContent #86111

Closed

chatgpt-codex-connector Bot reviewed Mar 23, 2026

View reviewed changes

Comment thread src/components/ReportActionItem/MoneyRequestReportPreview/SubmitActionButton.tsx Outdated

rlinoz requested review from Krishna2323 and rlinoz March 23, 2026 15:57

Krishna2323 reviewed Mar 23, 2026

View reviewed changes

TMisiukiewicz added 6 commits March 24, 2026 08:55

Merge remote-tracking branch 'origin/main' into tomasz/money-request-…

a6f75cb

…report-preview-action-buttons # Conflicts: # src/components/ReportActionItem/MoneyRequestReportPreview/MoneyRequestReportPreviewContent.tsx

Fix SubmitActionButton: remove wrong delegate guard, add missing owne…

fc08f46

…rBillingGraceEndPeriod

Preserve shouldShowPayButton semantics for hold menu, add missing own…

8140276

…erBillingGraceEndPeriod

Fix confirmApproval in PayActionButton to include full approve flow

a1251b4

Use variables.h40 instead of hardcoded 40, replace || with ?? for boo…

3ad0264

…leans

fix prettier

3a27f0c

Krishna2323 suggested changes Mar 24, 2026

View reviewed changes

trjExpensify removed their request for review March 24, 2026 18:21

adhorodyski and others added 2 commits March 26, 2026 12:50

Merge exfy/main: resolve conflicts, adopt RTER confirmation, remove D…

4d262e4

…EW beta Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Fix ?? back to || for boolean shouldShowPayButton and canIOUBePaid

e2d7b9d

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

rlinoz requested a review from Krishna2323 March 26, 2026 12:54

Krishna2323 approved these changes Mar 26, 2026

View reviewed changes

rlinoz approved these changes Mar 26, 2026

View reviewed changes

rlinoz merged commit b1ed132 into Expensify:main Mar 26, 2026
34 checks passed

OSBotify mentioned this pull request Mar 27, 2026

Deploy Checklist: New Expensify 2026-03-27 #86530

Closed

86 tasks

kacper-mikolajczak mentioned this pull request May 14, 2026

Refine reviewer rules based on automated tracker feedback #90591

Closed

Uh oh!

Conversation

TMisiukiewicz commented Mar 20, 2026 • edited by rlinoz Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov Bot commented Mar 20, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

TMisiukiewicz commented Mar 20, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

melvin-bot Bot commented Mar 23, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Krishna2323 commented Mar 23, 2026

Uh oh!

Krishna2323 commented Mar 23, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

TMisiukiewicz commented Mar 24, 2026

Uh oh!

Krishna2323 commented Mar 24, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

trjExpensify commented Mar 24, 2026

Uh oh!

Krishna2323 commented Mar 25, 2026

Uh oh!

adhorodyski commented Mar 26, 2026

Uh oh!

Krishna2323 commented Mar 26, 2026

Uh oh!

Krishna2323 commented Mar 26, 2026

Reviewer Checklist

Screenshots/Videos

Uh oh!

Krishna2323 left a comment

Choose a reason for hiding this comment

Uh oh!

Krishna2323 commented Mar 26, 2026

Uh oh!

Uh oh!

github-actions Bot commented Mar 26, 2026

Uh oh!

github-actions Bot commented Mar 26, 2026

Uh oh!

OSBotify commented Mar 26, 2026

Uh oh!

OSBotify commented Mar 27, 2026

Uh oh!

MelvinBot commented Mar 27, 2026

Uh oh!

OSBotify commented Mar 31, 2026

Uh oh!

Reviewers

TMisiukiewicz commented Mar 20, 2026 •

edited by rlinoz

Loading

codecov Bot commented Mar 20, 2026 •

edited by github-actions Bot

Loading