Migrate SearchAutocompleteList to useFilteredOptions by hoangzinh · Pull Request #85922 · Expensify/App

hoangzinh · 2026-03-20T09:57:14Z

Explanation of Change

Replace useOptionsList context hook with useFilteredOptions to eliminate unnecessary background recalculations on personal details/reports changes.

Part of OptionListContextProvider removal effort.

Fixed Issues

$ #82187
PROPOSAL:

Tests

Same as QA

Verify that no errors appear in the JS console

Offline tests

Same as QA

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

Sign in to ND
Tap on Search icon
Verify that search function works normally

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2026-03-20.at.18.05.40.mov

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2026-03-20.at.17.56.59.web.mov

Replace useOptionsList context hook with useFilteredOptions to eliminate unnecessary background recalculations on personal details/reports changes. Key changes: - Replace useOptionsList() with useFilteredOptions({enabled: true}) - Remove OptionsListStateContext dependency - Update cold start telemetry to use isLoading from hook - Add emptyOptionList fallback for null options - Rename listOptions and isLoadingFullData to avoid conflicts Part of OptionListContextProvider removal effort. Fixes Expensify#82187

Use isLoading directly instead of areOptionsInitialized: !isLoading for clearer intent and simpler code in skeleton span attributes.

…-to-usefiltered-options

Related to Expensify#82187

melvin-bot · 2026-03-20T11:17:28Z

@shubham1206agra Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

melvin-bot · 2026-03-20T11:17:33Z

@mountiny Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d749d89e90

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-03-20T11:29:09Z

    const taxRates = getAllTaxRates(policies);

-    const {options, areOptionsInitialized} = useOptionsList();
+    const {options: listOptions, isLoading} = useFilteredOptions({enabled: true, searchTerm: autocompleteQueryValue, betas: betas ?? []});


Debounce searchTerm passed to useFilteredOptions

Passing autocompleteQueryValue directly into useFilteredOptions here causes a full option-list rebuild on every keystroke; useFilteredOptions memoizes on searchTerm and calls createFilteredOptionList whenever it changes (src/hooks/useFilteredOptions.ts, lines 84-95), which reprocesses the reports/personal-details collections. In Search Router this turns normal typing into repeated full-list recomputation for high-traffic accounts, introducing visible input lag/jank compared to the previous flow that reused precomputed options and only filtered them.

Useful? React with 👍 / 👎.

@shubham1206agra, instead of passing searchTerm, should we pass a boolean flag so full option-list won't rebuild on every keystore? Wdyt

@hoangzinh Looks reasonable.

I updated in this commit dbed4dc

Replace searchTerm string parameter with isSearching boolean flag in useFilteredOptions and createFilteredOptionList to prevent full option-list rebuilds on every keystroke. The boolean flag only changes when transitioning between empty/non-empty states, instead of on every character typed. This fixes the P1 performance issue where passing autocompleteQueryValue directly caused visible input lag for high-traffic accounts. Addresses PR review comment #2965259765

trjExpensify · 2026-03-20T14:39:39Z

PR doesn’t need product input as a migration PR. Unassigning and unsubscribing myself.

shubham1206agra · 2026-03-20T14:49:20Z

        enabled: didScreenTransitionEnd,
        betas: betas ?? [],
-        searchTerm: debouncedTextInputValue,
+        isSearching: !!debouncedTextInputValue,


@hoangzinh Please trim the value here

I updated in this commit dbed4dc

Trim debouncedSearchTerm and debouncedTextInputValue before converting to boolean to prevent whitespace-only strings from triggering search mode in NewChatPage and ShareTab. Addresses review feedback from PR Expensify#85922.

codecov · 2026-03-22T15:08:27Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/components/Search/SearchAutocompleteList.tsx	`89.09% <100.00%> (+0.30%)`	⬆️
src/hooks/useFilteredOptions.ts	`77.77% <100.00%> (ø)`
src/libs/OptionsListUtils/index.ts	`83.04% <100.00%> (-0.02%)`	⬇️
src/pages/NewChatPage.tsx	`72.52% <100.00%> (+0.30%)`	⬆️
src/pages/Share/ShareTab.tsx	`0.00% <0.00%> (ø)`
... and 12 files with indirect coverage changes

…-to-usefiltered-options

Whitespace-only input (e.g., ' ') should not trigger search mode. This change makes the isSearching check consistent with other autocompleteQueryValue.trim() checks elsewhere in the component.

…-to-usefiltered-options

…clarity Renamed isLoading from useFilteredOptions to isLoadingOptions to be more specific about what is being loaded. Renamed isLoadingFullData to isLoading since it represents the main loading state that determines whether to show the skeleton view. This improves code readability by making it clear that: - isLoadingOptions: tracks whether filtered options are loading - isLoading: overall loading state (combines options loading + recent searches)

hoangzinh · 2026-03-26T13:06:57Z

@shubham1206agra this PR is ready to review

shubham1206agra · 2026-03-27T13:42:20Z

Sorry @hoangzinh, can you fix conflicts here?

…-to-usefiltered-options

hoangzinh · 2026-03-27T15:00:46Z

@shubham1206agra I fixed conflicts

shubham1206agra · 2026-03-27T17:33:37Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
xIf a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Screen.Recording.2026-03-27.at.10.56.35.PM.mov

…-to-usefiltered-options

The component was refactored to use useFilteredOptions instead of OptionListContextProvider, so the test mock needs to be updated to match the implementation. This fixes the failing test.

hoangzinh · 2026-04-06T09:35:51Z

@mountiny, when you're back. Can you review this PR? TY

hoangzinh · 2026-04-08T13:13:44Z

Go go @mountiny

mountiny

Sorry for the delay, thanks for the PR!

github-actions · 2026-04-10T17:02:10Z

🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-04-10T17:07:35Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #85922.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-b5b383b-74dae60-dcbf40cb32b716e55972a9f2efaec83d0b4919c7/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-b5b383b-74dae60-99de1c88481107ad850719baf73f0e6a853e698e/index.html

Web 🕸️
https://85922.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-04-10T17:12:14Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2026-04-13T20:32:26Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.3.59-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	cancelled 🔪
🍎 iOS 🍎	cancelled 🔪

Bundle Size Analysis (Sentry):

Android

MelvinBot · 2026-04-13T20:33:42Z

No help site changes are required. This PR is an internal refactoring that replaces the useOptionsList context hook with useFilteredOptions — no user-facing behavior, feature names, or UI elements were changed.

OSBotify · 2026-04-16T03:29:05Z

🚀 Deployed to production by https://github.com/AndrewGable in version: 9.3.59-4 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

melvin-bot Bot assigned hoangzinh Mar 20, 2026

hoangzinh added 3 commits March 20, 2026 17:00

refactor(search): simplify reasonAttributes in SearchAutocompleteList

0495434

Use isLoading directly instead of areOptionsInitialized: !isLoading for clearer intent and simpler code in skeleton span attributes.

Merge branch 'main' into feature/82187-migrate-searchautocompletelist…

1742710

…-to-usefiltered-options

refactor(search): pass searchTerm and betas to useFilteredOptions

d749d89

Related to Expensify#82187

hoangzinh marked this pull request as ready for review March 20, 2026 11:17

hoangzinh requested review from a team as code owners March 20, 2026 11:17

melvin-bot Bot requested review from shubham1206agra and removed request for a team March 20, 2026 11:17

melvin-bot Bot requested review from a team, mountiny and trjExpensify and removed request for a team March 20, 2026 11:17

chatgpt-codex-connector Bot reviewed Mar 20, 2026

View reviewed changes

trjExpensify removed their request for review March 20, 2026 14:38

shubham1206agra reviewed Mar 20, 2026

View reviewed changes

Comment thread src/pages/NewChatPage.tsx Outdated

fix: trim search input values before checking if searching

dacff78

Trim debouncedSearchTerm and debouncedTextInputValue before converting to boolean to prevent whitespace-only strings from triggering search mode in NewChatPage and ShareTab. Addresses review feedback from PR Expensify#85922.

hoangzinh mentioned this pull request Mar 24, 2026

[Due for payment 2026-04-30] Migrate MoneyRequestAccountantSelector.tsx from useOptionsList to useFilteredOptions #82190

Closed

hoangzinh added 4 commits March 24, 2026 17:13

Merge branch 'main' into feature/82187-migrate-searchautocompletelist…

6e173d7

…-to-usefiltered-options

fix(Search): trim autocompleteQueryValue in isSearching check

29a2b1f

Whitespace-only input (e.g., ' ') should not trigger search mode. This change makes the isSearching check consistent with other autocompleteQueryValue.trim() checks elsewhere in the component.

Merge branch 'main' into feature/82187-migrate-searchautocompletelist…

aaa9520

…-to-usefiltered-options

hoangzinh added 2 commits March 27, 2026 21:44

Merge branch 'main' into feature/82187-migrate-searchautocompletelist…

3eda3d9

…-to-usefiltered-options

Fix EOL

e9dd0af

shubham1206agra approved these changes Mar 27, 2026

View reviewed changes

hoangzinh added 2 commits April 5, 2026 21:02

Merge branch 'main' into feature/82187-migrate-searchautocompletelist…

82c1fe3

…-to-usefiltered-options

test(SearchAutocompleteList): update mock to use useFilteredOptions hook

2ca574d

The component was refactored to use useFilteredOptions instead of OptionListContextProvider, so the test mock needs to be updated to match the implementation. This fixes the failing test.

mountiny approved these changes Apr 10, 2026

View reviewed changes

mountiny merged commit b5b383b into Expensify:main Apr 10, 2026
31 checks passed

OSBotify mentioned this pull request Apr 13, 2026

Deploy Checklist: New Expensify 2026-04-13 #87792

Closed

89 tasks

melvin-bot Bot mentioned this pull request Apr 16, 2026

[Due for payment 2026-04-23] Migrate SearchAutocompleteList.tsx from useOptionsList to useFilteredOptions #82187

Closed

mukhrr mentioned this pull request Jun 29, 2026

[Due for payment 2026-07-17] [$250] Recent chats on fresh sign-in: known DMs missing while old/never-contacted chats appear #94800

Open

Uh oh!

Conversation

hoangzinh commented Mar 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Mar 20, 2026

Uh oh!

melvin-bot Bot commented Mar 20, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Mar 20, 2026

Choose a reason for hiding this comment

Uh oh!

hoangzinh Mar 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

shubham1206agra Mar 20, 2026

Choose a reason for hiding this comment

Uh oh!

hoangzinh Mar 20, 2026

Choose a reason for hiding this comment

Uh oh!

trjExpensify commented Mar 20, 2026

Uh oh!

shubham1206agra Mar 20, 2026

Choose a reason for hiding this comment

Uh oh!

hoangzinh Mar 23, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

codecov Bot commented Mar 22, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

hoangzinh commented Mar 26, 2026

Uh oh!

shubham1206agra commented Mar 27, 2026

Uh oh!

hoangzinh commented Mar 27, 2026

Uh oh!

shubham1206agra commented Mar 27, 2026

Reviewer Checklist

Screenshots/Videos

Uh oh!

hoangzinh commented Apr 6, 2026

Uh oh!

hoangzinh commented Apr 8, 2026

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions Bot commented Apr 10, 2026

Uh oh!

github-actions Bot commented Apr 10, 2026

Uh oh!

OSBotify commented Apr 10, 2026

Uh oh!

OSBotify commented Apr 13, 2026

Uh oh!

MelvinBot commented Apr 13, 2026

Uh oh!

OSBotify commented Apr 16, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

hoangzinh commented Mar 20, 2026 •

edited

Loading

hoangzinh Mar 20, 2026 •

edited

Loading

codecov Bot commented Mar 22, 2026 •

edited by github-actions Bot

Loading