Skip to content

Add hasFailedOnfido to acceptWalletTerms failureData #85579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Valforte merged 3 commits into from
Apr 6, 2026
Merged

Add hasFailedOnfido to acceptWalletTerms failureData #85579

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
75af8dc
Add hasFailedOnfido to acceptWalletTerms failureData
allgandalf Mar 17, 2026
c690725
Merge branch 'Expensify:main' into add-hasFailedOnfido-to-failureData
allgandalf Mar 20, 2026
c2fe187
Merge branch 'Expensify:main' into add-hasFailedOnfido-to-failureData
allgandalf Apr 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/libs/actions/Wallet.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,6 +178,7 @@ function acceptWalletTerms(parameters: AcceptWalletTermsParams) {
value: {
isPendingOnfidoResult: null,
shouldShowFailedKYC: true,
hasFailedOnfido: true,
Comment thread
allgandalf marked this conversation as resolved.

@chatgpt-codex-connector chatgpt-codex-connector Bot Mar 20, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Keep hasFailedOnfido in a server-synced update path

This makes the failed-KYC marker local to the client that submitted AcceptWalletTerms. request.failureData is only applied in applyHTTPSOnyxUpdates() for the originating request (src/libs/actions/OnyxUpdates.ts), but both src/pages/EnablePayments/EnablePaymentsPage.tsx and src/pages/settings/Wallet/WalletPage/index.tsx use userWallet.hasFailedOnfido to block/relabel the wallet flow. Because this change is replacing the removed backend push, another logged-in device/session for the same account will never receive the failure state and can still show the normal “Enable wallet” path after KYC has already failed.

Useful? React with 👍 / 👎.

@allgandalf allgandalf Mar 20, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmmm @Valforte , I think this does make sense , should we push the update in Auth ?

@Valforte Valforte Mar 20, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah it should have a push in the backend so all devices are updated. Can you work on it as a follow up?

@Valforte Valforte Mar 20, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually I see it should be done in Auth instead of this PR. What's your thought?

@allgandalf allgandalf Mar 20, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

YEahh ,i agree the update should be sent in auth it makes more sense !, I'll raise a follow up on monday

@allgandalf allgandalf Mar 20, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets put this PR on hold, i don't think we would need this PR really after we merge the auth one

},
},
{
Expand Down
Loading