Fix: Prevent users from signing up with ineligible TLD by nyomanjyotisa · Pull Request #84842 · Expensify/App

nyomanjyotisa · 2026-03-11T06:41:18Z

Explanation of Change

Prevent users from signing up with invalid TLD (Top-Level Domain) by validating the TLD using VALID_TLD_REGEX, so emails like user@gmail.con are rejected

Fixed Issues

$ #84619
PROPOSAL: #84619 (comment)

Tests

Same as QA Steps

Verify that no errors appear in the JS console

Offline tests

Same as QA Steps

QA Steps

Open the login page
Enter an email address with an incorrect or ineligible TLD, e.g., user@gmail.con
Click Continue
Verify that a validation error is displayed, preventing account creation with an incorrect or ineligible TLD

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android-Native.mp4

Android: mWeb Chrome

Android-mWeb.Chrome.mp4

iOS: Native

iOS-Native.mp4

iOS: mWeb Safari

iOS-mWeb.Safari.mp4

MacOS: Chrome / Safari

MacOS-Chrome.mp4

codecov · 2026-03-11T06:48:11Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/libs/ValidationUtils.ts	`51.77% <88.88%> (+1.11%)`	⬆️
src/pages/signin/LoginForm/BaseLoginForm.tsx	`42.14% <0.00%> (ø)`
... and 8 files with indirect coverage changes

melvin-bot · 2026-03-11T07:30:22Z

@bernhardoj Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 3b8cbd2e41

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-03-11T07:38:21Z

            const parsedPhoneNumber = parsePhoneNumber(phoneLogin);

-            if (!Str.isValidEmail(loginTrim) && !parsedPhoneNumber.possible) {
+            if (!isValidEmailWithTLD(loginTrim) && !parsedPhoneNumber.possible) {


Allow legacy non-IANA email accounts to sign in

This validation now runs before every beginSignIn call on the shared login/signup form, so any pre-existing account whose email uses a TLD that is no longer accepted (for example, accounts created before this fix with .con) is blocked client-side and can never request a sign-in code. That makes this a sign-in regression whenever such legacy accounts exist, so the stricter TLD check should be limited to account-creation flow (or applied after backend account-existence checks) rather than unconditional login validation.

Useful? React with 👍 / 👎.

@bernhardoj Do you think we should consider this concern? The SignUpUser API already handles the invalid TLD case, so I'm not sure whether an account with an invalid TLD could exist in the first place

MacOS-Chrome-2.mp4

Alternatively, we could show the error immediately after clicking the Continue button and disable the Join button afterwards

MacOS-Chrome.mp4

Let me know what you think

Oh, I just noticed the BE now returns the error and is shown on the sign-up page.

@fukawi2 I think we don't need FE validation then?

@joekaufmanexpensify

Page 1 Page 2
[login input] => (Join)

When we press Join, BE already returns the error that the email domain is invalid. This PR adds a FE validation on the 1st page that prevents the user to go next if the email domain is invalid. Do we need the FE validation?

cc: @fukawi2

Bumped on Slack, if I'm not hearing anything, we can proceed with this.

Responded in slack to align more quickly there

joekaufmanexpensify

Good for product

bernhardoj · 2026-03-25T01:10:47Z

@nyomanjyotisa please merge with main and fix the conflict

nyomanjyotisa · 2026-03-25T09:48:59Z

@bernhardoj Sure, I've updated the PR

bernhardoj · 2026-03-25T14:18:11Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

web.mp4

OSBotify · 2026-03-25T19:14:29Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2026-03-25T19:51:42Z

🚧 @luacmartins has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-03-25T19:56:52Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #84842.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-fd728c8-38a1277-e7603687eb60242bee00acd9fde19997a67fe0fc/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-fd728c8-38a1277-0e7f1dfe412305f514c8c4f574105420eaa3beb7/index.html

Web 🕸️
https://84842.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-03-26T14:42:17Z

🚀 Deployed to staging by https://github.com/luacmartins in version: 9.3.49-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

OSBotify · 2026-03-27T12:24:25Z

🚀 Deployed to production by https://github.com/grgia in version: 9.3.49-2 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Fix: Prevent users from signing up with ineligible TLD

f56c4af

melvin-bot Bot assigned nyomanjyotisa Mar 11, 2026

lint fix

cbb4aea

test: add unit tests for ViolationsUtils

3b8cbd2

nyomanjyotisa marked this pull request as ready for review March 11, 2026 07:30

nyomanjyotisa requested review from a team as code owners March 11, 2026 07:30

melvin-bot Bot requested review from bernhardoj and removed request for a team March 11, 2026 07:30

melvin-bot Bot requested review from joekaufmanexpensify and removed request for a team March 11, 2026 07:30

chatgpt-codex-connector Bot reviewed Mar 11, 2026

View reviewed changes

joekaufmanexpensify previously approved these changes Mar 11, 2026

View reviewed changes

Merge branch 'main' into issue-84619

fb9476d

nyomanjyotisa dismissed joekaufmanexpensify’s stale review via fb9476d March 25, 2026 09:47

bernhardoj approved these changes Mar 25, 2026

View reviewed changes

melvin-bot Bot requested a review from luacmartins March 25, 2026 14:31

luacmartins approved these changes Mar 25, 2026

View reviewed changes

luacmartins merged commit fd728c8 into Expensify:main Mar 25, 2026
32 of 33 checks passed

OSBotify mentioned this pull request Mar 26, 2026

Deploy Checklist: New Expensify 2026-03-26 #86439

Closed

29 tasks

melvin-bot Bot mentioned this pull request Mar 27, 2026

[Due for payment 2026-04-03] [$250] User can sign up with an ineligible email (e.g., user@gnail.com) #84619

Closed

7 tasks

Uh oh!

Conversation

nyomanjyotisa commented Mar 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov Bot commented Mar 11, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

melvin-bot Bot commented Mar 11, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Mar 11, 2026

Choose a reason for hiding this comment

Uh oh!

nyomanjyotisa Mar 11, 2026

Choose a reason for hiding this comment

Uh oh!

bernhardoj Mar 11, 2026

Choose a reason for hiding this comment

Uh oh!

bernhardoj Mar 17, 2026

Choose a reason for hiding this comment

Uh oh!

bernhardoj Mar 23, 2026

Choose a reason for hiding this comment

Uh oh!

joekaufmanexpensify Mar 23, 2026

Choose a reason for hiding this comment

Uh oh!

joekaufmanexpensify left a comment

Choose a reason for hiding this comment

Uh oh!

bernhardoj commented Mar 25, 2026

Uh oh!

nyomanjyotisa commented Mar 25, 2026

Uh oh!

bernhardoj commented Mar 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

Uh oh!

OSBotify commented Mar 25, 2026

Uh oh!

github-actions Bot commented Mar 25, 2026

Uh oh!

github-actions Bot commented Mar 25, 2026

Uh oh!

OSBotify commented Mar 26, 2026

Uh oh!

OSBotify commented Mar 27, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

nyomanjyotisa commented Mar 11, 2026 •

edited

Loading

codecov Bot commented Mar 11, 2026 •

edited by github-actions Bot

Loading

bernhardoj commented Mar 25, 2026 •

edited

Loading