Skip to content

Remove Inbox from preloaded navigators to prevent CPU spike on web #84025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mountiny merged 4 commits into from
Mar 4, 2026
Merged

Remove Inbox from preloaded navigators to prevent CPU spike on web #84025

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3c3bf8e
remove Inbox from preloaded screens
TMisiukiewicz Mar 3, 2026
9e41c1a
Merge remote-tracking branch 'origin/main' into perf/remove-inbox-fro…
TMisiukiewicz Mar 3, 2026
a889052
Merge remote-tracking branch 'origin/main' into perf/remove-inbox-fro…
TMisiukiewicz Mar 4, 2026
bc5e14c
update comment
TMisiukiewicz Mar 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/libs/Navigation/AppNavigator/usePreloadFullScreenNavigators.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,8 @@ import {getPreservedNavigatorState} from './createSplitNavigator/usePreserveNavi
// This timing is used to call the preload function after a tab change, when the initial tab screen has already been rendered.
const TIMING_TO_CALL_PRELOAD = 1000;

// Currently the Inbox, Workspaces and Account tabs are preloaded, while Search is not preloaded due to its potential complexity.
const TABS_TO_PRELOAD = [NAVIGATION_TABS.INBOX, NAVIGATION_TABS.WORKSPACES, NAVIGATION_TABS.SETTINGS];
// Currently the Workspaces and Account tabs are preloaded, while Search and Inbox are not preloaded due to their potential complexity.
const TABS_TO_PRELOAD = [NAVIGATION_TABS.WORKSPACES, NAVIGATION_TABS.SETTINGS];

@hungvu193 hungvu193 Mar 3, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can see CPU usage deceases significantly, so 💯 to this change.

But since the most heavy tab is removed from preload tab, I wonder if we really need to preload WORKSPACES and SETTINGS tabs since they're lightweight and most of their data needed for displaying the UI of these two page come from OpenApp.

I tried to remove usePreloadFullScreenNavigators and I don't see different while switching between these tab. Do you have any metric for the usePreloadFullScreenNavigators? And what kind of data did you measured?

@TMisiukiewicz TMisiukiewicz Mar 4, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hungvu193 while I do not see much difference on Web, I can see preloading of Workspaces and Setting screens bringing good results on mobile - results when navigating from Home to Workspaces on iOS without preloading:

🔴 Duration Diff: 680.679 ms (+332.8%)
🔴 Commit Count Diff: 12

@hungvu193 hungvu193 Mar 4, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TMisiukiewicz Do you think we still need this preload logic on web at all?

@TMisiukiewicz TMisiukiewicz Mar 4, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hungvu193 please check this comment. I believe keeping the preloading on web makes sense for both Settings and Workspaces


function preloadWorkspacesTab(navigation: PlatformStackNavigationProp<AuthScreensParamList>) {
const state = getWorkspacesTabStateFromSessionStorage() ?? navigation.getState();
Expand Down
Loading