Defer `SearchAutocompleteList` render in `SearchRouter` on native mobile until navigation triggers by JakubKorytko · Pull Request #83607 · Expensify/App

JakubKorytko · 2026-02-26T18:33:31Z

Explanation of Change

The main problem with SearchAutocompleteList is that it only loads the data on the initial render. This seems OK at first, but it disables the skeleton in subsequent renders. Furthermore, the skeleton is positioned too low in the tree, meaning that all the logic is fired at once, before RHP has even begun to render.
Changed that in this PR and it leads to a persistent smooth navigation.

Fixed Issues

$ #79353
PROPOSAL: N/A

Tests

[Native mobile]

Open Expensify app
Open the search router (tap the search button)
Verify that you see the loading skeleton
Verify the autocomplete list renders correctly with recent searches and recent chats
Type filter prefixes (tag:, category:, from:, currency:, type:, status:) and verify suggestions appear
Select suggestions and verify they are applied to the search query

Select any item from the list (on any step) and verify that you are correctly navigated.
Select any recent search and verify that it works

Offline tests

N/A

QA Steps

Same as tests

PR Author Checklist

Screenshots/Videos

Android: Native

Android.mp4

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

codecov · 2026-02-26T19:32:57Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/CONST/index.ts	`94.30% <ø> (ø)`
src/components/OptionsListSkeletonView.tsx	`100.00% <100.00%> (ø)`
src/components/Search/SearchAutocompleteList.tsx	`51.51% <ø> (ø)`
...rc/components/Search/SearchRouter/SearchButton.tsx	`100.00% <ø> (ø)`
...onents/Search/SearchRouter/SearchRouterContext.tsx	`55.17% <ø> (ø)`
src/components/Skeletons/ItemListSkeletonView.tsx	`90.47% <ø> (ø)`
...rc/components/Search/SearchRouter/SearchRouter.tsx	`0.00% <0.00%> (ø)`
...h/SearchRouter/startSearchPageVisibleSpan/index.ts	`0.00% <0.00%> (ø)`
...hRouter/startSearchPageVisibleSpan/index.native.ts	`0.00% <0.00%> (ø)`
...ch/DeferredSearchAutocompleteList/index.native.tsx	`0.00% <0.00%> (ø)`
... and 33 files with indirect coverage changes

JakubKorytko · 2026-02-27T15:18:43Z

Codecov is wrong. The only change in the skeleton is the onLayout prop, which is native, so we shouldn't add tests for it.

melvin-bot · 2026-02-27T15:22:42Z

@aimane-chnaif Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

chatgpt-codex-connector · 2026-02-27T17:26:36Z

Codex Review: Didn't find any major issues. Already looking forward to the next diff.

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

aimane-chnaif · 2026-02-28T08:41:34Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

before:

Screen.Recording.2026-02-28.at.8.59.24.am.mov

after:

Screen.Recording.2026-02-28.at.8.54.59.am.mov

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2026-02-28.at.8.56.00.am.mov

aimane-chnaif

Can we have performance measurement on native?

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6d36992f19

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

JmillsExpensify

Testing steps look good and in line with intended product behavior.

JakubKorytko · 2026-03-02T16:26:36Z

Can we have performance measurement on native?

Will add one tomorrow!

JakubKorytko · 2026-03-03T18:41:46Z

I added a new telemetry span (SPAN_SEARCH_PAGE_VISIBLE - ManualOpenSearchRouterPageVisible) to measure time from pressing the search button until the search page is visible (including the skeleton). Opening search on native was slow, so I deferred the full list and show a skeleton first, which makes the page feel faster. The existing metric still measures until the full list is ready, so it can look slower or misleading. This new span measures "time to first paint" (button press -> page visible) so we can track perceived open speed on native.

The gain based on this metric is ~218.20 ms

This branch: ~531.00 ms

A few example runs

Duration (ms)

378.34
438.07
637.20
577.46
477.90

Main: ~749.20 ms

A few example runs

Duration (ms)

816.41
677.02
816.41
756.67
816.41

mountiny · 2026-03-03T23:33:58Z

@aimane-chnaif can you please complete the review

aimane-chnaif · 2026-03-05T08:26:34Z

@JakubKorytko please fix conflict

chatgpt-codex-connector · 2026-03-05T08:46:59Z

Codex Review: Didn't find any major issues. 🎉

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

JakubKorytko · 2026-03-05T09:13:22Z

Conflicts fixed! @aimane-chnaif

aimane-chnaif

#83607 (comment)
Otherwise looks good.

chatgpt-codex-connector · 2026-03-05T16:53:15Z

Codex Review: Didn't find any major issues. Another round soon, please!

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

mountiny

LGTM

github-actions · 2026-03-06T20:13:50Z

🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-03-06T20:18:26Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #83607.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-e7d9670-ff7dc59-4a8078910aef91280d4cd4be1030103086496e24/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-e7d9670-ff7dc59-bfafa66fd88316866fec23522be2ec10513fb949/index.html

Web 🕸️
https://83607.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-03-06T20:20:26Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2026-03-06T23:02:32Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.3.33-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	failure ❌

OSBotify · 2026-03-09T20:37:48Z

🚀 Deployed to production by https://github.com/luacmartins in version: 9.3.33-5 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

melvin-bot Bot assigned JakubKorytko Feb 26, 2026

mountiny self-requested a review February 26, 2026 20:35

JakubKorytko added 4 commits February 27, 2026 15:57

perf: delay render of selection list inside search autocomplete

a26f836

refactor: convert hook to a wrapper

04f39db

refactor: get rid of deferred value

6ea39a0

refactor: use skeleton onLayout to render search autocomplete list

26f8714

JakubKorytko force-pushed the korytko/perf/search-autocomplete-list branch from fb9ace7 to 26f8714 Compare February 27, 2026 15:03

JakubKorytko changed the title ~~[WIP] Render list inside SearchAutocompleteList after navigation triggers~~ Render list inside SearchAutocompleteList after navigation triggers Feb 27, 2026

JakubKorytko changed the title ~~Render list inside SearchAutocompleteList after navigation triggers~~ Defer SearchAutocompleteList render in SearchRouter until navigation triggers Feb 27, 2026

JakubKorytko changed the title ~~Defer SearchAutocompleteList render in SearchRouter until navigation triggers~~ Defer SearchAutocompleteList render in SearchRouter on native mobile until navigation triggers Feb 27, 2026

JakubKorytko marked this pull request as ready for review February 27, 2026 15:22

JakubKorytko requested review from a team as code owners February 27, 2026 15:22

melvin-bot Bot requested review from JmillsExpensify and aimane-chnaif and removed request for a team February 27, 2026 15:22

melvin-bot Bot removed the request for review from a team February 27, 2026 15:22

github-actions Bot reviewed Feb 27, 2026

View reviewed changes

Comment thread src/components/Search/DeferredSearchAutocompleteList/index.native.tsx Outdated

explain eslint-disable comment

6d36992

aimane-chnaif reviewed Feb 28, 2026

View reviewed changes

Comment thread src/components/Search/SearchAutocompleteList.tsx

Comment thread src/components/Search/SearchAutocompleteList.tsx Outdated

chatgpt-codex-connector Bot reviewed Feb 28, 2026

View reviewed changes

Comment thread src/components/Search/SearchAutocompleteList.tsx Outdated

JmillsExpensify previously approved these changes Feb 28, 2026

View reviewed changes

JakubKorytko added 2 commits March 2, 2026 17:08

add skeleton back to SearchAutocompleteList

2c96975

Merge branch 'main' into korytko/perf/search-autocomplete-list

55230ae

JakubKorytko dismissed JmillsExpensify’s stale review via 55230ae March 2, 2026 16:11

JakubKorytko added 2 commits March 3, 2026 18:46

Merge branch 'main' into korytko/perf/search-autocomplete-list

0290328

add ManualOpenSearchRouterPageVisible metric

e82d10c

Merge branch 'main' into korytko/perf/search-autocomplete-list

34264d6

aimane-chnaif reviewed Mar 5, 2026

View reviewed changes

Comment thread src/components/Search/SearchRouter/SearchButton.tsx Outdated

aimane-chnaif approved these changes Mar 5, 2026

View reviewed changes

mountiny requested changes Mar 5, 2026

View reviewed changes

Comment thread src/components/Search/SearchRouter/SearchButton.tsx Outdated

JakubKorytko added 2 commits March 6, 2026 13:45

Merge branch 'main' into korytko/perf/search-autocomplete-list

e783d95

remove getPlatform from SearchButton

88a29c7

JakubKorytko requested a review from mountiny March 6, 2026 13:05

mountiny approved these changes Mar 6, 2026

View reviewed changes

mountiny merged commit e7d9670 into Expensify:main Mar 6, 2026
30 checks passed

OSBotify mentioned this pull request Mar 6, 2026

Deploy Checklist: New Expensify 2026-03-06 #84466

Closed

52 tasks

melvin-bot Bot mentioned this pull request Mar 9, 2026

[Due for payment 2026-07-13] [Metrics] Improve ManualOpenSearchRouter time performance #79353

Open

Uh oh!

Conversation

JakubKorytko commented Feb 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov Bot commented Feb 26, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

JakubKorytko commented Feb 27, 2026

Uh oh!

melvin-bot Bot commented Feb 27, 2026

Uh oh!

Uh oh!

chatgpt-codex-connector Bot commented Feb 27, 2026

Uh oh!

aimane-chnaif commented Feb 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

aimane-chnaif left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

JmillsExpensify left a comment

Choose a reason for hiding this comment

Uh oh!

JakubKorytko commented Mar 2, 2026

Uh oh!

JakubKorytko commented Mar 3, 2026

Uh oh!

mountiny commented Mar 3, 2026

Uh oh!

aimane-chnaif commented Mar 5, 2026

Uh oh!

chatgpt-codex-connector Bot commented Mar 5, 2026

Uh oh!

JakubKorytko commented Mar 5, 2026

Uh oh!

Uh oh!

aimane-chnaif left a comment

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector Bot commented Mar 5, 2026

Uh oh!

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions Bot commented Mar 6, 2026

Uh oh!

github-actions Bot commented Mar 6, 2026

Uh oh!

OSBotify commented Mar 6, 2026

Uh oh!

OSBotify commented Mar 6, 2026

Uh oh!

OSBotify commented Mar 9, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

JakubKorytko commented Feb 26, 2026 •

edited

Loading

codecov Bot commented Feb 26, 2026 •

edited by github-actions Bot

Loading

aimane-chnaif commented Feb 28, 2026 •

edited

Loading