[CP Staging] Fix split issues with unit and zero distance by ZhenjaHorbach · Pull Request #83493 · Expensify/App

ZhenjaHorbach · 2026-02-25T21:25:21Z

Explanation of Change

Fixed Issues

$ #83485
$ #83487
$ #83535
$ #83518
$ #83564
PROPOSAL:

Tests

Open App
Create a workspace.
Go to workspace settings > More features.
Enable Distance rates.
Go to workspace settings > Distance rates.
Click Settings > Unit > change to Kilometers.
Go to workspace chat.
Create a manual distance expense.
Open the expense.
Click More > Split.
Click any split row.
Verify that distance and Rate row will show kilometers because distance unit is changed to kilometers in Step 6.

Open App
Go to workspace chat.
Create a manual distance expense.
Open the expense.
Click More > Split.
Click Add split.
Change the split amount to 0.
Verify that Split row will show 0.00 mi @ RM0.725 / mile.

Open App
Go to workspace chat.
Create a manual distance expense.
Open the expense.
Click More > Split.
Open any split row.
Click Distance.
Edit the distance and click Save.
Verify that RHP header will show updated amount and distance.

Open App
Open any workspace chat.
Create a map distance expense.
Open the report of the just created expense.
Tap on "More" > "Split"
Long tap and select one of the splits.
Tap on dropdown menu and delete it.
Note that when landing on report with remaining split, map is not visible and app keeps loading.
Return to chat.
Note that after app finishes loading, deleted split appears briefly and an "Unexpected error" message appears on remaining split.
Reopen report and dismiss the error.
Note that you land on chat and both splits disappeared.
Return to "Inbox" and reopen chat.
Verify that after splitting a distance expense and deleting one split, user should land on report again, where remaining split information and map should be displayed correctly.

Go to staging.new.expensify.com
Go to workspace chat.
Create a manual distance expense.
Open the expense.
Click More > Split > Save.
Open any split.
Click Report > Create report.
On the current report, click Submit and Approve.
Go to workspace settings > Distance rates.
Delete the distance rate used in Step 3.
Open the expense report containing split in the new report (from Step 7).
Click Amount.
Click on the highlighted row.
Click Rate > select other rate > Save.
Click Save.
Verify that the user should be able to save the split because user has changed the split rate to valid rate in Step 14.

Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

melvin-bot · 2026-02-25T21:39:24Z

@mananjadhav Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

codecov · 2026-02-26T08:33:53Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/libs/DistanceRequestUtils.ts	`84.05% <100.00%> (-0.73%)`	⬇️
src/libs/actions/IOU/Split.ts	`77.73% <100.00%> (ø)`
src/pages/iou/SplitExpenseEditPage.tsx	`0.00% <0.00%> (ø)`
src/pages/iou/SplitExpensePage.tsx	`0.00% <0.00%> (ø)`
... and 79 files with indirect coverage changes

suneox · 2026-02-26T15:01:24Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Uploading CleanShot 2026-02-26 at 23.19.54 9.mp4…

CleanShot.2026-02-26.at.23.10.01.8.mp4

Android: mWeb Chrome

CleanShot.2026-02-26.at.23.08.27.7.mp4

iOS: HybridApp

CleanShot.2026-02-26.at.23.06.41.5.mp4

iOS: mWeb Safari

CleanShot.2026-02-26.at.23.07.28.6.mp4

MacOS: Chrome / Safari

83564.mp4

83485.1.mp4

83487.2.mp4

83535.3.mp4

83564.4.mp4

suneox

The current change set to fix the following issues LGTM
#83485
#83487
#83535
#83518

Except for #83564, which isn’t fixed. Since it also occurs on the latest main so I think we can open another PR to handle that issue

83564

CleanShot.2026-02-26.at.23.34.39.1.mp4

ZhenjaHorbach · 2026-02-26T16:50:14Z

The current change set to fix the following issues LGTM #83485 #83487 #83535 #83518

Except for #83564, which isn’t fixed. Since it also occurs on the latest main so I think we can open another PR to handle that issue

83564
CleanShot.2026-02-26.at.23.34.39.1.mp4

Weird
Let me check the last issue for a second

ZhenjaHorbach · 2026-02-26T16:59:40Z

The current change set to fix the following issues LGTM #83485 #83487 #83535 #83518
Except for #83564, which isn’t fixed. Since it also occurs on the latest main so I think we can open another PR to handle that issue
83564
CleanShot.2026-02-26.at.23.34.39.1.mp4

Weird Let me check the last issue for a second

It's fixed for me (issue in the description)

2026-02-26.18.02.29.mov

But we have a BE issue also
That we can't modify the rate for approved expenses
As result, BE return error for this expense
I suppose we need to prevent this error from BE side for approved expenses

CC: @lakchote

But since we have the same issue on prod
Then okay

We can move on!

lakchote

LGTM

…it-and-zero-distance [CP Staging] Fix split issues with unit and zero distance (cherry picked from commit 295d66e) (cherry-picked to staging by puneetlath)

OSBotify · 2026-02-26T17:38:43Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2026-02-26T17:47:14Z

🚧 @lakchote has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-02-26T17:51:48Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #83493.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-295d66e-b8486d2-ce46ef4a09dbc9ee65addd0a9c8d60051ce0c753/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-295d66e-b8486d2-3150c48eff3814262cc21c58963c8a2946985a83/index.html

Web 🕸️
https://83493.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-02-26T18:13:21Z

🚀 Cherry-picked to staging by https://github.com/puneetlath in version: 9.3.26-6 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-02-27T15:00:06Z

🚀 Deployed to production by https://github.com/puneetlath in version: 9.3.26-8 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-02-27T15:28:20Z

🚀 Cherry-picked to staging by https://github.com/puneetlath in version: 9.3.27-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-03-02T22:19:40Z

🚀 Deployed to production by https://github.com/blimpich in version: 9.3.27-8 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Fix split issues with unit and zero distance

df79744

melvin-bot Bot assigned ZhenjaHorbach Feb 25, 2026

ZhenjaHorbach marked this pull request as ready for review February 25, 2026 21:39

ZhenjaHorbach requested review from a team as code owners February 25, 2026 21:39

melvin-bot Bot requested review from JmillsExpensify and mananjadhav and removed request for a team February 25, 2026 21:39

melvin-bot Bot removed request for a team and JmillsExpensify February 25, 2026 21:39

lakchote requested review from lakchote and suneox and removed request for mananjadhav February 26, 2026 05:49

Add few fixes

e6965d5

Revert a fix

98cf7a2

ZhenjaHorbach mentioned this pull request Feb 26, 2026

[$250] Split distance - RHP header shows updated amount with old distance after changing distance #83535

Closed

7 tasks

ZhenjaHorbach added 2 commits February 26, 2026 13:52

Fix issue with non editable splits

a73ca78

Fix prettier issue

272b5f6

lakchote changed the title ~~Fix split issues with unit and zero distance~~ [CP Staging] Fix split issues with unit and zero distance Feb 26, 2026

suneox mentioned this pull request Feb 26, 2026

[$250] Distance - "Please fix the distance rate error" appears when approved split cannot be edited #83564

Closed

7 tasks

suneox approved these changes Feb 26, 2026

View reviewed changes

lakchote approved these changes Feb 26, 2026

View reviewed changes

lakchote merged commit 295d66e into Expensify:main Feb 26, 2026
33 checks passed

OSBotify added the CP Staging marks PRs that have been CP'd to staging label Feb 26, 2026

OSBotify mentioned this pull request Feb 26, 2026

Deploy Checklist: New Expensify 2026-02-25 #83466

Closed

Uh oh!

Conversation

ZhenjaHorbach commented Feb 25, 2026 • edited by lakchote Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Feb 25, 2026

Uh oh!

codecov Bot commented Feb 26, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

suneox commented Feb 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

suneox left a comment

Choose a reason for hiding this comment

Uh oh!

ZhenjaHorbach commented Feb 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ZhenjaHorbach commented Feb 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lakchote left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Feb 26, 2026

Uh oh!

github-actions Bot commented Feb 26, 2026

Uh oh!

github-actions Bot commented Feb 26, 2026

Uh oh!

OSBotify commented Feb 26, 2026

Uh oh!

OSBotify commented Feb 27, 2026

Uh oh!

OSBotify commented Feb 27, 2026

Uh oh!

OSBotify commented Mar 2, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

ZhenjaHorbach commented Feb 25, 2026 •

edited by lakchote

Loading

codecov Bot commented Feb 26, 2026 •

edited by github-actions Bot

Loading

suneox commented Feb 26, 2026 •

edited

Loading

ZhenjaHorbach commented Feb 26, 2026 •

edited

Loading

ZhenjaHorbach commented Feb 26, 2026 •

edited

Loading