Decompose Expensify.tsx from delegate access, Fullstory init, screen share and priority mode by adhorodyski · Pull Request #83307 · Expensify/App

adhorodyski · 2026-02-24T09:32:09Z

Explanation of Change

TLDR: this change improves React rendering at the root of the app by ~5%, making eg. report opening faster.
Tests I conducted: refreshed the app (from scratch) while on the same report.

This PR reduces root-level Onyx subscriptions in Expensify.tsx from 14 down to 6 by extracting 8 subscriptions into three isolated renderless components. Previously, every change to keys like ACCOUNT, USER_METADATA, or SCREEN_SHARE_REQUEST would cause a full re-render of the root Expensify component — including the entire navigation tree (NavigationRoot). By moving these subscriptions into dedicated components, their state changes are now scoped and do not bubble up to trigger unnecessary re-renders of the navigation tree.

Three new renderless components were created:

src/DelegateAccessHandler.tsx — Owns 5 subscriptions (ACCOUNT, STASHED_CREDENTIALS, STASHED_SESSION, HAS_LOADED_APP, IS_LOADING_APP) plus the delegate disconnect/mismatch logging and isLoadingApp recovery effects that previously lived in Expensify.tsx.
src/FullstoryInitHandler.tsx — Owns the USER_METADATA subscription and handles Fullstory initialization and Sentry context setting.
src/components/ScreenShareRequestModal.tsx — Owns the SCREEN_SHARE_REQUEST subscription and renders the ConfirmModal for screen-share requests from GuidesPlus agents.
src/PriorityModeHandler.tsx — Decompose Expensify.tsx: extract PriorityModeHandler.

Expensify.tsx was updated to use a narrowed accountIDSelector on SESSION (instead of subscribing to the full session object), remove all moved subscriptions, remove useNetwork(), drop now-unused imports, and clean up the propsToLog object and ExpensifyProps type.

This follows the same pattern as the prior DeepLinkHandler extraction, which demonstrated a 10–35% render performance improvement.

trace-report.txt

before:

after:

Fixed Issues

$ #74367
$ #77173
$ #84149
PROPOSAL:

Tests

Open up EApp.
Validate that Fullstory still initiates correctly.
Validate that DelegateAccess still works.
Validate that the ScreenShareRequestModal opens up correctly with a guide request.
Validate that changing priority mode calls openApp.

Offline tests

N/A

QA Steps

Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

…Handler, ScreenShareRequestModal

codecov · 2026-02-24T09:40:18Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/Expensify.tsx	`88.79% <100.00%> (+4.94%)`	⬆️
src/FullstoryInitHandler.tsx	`100.00% <100.00%> (ø)`
src/PriorityModeHandler.tsx	`100.00% <ø> (ø)`
src/hooks/useIsAuthenticated.tsx	`100.00% <100.00%> (ø)`
src/selectors/Session.ts	`100.00% <100.00%> (ø)`
src/DelegateAccessHandler.tsx	`94.11% <94.11%> (ø)`
src/components/ScreenShareRequestModal.tsx	`14.28% <14.28%> (ø)`
... and 8 files with indirect coverage changes

@userActions

Replace `import * as User` with named imports to comply with the no-restricted-syntax rule for @userActions. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

adhorodyski · 2026-02-24T10:50:41Z


            if (splashScreenState === CONST.BOOT_SPLASH_STATE.VISIBLE) {
-                const propsToLog: Omit<ExpensifyProps & {isAuthenticated: boolean}, 'children' | 'session'> = {
+                const propsToLog = {


I highly doubt this is useful to anyone. We can completely remove it or accept this strip.

melvin-bot · 2026-02-24T10:51:12Z

@Krishna2323 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

melvin-bot · 2026-02-24T10:51:17Z

@suneox @Julesssss One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Krishna2323 · 2026-02-24T10:52:38Z

Will be reviewing this in 30mins.

Krishna2323 · 2026-02-24T11:15:20Z

Reviewing...

Isolate NVP_PRIORITY_MODE and COLLECTION.REPORT_DRAFT_COMMENT Onyx subscriptions into a render-null handler component so changes to these keys no longer re-render the entire Expensify component tree. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Krishna2323 · 2026-02-24T11:38:25Z

-    const [account] = useOnyx(ONYXKEYS.ACCOUNT);
-    const [session] = useOnyx(ONYXKEYS.SESSION);
+    const {preferredLocale} = useLocalize();
+    const [accountID] = useOnyx(ONYXKEYS.SESSION, {selector: accountIDSelector});


We are now using selector for accountID but the component uses useIsAuthenticated on line 121 which subscribes to the full SESSION object. We can update useIsAuthenticated to use a selector (e.g., session?.authToken) so this component only re-renders when authToken actually changes.

This isn't something introduced by this PR, but it's a missed opportunity since the PR's goal is reducing root-level re-renders.

fair, on it!

adhorodyski · 2026-02-24T11:45:23Z

Sorry for last minute changes, pushed just one small further improvement that removes even more renders (PriorityModeHandler). No more changes to come.

mountiny · 2026-02-24T12:06:06Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 4199d88516

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Add authTokenSelector to Session selectors and use it in useIsAuthenticated to avoid re-renders on unrelated session field changes. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Krishna2323 · 2026-02-24T12:58:45Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

android_native.mp4

Android: mWeb Chrome

android_chrome.mp4

iOS: HybridApp

ios_native.mp4

iOS: mWeb Safari

ios_safari.mp4

MacOS: Chrome / Safari

web_chrome_1.mp4

web_chrome_3.mp4

web_chrome_2.mp4

Krishna2323 · 2026-02-24T13:33:44Z

I'm still working on the platform videos, will be done in 15mins

Krishna2323

LGTM and tests well! 🚀

The failing test doesn’t seem related. @adhorodyski, could you please confirm? Thanks!

adhorodyski · 2026-02-24T14:06:01Z

yeah just github's issues, resyncing now

mountiny

LGTM, thank you, going to move this ahead to avoid conflicts

OSBotify · 2026-02-24T15:40:47Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2026-02-24T15:49:21Z

🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-02-24T16:02:18Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #83307.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-0f4f47d-73031f7-5c111aeb492716ef3090d16e3e420d1ff8fdd762/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-0f4f47d-73031f7-34582c65b29cb3db216b75c1123156a3ed58a87a/index.html

Web 🕸️
https://83307.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-02-25T18:27:51Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.3.26-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

izarutskaya · 2026-02-26T11:06:11Z

Hi @adhorodyski QA team can't check Fullstory. Could you please validate it internally? Thank you in advance

mountiny · 2026-02-26T22:26:44Z

@izarutskaya Yeah will do

OSBotify · 2026-02-27T14:59:12Z

🚀 Deployed to production by https://github.com/puneetlath in version: 9.3.26-8 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

adhorodyski · 2026-03-02T09:27:22Z

Everything operational so far, thanks

Decompose Expensify.tsx: extract DelegateAccessHandler, FullstoryInit…

b5d4cdb

…Handler, ScreenShareRequestModal

melvin-bot Bot assigned adhorodyski Feb 24, 2026

adhorodyski changed the title ~~[No QA] Decompose Expensify.tsx: extract renderless handlers for delegate access, Fullstory init, and screen share~~ Decompose Expensify.tsx from delegate access, Fullstory init, and screen share Feb 24, 2026

Fix namespace import lint error in ScreenShareRequestModal

7d08115

Replace `import * as User` with named imports to comply with the no-restricted-syntax rule for @userActions. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

adhorodyski commented Feb 24, 2026

View reviewed changes

adhorodyski marked this pull request as ready for review February 24, 2026 10:51

adhorodyski requested review from a team as code owners February 24, 2026 10:51

melvin-bot Bot requested review from a team, Krishna2323 and heyjennahay and removed request for a team February 24, 2026 10:51

melvin-bot Bot requested review from Julesssss and suneox and removed request for a team February 24, 2026 10:51

github-actions Bot reviewed Feb 24, 2026

View reviewed changes

Comment thread src/DelegateAccessHandler.tsx

adhorodyski changed the title ~~Decompose Expensify.tsx from delegate access, Fullstory init, and screen share~~ Decompose Expensify.tsx from delegate access, Fullstory init, screen share and priority mode Feb 24, 2026

Krishna2323 reviewed Feb 24, 2026

View reviewed changes

chatgpt-codex-connector Bot reviewed Feb 24, 2026

View reviewed changes

Comment thread src/Expensify.tsx

Narrow useIsAuthenticated Onyx subscription with authToken selector

541ed2a

Add authTokenSelector to Session selectors and use it in useIsAuthenticated to avoid re-renders on unrelated session field changes. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Krishna2323 suggested changes Feb 24, 2026

View reviewed changes

Comment thread src/components/ScreenShareRequestModal.tsx

Add missing React import to ScreenShareRequestModal component

ecf8dfa

Krishna2323 approved these changes Feb 24, 2026

View reviewed changes

melvin-bot Bot requested a review from mountiny February 24, 2026 14:03

Merge branch 'Expensify:main' into decompose-findings-2

a66acd0

adhorodyski mentioned this pull request Feb 24, 2026

Decompose ReportScreen.tsx: extract isolated Onyx subscriptions #83331

Merged

51 tasks

mountiny approved these changes Feb 24, 2026

View reviewed changes

mountiny merged commit 0f4f47d into Expensify:main Feb 24, 2026
30 checks passed

adhorodyski deleted the decompose-findings-2 branch February 24, 2026 15:32

OSBotify mentioned this pull request Feb 25, 2026

Deploy Checklist: New Expensify 2026-02-25 #83466

Closed

Krishna2323 mentioned this pull request Feb 27, 2026

[Metrics] Improve Open Report Performance #77173

Open

MelvinBot mentioned this pull request Mar 3, 2026

[$250] Dev - App crashes after tapping on Vacation Delegate #83967

Closed

7 tasks

rlinoz mentioned this pull request Mar 4, 2026

[Awaiting payment 2026-03-07] Decompose Expensify.tsx #84149

Closed

Uh oh!

Conversation

adhorodyski commented Feb 24, 2026 • edited by rlinoz Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov Bot commented Feb 24, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

adhorodyski Feb 24, 2026

Choose a reason for hiding this comment

Uh oh!

melvin-bot Bot commented Feb 24, 2026

Uh oh!

melvin-bot Bot commented Feb 24, 2026

Uh oh!

Krishna2323 commented Feb 24, 2026

Uh oh!

Uh oh!

Krishna2323 commented Feb 24, 2026

Uh oh!

Krishna2323 Feb 24, 2026

Choose a reason for hiding this comment

Uh oh!

adhorodyski Feb 24, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

adhorodyski commented Feb 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mountiny commented Feb 24, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Krishna2323 commented Feb 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

Krishna2323 commented Feb 24, 2026

Uh oh!

Uh oh!

Krishna2323 left a comment

Choose a reason for hiding this comment

Uh oh!

adhorodyski commented Feb 24, 2026

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Feb 24, 2026

Uh oh!

github-actions Bot commented Feb 24, 2026

Uh oh!

github-actions Bot commented Feb 24, 2026

Uh oh!

OSBotify commented Feb 25, 2026

Uh oh!

izarutskaya commented Feb 26, 2026

Uh oh!

mountiny commented Feb 26, 2026

Uh oh!

OSBotify commented Feb 27, 2026

Uh oh!

adhorodyski commented Mar 2, 2026

Uh oh!

Reviewers

Assignees

adhorodyski commented Feb 24, 2026 •

edited by rlinoz

Loading

codecov Bot commented Feb 24, 2026 •

edited by github-actions Bot

Loading

adhorodyski commented Feb 24, 2026 •

edited

Loading

Krishna2323 commented Feb 24, 2026 •

edited

Loading