Skip to content

[No QA] Update billing articles #82886

Merged
johncschuster merged 16 commits into
mainfrom
helpsite-refractor-billing-articles
Feb 25, 2026
Merged

[No QA] Update billing articles #82886
johncschuster merged 16 commits into
mainfrom
helpsite-refractor-billing-articles

Conversation

@stephanieelliott

@stephanieelliott stephanieelliott commented Feb 19, 2026

Copy link
Copy Markdown
Contributor

$ https://github.com/Expensify/Expensify/issues/597520

Updated Classic version for AI compatibility and created a New Expensify version

@stephanieelliott stephanieelliott self-assigned this Feb 19, 2026
@github-actions github-actions Bot changed the title [HOLD] Helpsite refractor billing articles [No QA] [HOLD] Helpsite refractor billing articles Feb 19, 2026
@OSBotify

OSBotify commented Feb 19, 2026

Copy link
Copy Markdown
Contributor

@stephanieelliott stephanieelliott marked this pull request as ready for review February 19, 2026 04:50
@stephanieelliott stephanieelliott changed the title [No QA] [HOLD] Helpsite refractor billing articles [No QA] Admin Offboarding Checklist Feb 19, 2026
Comment thread docs/articles/expensify-classic/workspaces/Admin-offboarding-checklist.md Outdated
Comment thread docs/articles/new-expensify/workspaces/Admin-Offboarding-Checklist.md Outdated
Comment thread docs/articles/new-expensify/workspaces/Admin-Offboarding-Checklist.md Outdated
Comment thread docs/articles/new-expensify/workspaces/Admin-Offboarding-Checklist.md Outdated
Comment thread docs/articles/expensify-classic/workspaces/Admin-offboarding-checklist.md Outdated
Comment thread docs/articles/new-expensify/workspaces/Admin-Offboarding-Checklist.md Outdated
Comment thread docs/articles/new-expensify/workspaces/Admin-Offboarding-Checklist.md Outdated

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: add5fa8f0e

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread docs/articles/expensify-classic/workspaces/Admin-offboarding-checklist.md Outdated
Comment thread docs/articles/new-expensify/workspaces/Admin-Offboarding-Checklist.md Outdated
@github-actions

Copy link
Copy Markdown
Contributor

HelpDot Documentation Review

Overall Assessment

This PR rewrites the Expensify Classic admin offboarding checklist and creates a parallel New Expensify version. The restructuring is a significant improvement: the old article was organized by persona ("Checklist for the Current Admin" / "Checklist for the New Admin"), while the new versions are organized by task ("How to assign a new Workspace Admin," "How to verify a shared business bank account," etc.). This task-based structure is far more scannable, AI-friendly, and user-friendly. Both files also gain a well-constructed FAQ section, richer YAML metadata, and better cross-linking. Overall this is strong, well-organized documentation work with a few items worth addressing.

Scores Summary

  • Readability: 8/10 - Clear, direct language throughout. Sentences are concise and actionable. Minor inconsistencies (noted below) slightly reduce the score.
  • AI Readiness: 9/10 - Excellent descriptive headings using full task phrasing ("How to..."), proper internalScope metadata, rich keyword lists, and clean heading hierarchy (H1 + H2 only, with FAQ as a separate H1 section).
  • Style Compliance: 8/10 - Correct Expensify terminology (Workspace Admin, Domain Admin, Billing Owner), proper bold formatting for UI elements, and good use of linked references. A few formatting and consistency issues noted below.

Key Findings

Positive aspects:

  • The shift from persona-based organization ("Checklist for the Current Admin") to task-based headings ("How to assign a new Workspace Admin") is a major readability and AI-retrieval improvement. Each section can now stand alone as an answer to a specific question.
  • The internalScope field is well-written in both files and follows the prescribed format (Audience is... Covers... Does not cover...).
  • The FAQ section is a strong addition. Questions like "Can I remove the previous admin before verifying the bank account?" and "What happens if the admin leaves before this checklist is completed?" address real user pain points and will surface well in AI retrieval.
  • Cross-links are appropriate and use anchor-specific URLs (e.g., linking to #how-to-share-a-verified-bank-account and #transfer-workspace-ownership), which is excellent for both navigation and AI context.
  • The keyword arrays are comprehensive and cover key search terms users would actually type.

Issues to address:

  1. Missing image file (New Expensify version): The new file Admin-Offboarding-Checklist.md references ExpensifyHelp-AdminOffboardingChecklist_03.png, but this image is not included in the PR. This will result in a broken image on the published page. Either the image needs to be added in a separate commit or the reference should be removed/updated.

  2. Minor content inconsistency between Classic and New Expensify versions:

    • The Classic version intro lists 5 roles (Billing Owner, Workspace Admin, Domain Admin, Technical Contact, Bank Account Owner), but the New Expensify version lists only 4 (omits Technical Contact). If Technical Contact is not a concept in New Expensify, this is correct but could benefit from an explicit note. If it does exist, it should be included.
    • The Classic FAQ answer for "What's the Difference Between a Workspace Admin and a Domain Admin?" says Domain Admins manage "company-wide permissions, SAML, and card feeds (including Expensify Cards)." The New Expensify FAQ says "company-wide permissions like SAML" -- omitting card feeds. Confirm whether this omission is intentional for the New Expensify context.
  3. Inconsistent "reimburser" vs. "Payer" terminology: The Classic version uses "How to change the default reimburser on a workspace" while the New Expensify version uses "How to change the default Payer on a workspace." If these reflect actual product differences between Classic and New Expensify, this is correct. However, the Classic version also mentions "Reimburser" in the step text while the New Expensify version uses "Payer" -- worth confirming these match the actual UI labels in each product.

  4. FAQ heading capitalization: The last FAQ heading in both files reads "What's the Difference Between a Workspace Admin and a Domain Admin?" with title case ("Difference Between"). All other FAQ headings use sentence case ("Do I need to complete...", "Who can verify...", "Can I remove..."). This should be made consistent: "What's the difference between a Workspace Admin and a Domain Admin?"

  5. Navigation instruction inconsistency (New Expensify version): Some sections use the phrase "In the navigation tabs (on the left on web, and at the bottom on mobile), go to..." while others use the shorter "Go to..." or no navigation preamble at all. Consider standardizing this -- either always include the navigation context or include it only once at the top of the article with a note.

  6. Minor trailing whitespace: Both files have a trailing space after title: Admin Offboarding Checklist in the YAML frontmatter. While this may not affect rendering, it is a minor formatting concern.

  7. Double space in "Important" callout: Both files have **Important:** This checklist applies with two spaces after the colon-bold. Minor but worth cleaning up.

  8. Missing horizontal rule: In the Classic version, there is no --- separator between the "How to assign a new Domain Admin" section and the "How to share a business bank account" section. Similarly in the New Expensify version, the separator is missing between "How to assign a new Domain Admin" and "How to share a business bank account." All other sections use --- separators consistently.

  9. New Expensify accounting reconnection section omits Technical Contact: The Classic version heading is "How to reconnect accounting integrations and update the Technical Contact" and includes a step to update the Technical Contact. The New Expensify version uses the same heading but does not include a step for updating the Technical Contact -- only disconnect/reconnect steps for integrations. If Technical Contact is not applicable in New Expensify, the heading should be updated to simply "How to reconnect accounting integrations."

Recommendations

  1. [Required] Add the missing ExpensifyHelp-AdminOffboardingChecklist_03.png image to the docs/assets/images/ directory, or remove the image reference from the New Expensify file until the image is ready.
  2. [Recommended] Fix the FAQ heading capitalization: change "What's the Difference Between..." to "What's the difference between..." in both files.
  3. [Recommended] Add the missing --- horizontal rule separators after the "How to assign a new Domain Admin" section in both files for consistency.
  4. [Recommended] In the New Expensify version, either add a Technical Contact update step under the accounting integrations section or remove "and update the Technical Contact" from the heading.
  5. [Low priority] Clean up trailing whitespace in YAML title and double-space after **Important:** in both files.
  6. [Low priority] Standardize navigation instruction phrasing in the New Expensify version.

Files Reviewed

  • docs/articles/expensify-classic/workspaces/Admin-offboarding-checklist.md (modified) -- Substantial rewrite with improved structure, richer metadata, and added FAQ section. Well done overall.
  • docs/articles/new-expensify/workspaces/Admin-Offboarding-Checklist.md (new file) -- New parallel article for New Expensify. Appropriately adapted with product-specific links and UI instructions. Has a missing image reference that needs resolution.

@stephanieelliott stephanieelliott changed the title [No QA] Admin Offboarding Checklist [No QA] Update billing articles Feb 20, 2026
stephanieelliott and others added 5 commits February 19, 2026 16:48
…hecklist.md

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…list.md

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…list.md

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…list.md

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…hecklist.md

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
stephanieelliott and others added 4 commits February 19, 2026 16:51
…list.md

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…list.md

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@stephanieelliott

Copy link
Copy Markdown
Contributor Author

Addressed all changes

@stephanieelliott stephanieelliott requested a review from a team February 20, 2026 03:01
@melvin-bot

melvin-bot Bot commented Feb 20, 2026

Copy link
Copy Markdown

Concierge reviewer checklist:

  • I have verified the accuracy of the article
    • The article is within a hub that makes sense, and the navigation is correct
    • All processes, screenshots, and examples align with current product behavior.
    • All links within the doc have been verified for correct destination and functionality.
  • I have verified the readability of the article
    • The article's language is clear, concise, and free of jargon.
    • The grammar, spelling, and punctuation are correct.
    • The article contains at least one image, or that an image is not necessary
  • I have verified the formatting of the article
    • The article has consistent formatting (headings, bullet points, etc.) with other HelpDot articles and that aligns with the HelpDot formatting standards.
    • The article has proper text spacing and breaks for readability.
  • I have verified the article has the appropriate tone and style
    • The article's tone is professional, friendly, and suitable for the target audience.
    • The article's tone, terminology, and voice are consistent throughout.
  • I have verified the overall quality of the article
    • The article is not missing any information, nor does it contain redundant information.
    • The article fully addresses user needs.
  • I have verified that all requested improvements have been addressed

For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member?

cc @johncschuster

@melvin-bot

melvin-bot Bot commented Feb 20, 2026

Copy link
Copy Markdown

@robertjchen @johncschuster One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot Bot removed the request for review from a team February 20, 2026 03:02
@stephanieelliott stephanieelliott removed the request for review from robertjchen February 20, 2026 03:02
@johncschuster johncschuster merged commit e1af99c into main Feb 25, 2026
13 checks passed
@johncschuster johncschuster deleted the helpsite-refractor-billing-articles branch February 25, 2026 03:19
@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/johncschuster in version: 9.3.26-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/puneetlath in version: 9.3.26-8 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants