[No QA][Duplicate Report] Add "Duplicate report" option to the report More menu with visibility logic.#82733
Conversation
…enu with visibility logic. Signed-off-by: krishna2323 <belivethatkg@gmail.com>
|
@hungvu193 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
Hey, I noticed you changed If you want to automatically generate translations for other locales, an Expensify employee will have to:
Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running: npx ts-node ./scripts/generateTranslations.ts --helpTypically, you'd want to translate only what you changed by running |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 598989ccd6
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| [CONST.REPORT.SECONDARY_ACTIONS.DUPLICATE_REPORT]: { | ||
| text: translate('common.duplicateReport'), | ||
| icon: expensifyIcons.ReportCopy, | ||
| value: CONST.REPORT.SECONDARY_ACTIONS.DUPLICATE_REPORT, | ||
| sentryLabel: CONST.SENTRY_LABEL.MORE_MENU.DUPLICATE_REPORT, |
There was a problem hiding this comment.
Hide unimplemented duplicate report action
This adds an enabled DUPLICATE_REPORT menu item without any onSelected handler, so selecting it does not trigger behavior. ButtonWithDropdownMenu falls back to onOptionSelected when onSelected is missing, but the MoneyReportHeaderKYCDropdown caller does not provide onOptionSelected, so users can tap “Duplicate report” and only see the menu close with no action. This exposes a visibly broken control in production until issue #82153 is implemented.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
@hungvu193 I have hide the option for now and added "[No QA]" in the title. We can proceed without the recordings since there's nothing to test.
joekaufmanexpensify
left a comment
There was a problem hiding this comment.
Good for product
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
|
The Spanish version is confirmed here: https://expensify.slack.com/archives/C01GTK53T8Q/p1771382531910989. We now need to run the scripts to generate the other language translations. |
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / Safari |
|
@Valforte Could you please trigger the translation generation workflows? Thanks |
|
Will do |
🦜 Polyglot Parrot! 🦜Squawk! Looks like you added some shiny new English strings. Allow me to parrot them back to you in other tongues: View the translation diffdiff --git a/src/languages/de.ts b/src/languages/de.ts
index 9505f886..3dcabb49 100644
--- a/src/languages/de.ts
+++ b/src/languages/de.ts
@@ -130,7 +130,6 @@ import type {
ZipCodeExampleFormatParams,
} from './params';
import type {TranslationDeepObject} from './types';
-
type StateValue = {
stateISO: string;
stateName: string;
@@ -535,6 +534,7 @@ const translations: TranslationDeepObject<typeof en> = {
year: 'Jahr',
quarter: 'Quartal',
expensifyLogo: 'Expensify-Logo',
+ duplicateReport: 'Duplizierten Bericht',
},
socials: {
podcast: 'Folgen Sie uns auf Podcast',
@@ -5207,7 +5207,7 @@ _Für ausführlichere Anweisungen [besuchen Sie unsere Hilfeseite](${CONST.NETSU
updateCard: 'Karte aktualisieren',
unassignCard: 'Karte zuweisen aufheben',
unassign: 'Zuweisung aufheben',
- unassignCardDescription: 'Das Aufheben der Zuweisung dieser Karte entfernt alle Transaktionen in Entwurfsberichten aus dem Konto der Karteninhaber*in.',
+ unassignCardDescription: 'Die Zuordnung dieser Karte aufzuheben, entfernt alle Transaktionen in Entwürfen von Berichten aus dem Konto der Karteninhaber*in.',
assignCard: 'Karte zuweisen',
cardFeedName: 'Name des Kartenfeeds',
cardFeedNameDescription: 'Gib dem Kartenfeed einen eindeutigen Namen, damit du ihn von den anderen unterscheiden kannst.',
@@ -6388,7 +6388,7 @@ Fordern Sie Spesendetails wie Belege und Beschreibungen an, legen Sie Limits und
matchTypeContains: 'Enthält',
matchTypeExact: 'Exakte Übereinstimmung',
duplicateRuleTitle: 'Ähnliche Händlerregel existiert bereits',
- duplicateRulePrompt: (merchantName: string) => `Möchtest du eine neue Regel für „${merchantName}“ speichern, obwohl bereits eine existierende Regel vorhanden ist?`,
+ duplicateRulePrompt: (merchantName: string) => `Möchtest du eine neue Regel für „${merchantName}“ speichern, obwohl bereits eine existiert?`,
saveAnyway: 'Trotzdem speichern',
applyToExistingUnsubmittedExpenses: 'Auf bestehende nicht eingereichte Ausgaben anwenden',
},
@@ -7742,15 +7742,15 @@ Fordern Sie Spesendetails wie Belege und Beschreibungen an, legen Sie Limits und
reviewRequired: 'Überprüfung erforderlich',
rter: ({brokenBankConnection, isAdmin, isTransactionOlderThan7Days, member, rterType, companyCardPageURL}: ViolationsRterParams) => {
if (rterType === CONST.RTER_VIOLATION_TYPES.BROKEN_CARD_CONNECTION_530) {
- return 'Beleg kann wegen unterbrochener Bankverbindung nicht automatisch zugeordnet werden';
+ return 'Beleg kann aufgrund einer unterbrochenen Bankverbindung nicht automatisch zugeordnet werden';
}
if (brokenBankConnection || rterType === CONST.RTER_VIOLATION_TYPES.BROKEN_CARD_CONNECTION) {
return isAdmin
? `Bankverbindung unterbrochen. <a href="${companyCardPageURL}">Erneut verbinden, um Beleg abzugleichen</a>`
- : 'Bankverbindung unterbrochen. Bitte eine:n Admin darum bitten, sie neu zu verbinden, um den Beleg abzugleichen.';
+ : 'Bankverbindung unterbrochen. Bitte eine*n Admin bitten, sie zur Belegzuordnung erneut zu verbinden.';
}
if (!isTransactionOlderThan7Days) {
- return isAdmin ? `Bitte ${member} darum, als Barzahlung zu markieren, oder warte 7 Tage und versuche es dann erneut` : 'Warten auf Abgleich mit Kartentransaktion.';
+ return isAdmin ? `Bitte ${member} darum, es als Barzahlung zu markieren, oder warte 7 Tage und versuche es erneut` : 'Wartet auf Zusammenführung mit Kartenumsatz.';
}
return '';
},
diff --git a/src/languages/fr.ts b/src/languages/fr.ts
index 7c9228bf..92d534ca 100644
--- a/src/languages/fr.ts
+++ b/src/languages/fr.ts
@@ -130,7 +130,6 @@ import type {
ZipCodeExampleFormatParams,
} from './params';
import type {TranslationDeepObject} from './types';
-
type StateValue = {
stateISO: string;
stateName: string;
@@ -535,6 +534,7 @@ const translations: TranslationDeepObject<typeof en> = {
year: 'Année',
quarter: 'Trimestre',
expensifyLogo: 'Logo Expensify',
+ duplicateReport: 'Note de frais en double',
},
socials: {
podcast: 'Suivez-nous sur Podcast',
@@ -3071,7 +3071,7 @@ ${
time: 'Heure',
clearAfter: 'Effacer après',
whenClearStatus: 'Quand devons-nous effacer votre statut ?',
- vacationDelegate: 'Délégué de vacances',
+ vacationDelegate: 'Délégataire de vacances',
setVacationDelegate: `Définissez un délégué de vacances pour approuver les notes de frais en votre nom pendant votre absence du bureau.`,
cannotSetVacationDelegate: `Vous ne pouvez pas définir un délégué de vacances car vous êtes actuellement le délégué des membres suivants :`,
vacationDelegateError: 'Une erreur s’est produite lors de la mise à jour de votre remplaçant de congés.',
@@ -5225,8 +5225,7 @@ _Pour des instructions plus détaillées, [visitez notre site d’aide](${CONST.
updateCard: 'Mettre à jour la carte',
unassignCard: 'Retirer l’assignation de la carte',
unassign: "Retirer l'assignation",
- unassignCardDescription:
- "Retirer l'assignation de cette carte supprimera toutes les transactions figurant sur les notes de frais en brouillon du compte du titulaire de la carte.",
+ unassignCardDescription: "Retirer l'assignation de cette carte supprimera toutes les transactions sur les notes de frais en brouillon du compte du titulaire de la carte.",
assignCard: 'Assigner une carte',
cardFeedName: 'Nom du flux de carte',
cardFeedNameDescription: 'Donnez au flux de carte un nom unique afin de pouvoir le distinguer des autres.',
@@ -6409,7 +6408,7 @@ Rendez obligatoires des informations de dépense comme les reçus et les descrip
matchTypeContains: 'Contient',
matchTypeExact: 'Correspond exactement',
duplicateRuleTitle: 'Une règle de commerçant similaire existe déjà',
- duplicateRulePrompt: (merchantName: string) => `Voulez-vous enregistrer une nouvelle règle pour « ${merchantName} » même si vous en avez déjà une ?`,
+ duplicateRulePrompt: (merchantName: string) => `Voulez-vous enregistrer une nouvelle règle pour « ${merchantName} » même si vous en avez déjà une existante ?`,
saveAnyway: 'Enregistrer quand même',
applyToExistingUnsubmittedExpenses: 'Appliquer aux dépenses non soumises existantes',
},
@@ -7764,15 +7763,15 @@ Rendez obligatoires des informations de dépense comme les reçus et les descrip
reviewRequired: 'Examen requis',
rter: ({brokenBankConnection, isAdmin, isTransactionOlderThan7Days, member, rterType, companyCardPageURL}: ViolationsRterParams) => {
if (rterType === CONST.RTER_VIOLATION_TYPES.BROKEN_CARD_CONNECTION_530) {
- return 'Impossible d’associer automatiquement le reçu en raison d’une connexion bancaire interrompue';
+ return 'Impossible d’associer automatiquement le reçu en raison d’une connexion bancaire rompue';
}
if (brokenBankConnection || rterType === CONST.RTER_VIOLATION_TYPES.BROKEN_CARD_CONNECTION) {
return isAdmin
- ? `Connexion bancaire rompue. <a href="${companyCardPageURL}">Reconnectez-vous pour faire correspondre le reçu</a>`
- : 'Connexion bancaire rompue. Demandez à un administrateur de la reconnecter pour faire correspondre le reçu.';
+ ? `Connexion bancaire interrompue. <a href="${companyCardPageURL}">Reconnecter pour faire correspondre le reçu</a>`
+ : 'Connexion bancaire interrompue. Demandez à un administrateur de la reconnecter pour faire correspondre le reçu.';
}
if (!isTransactionOlderThan7Days) {
- return isAdmin ? `Demandez à ${member} de marquer comme espèce ou attendez 7 jours et réessayez` : 'En attente de fusion avec la transaction par carte.';
+ return isAdmin ? `Demandez à ${member} de marquer comme paiement en espèces ou attendez 7 jours et réessayez` : 'En attente de fusion avec la transaction par carte.';
}
return '';
},
diff --git a/src/languages/it.ts b/src/languages/it.ts
index a8eb2a84..ee56742e 100644
--- a/src/languages/it.ts
+++ b/src/languages/it.ts
@@ -130,7 +130,6 @@ import type {
ZipCodeExampleFormatParams,
} from './params';
import type {TranslationDeepObject} from './types';
-
type StateValue = {
stateISO: string;
stateName: string;
@@ -535,6 +534,7 @@ const translations: TranslationDeepObject<typeof en> = {
year: 'Anno',
quarter: 'Trimestre',
expensifyLogo: 'Logo Expensify',
+ duplicateReport: 'Report duplicato',
},
socials: {
podcast: 'Seguici su Podcast',
@@ -3053,7 +3053,7 @@ ${
time: 'Ora',
clearAfter: 'Cancella dopo',
whenClearStatus: 'Quando dovremmo cancellare il tuo stato?',
- vacationDelegate: 'Delegato ferie',
+ vacationDelegate: 'Delegato per le ferie',
setVacationDelegate: `Imposta un delegato per le ferie per approvare i report per tuo conto mentre sei fuori ufficio.`,
cannotSetVacationDelegate: `Non puoi impostare un delegato per le ferie perché al momento sei il delegato per i seguenti membri:`,
vacationDelegateError: 'Si è verificato un errore durante l’aggiornamento del tuo delegato per le ferie.',
@@ -5195,7 +5195,7 @@ _Per istruzioni più dettagliate, [visita il nostro sito di assistenza](${CONST.
updateCard: 'Aggiorna carta',
unassignCard: 'Rimuovi carta',
unassign: 'Rimuovi assegnazione',
- unassignCardDescription: 'La rimozione dell’assegnazione di questa carta eliminerà tutte le transazioni nei report in bozza dall’account del titolare della carta.',
+ unassignCardDescription: 'La dissociazione di questa carta rimuoverà tutte le transazioni nei report in bozza dall’account del titolare della carta.',
assignCard: 'Assegna carta',
cardFeedName: 'Nome feed carta',
cardFeedNameDescription: 'Dai al feed della carta un nome univoco, così puoi distinguerlo dagli altri.',
@@ -6371,7 +6371,7 @@ Richiedi dettagli sulle spese come ricevute e descrizioni, imposta limiti e valo
matchTypeContains: 'Contiene',
matchTypeExact: 'Corrisponde esattamente',
duplicateRuleTitle: "Una regola simile per l'esercente esiste già",
- duplicateRulePrompt: (merchantName: string) => `Vuoi salvare una nuova regola per «${merchantName}» anche se ne hai già una esistente?`,
+ duplicateRulePrompt: (merchantName: string) => `Vuoi salvare una nuova regola per "${merchantName}" anche se ne esiste già una?`,
saveAnyway: 'Salva comunque',
applyToExistingUnsubmittedExpenses: 'Applica alle spese esistenti non inviate',
},
@@ -7732,10 +7732,10 @@ Richiedi dettagli sulle spese come ricevute e descrizioni, imposta limiti e valo
if (brokenBankConnection || rterType === CONST.RTER_VIOLATION_TYPES.BROKEN_CARD_CONNECTION) {
return isAdmin
? `Connessione bancaria interrotta. <a href="${companyCardPageURL}">Riconnetti per abbinare la ricevuta</a>`
- : 'Collegamento bancario interrotto. Chiedi a un amministratore di ricollegarlo per abbinare la ricevuta.';
+ : 'Connessione bancaria interrotta. Chiedi a un amministratore di ricollegarla per abbinarla alla ricevuta.';
}
if (!isTransactionOlderThan7Days) {
- return isAdmin ? `Chiedi a ${member} di contrassegnarla come contante oppure attendi 7 giorni e riprova` : 'In attesa di unione con la transazione della carta.';
+ return isAdmin ? `Chiedi a ${member} di contrassegnarlo come contante oppure attendi 7 giorni e riprova` : 'In attesa di unione con la transazione della carta.';
}
return '';
},
diff --git a/src/languages/ja.ts b/src/languages/ja.ts
index e97b77f1..5b6d37dc 100644
--- a/src/languages/ja.ts
+++ b/src/languages/ja.ts
@@ -130,7 +130,6 @@ import type {
ZipCodeExampleFormatParams,
} from './params';
import type {TranslationDeepObject} from './types';
-
type StateValue = {
stateISO: string;
stateName: string;
@@ -534,6 +533,7 @@ const translations: TranslationDeepObject<typeof en> = {
year: '年',
quarter: '四半期',
expensifyLogo: 'Expensifyロゴ',
+ duplicateReport: 'レポートを複製',
},
socials: {
podcast: 'ポッドキャストでフォロー',
@@ -5142,7 +5142,7 @@ _詳しい手順については、[ヘルプサイトをご覧ください](${CO
updateCard: 'カードを更新',
unassignCard: 'カードの割り当てを解除',
unassign: '割り当てを解除',
- unassignCardDescription: 'このカードの割り当てを解除すると、ドラフトレポート上のすべての取引がカード所有者のアカウントから削除されます。',
+ unassignCardDescription: 'このカードの割り当てを解除すると、ドラフトレポート上のすべての取引がカード保有者のアカウントから削除されます。',
assignCard: 'カードを割り当てる',
cardFeedName: 'カードフィード名',
cardFeedNameDescription: '他のカードフィードと区別できるように、一意の名前を付けてください。',
@@ -6312,7 +6312,7 @@ ${reportName}
matchTypeContains: '含む',
matchTypeExact: '完全一致',
duplicateRuleTitle: '同様のマーチャントルールが既に存在します',
- duplicateRulePrompt: (merchantName: string) => `既にルールが存在しますが、「${merchantName}」用に新しいルールを保存しますか?`,
+ duplicateRulePrompt: (merchantName: string) => `既存のルールがある「${merchantName}」に対して、新しいルールを保存しますか?`,
saveAnyway: 'とにかく保存',
applyToExistingUnsubmittedExpenses: '既存の未提出経費に適用',
},
@@ -7652,12 +7652,12 @@ ${reportName}
reviewRequired: '要レビュー',
rter: ({brokenBankConnection, isAdmin, isTransactionOlderThan7Days, member, rterType, companyCardPageURL}: ViolationsRterParams) => {
if (rterType === CONST.RTER_VIOLATION_TYPES.BROKEN_CARD_CONNECTION_530) {
- return '銀行連携の不具合によりレシートを自動照合できません';
+ return '銀行連携の不具合により領収書を自動照合できません';
}
if (brokenBankConnection || rterType === CONST.RTER_VIOLATION_TYPES.BROKEN_CARD_CONNECTION) {
return isAdmin
- ? `銀行接続が切断されました。<a href="${companyCardPageURL}">再接続してレシートと照合</a>`
- : '銀行連携が切断されています。管理者に依頼して再接続し、レシートとの照合を行ってください。';
+ ? `銀行連携が切断されました。<a href="${companyCardPageURL}">領収書と照合するために再接続</a>`
+ : '銀行連携が切断されています。管理者に依頼して再接続し、レシートと照合してください。';
}
if (!isTransactionOlderThan7Days) {
return isAdmin ? `${member} に現金としてマークするよう依頼するか、7日待ってからもう一度お試しください` : 'カード取引との統合待ちです。';
diff --git a/src/languages/nl.ts b/src/languages/nl.ts
index 871c182a..5742e182 100644
--- a/src/languages/nl.ts
+++ b/src/languages/nl.ts
@@ -130,7 +130,6 @@ import type {
ZipCodeExampleFormatParams,
} from './params';
import type {TranslationDeepObject} from './types';
-
type StateValue = {
stateISO: string;
stateName: string;
@@ -534,6 +533,7 @@ const translations: TranslationDeepObject<typeof en> = {
year: 'Jaar',
quarter: 'Kwartaal',
expensifyLogo: 'Expensify-logo',
+ duplicateReport: 'Dubbel rapport',
},
socials: {
podcast: 'Volg ons op Podcast',
@@ -3052,7 +3052,7 @@ ${
time: 'Tijd',
clearAfter: 'Wissen na',
whenClearStatus: 'Wanneer moeten we je status wissen?',
- vacationDelegate: 'Vertegenwoordiger tijdens vakantie',
+ vacationDelegate: 'Vervangend goedkeurder',
setVacationDelegate: `Stel een vervangende fiatteur in om rapporten namens jou goed te keuren terwijl je afwezig bent.`,
cannotSetVacationDelegate: `Je kunt geen vakantiedelegaat instellen omdat je momenteel de delegaat bent voor de volgende leden:`,
vacationDelegateError: 'Er is een fout opgetreden bij het bijwerken van je vervanger tijdens vakantie.',
@@ -5178,7 +5178,7 @@ _Voor meer gedetailleerde instructies, [bezoek onze help-site](${CONST.NETSUITE_
updateCard: 'Kaart bijwerken',
unassignCard: 'Kaart loskoppelen',
unassign: 'Toewijzen ongedaan maken',
- unassignCardDescription: 'Deze kaart loskoppelen verwijdert alle transacties op conceptrapporten uit de rekening van de kaarthouder.',
+ unassignCardDescription: 'Het toewijzen van deze kaart ongedaan maken verwijdert alle transacties op conceptrapporten uit de rekening van de kaarthouder.',
assignCard: 'Kaart toewijzen',
cardFeedName: 'Naam van kaartfeed',
cardFeedNameDescription: 'Geef de kaartfeed een unieke naam zodat je deze kunt onderscheiden van de andere.',
@@ -6353,7 +6353,7 @@ Vereis onkostendetails zoals bonnen en beschrijvingen, stel limieten en standaar
matchTypeContains: 'Bevat',
matchTypeExact: 'Komt exact overeen',
duplicateRuleTitle: 'Vergelijkbare handelaarregel bestaat al',
- duplicateRulePrompt: (merchantName: string) => `Wil je een nieuwe regel voor ‘${merchantName}’ opslaan, ook al heb je er al een bestaande?`,
+ duplicateRulePrompt: (merchantName: string) => `Wil je een nieuwe regel opslaan voor ‘${merchantName}’, ook al heb je er al een?`,
saveAnyway: 'Toch opslaan',
applyToExistingUnsubmittedExpenses: 'Toepassen op bestaande niet-ingediende uitgaven',
},
@@ -7710,11 +7710,11 @@ Vereis onkostendetails zoals bonnen en beschrijvingen, stel limieten en standaar
}
if (brokenBankConnection || rterType === CONST.RTER_VIOLATION_TYPES.BROKEN_CARD_CONNECTION) {
return isAdmin
- ? `Bankkoppeling verbroken. <a href="${companyCardPageURL}">Opnieuw verbinden om bon te matchen</a>`
- : 'Bankverbinding verbroken. Vraag een beheerder om opnieuw te verbinden om het met de bon te matchen.';
+ ? `Bankkoppeling verbroken. <a href="${companyCardPageURL}">Opnieuw verbinden om bonnetje te koppelen</a>`
+ : 'Bankkoppeling verbroken. Vraag een beheerder om opnieuw te verbinden om de bon te matchen.';
}
if (!isTransactionOlderThan7Days) {
- return isAdmin ? `Vraag ${member} om het als contant te markeren of wacht 7 dagen en probeer het opnieuw` : 'In afwachting van samenvoeging met kaarttransactie.';
+ return isAdmin ? `Vraag ${member} om dit als contant te markeren of wacht 7 dagen en probeer het opnieuw` : 'In afwachting van samenvoeging met kaarttransactie.';
}
return '';
},
diff --git a/src/languages/pl.ts b/src/languages/pl.ts
index cd29ec49..7ce9bc38 100644
--- a/src/languages/pl.ts
+++ b/src/languages/pl.ts
@@ -130,7 +130,6 @@ import type {
ZipCodeExampleFormatParams,
} from './params';
import type {TranslationDeepObject} from './types';
-
type StateValue = {
stateISO: string;
stateName: string;
@@ -534,6 +533,7 @@ const translations: TranslationDeepObject<typeof en> = {
year: 'Rok',
quarter: 'Kwartał',
expensifyLogo: 'Logo Expensify',
+ duplicateReport: 'Zduplikowany raport',
},
socials: {
podcast: 'Śledź nas na Podcast',
@@ -3044,7 +3044,7 @@ ${
time: 'Czas',
clearAfter: 'Wyczyść po',
whenClearStatus: 'Kiedy powinniśmy wyczyścić Twój status?',
- vacationDelegate: 'Zastępca urlopowy',
+ vacationDelegate: 'Delegat na czas urlopu',
setVacationDelegate: `Ustaw zastępcę na czas urlopu, aby zatwierdzał raporty w Twoim imieniu, gdy jesteś poza biurem.`,
cannotSetVacationDelegate: `Nie możesz ustawić delegata urlopowego, ponieważ obecnie jesteś delegatem dla następujących członków:`,
vacationDelegateError: 'Wystąpił błąd podczas aktualizowania Twojego zastępcy urlopowego.',
@@ -5172,7 +5172,7 @@ _Aby uzyskać bardziej szczegółowe instrukcje, [odwiedź naszą stronę pomocy
updateCard: 'Zaktualizuj kartę',
unassignCard: 'Cofnij przypisanie karty',
unassign: 'Cofnij przypisanie',
- unassignCardDescription: 'Odłączenie tej karty spowoduje usunięcie wszystkich transakcji z raportów w wersji roboczej z konta posiadacza karty.',
+ unassignCardDescription: 'Odłączenie tej karty spowoduje usunięcie wszystkich transakcji na raportach roboczych z konta posiadacza karty.',
assignCard: 'Przypisz kartę',
cardFeedName: 'Nazwa źródła karty',
cardFeedNameDescription: 'Nadaj kanałowi karty unikalną nazwę, aby odróżnić go od pozostałych.',
@@ -6348,7 +6348,7 @@ Wymagaj szczegółów wydatków, takich jak paragony i opisy, ustawiaj limity i
matchTypeContains: 'Zawiera',
matchTypeExact: 'Dokładnie pasuje',
duplicateRuleTitle: 'Podobna reguła dla sprzedawcy już istnieje',
- duplicateRulePrompt: (merchantName: string) => `Czy chcesz zapisać nową regułę dla „${merchantName}”, mimo że masz już istniejącą?`,
+ duplicateRulePrompt: (merchantName: string) => `Czy chcesz zapisać nowe reguły dla „${merchantName}”, mimo że masz już istniejące?`,
saveAnyway: 'Zapisz mimo to',
applyToExistingUnsubmittedExpenses: 'Zastosuj do istniejących niewysłanych wydatków',
},
@@ -7694,15 +7694,15 @@ Wymagaj szczegółów wydatków, takich jak paragony i opisy, ustawiaj limity i
reviewRequired: 'Wymagana weryfikacja',
rter: ({brokenBankConnection, isAdmin, isTransactionOlderThan7Days, member, rterType, companyCardPageURL}: ViolationsRterParams) => {
if (rterType === CONST.RTER_VIOLATION_TYPES.BROKEN_CARD_CONNECTION_530) {
- return 'Nie można automatycznie dopasować paragonu z powodu przerwanego połączenia z bankiem';
+ return 'Nie można automatycznie dopasować paragonu z powodu zerwanego połączenia z bankiem';
}
if (brokenBankConnection || rterType === CONST.RTER_VIOLATION_TYPES.BROKEN_CARD_CONNECTION) {
return isAdmin
- ? `Połączenie z bankiem przerwane. <a href="${companyCardPageURL}">Połącz ponownie, aby dopasować paragon</a>`
+ ? `Połączenie z bankiem zostało zerwane. <a href="${companyCardPageURL}">Połącz ponownie, aby dopasować paragon</a>`
: 'Połączenie z bankiem zostało zerwane. Poproś administratora o ponowne połączenie, aby dopasować paragon.';
}
if (!isTransactionOlderThan7Days) {
- return isAdmin ? `Poproś ${member}, aby oznaczył to jako gotówkę lub poczekaj 7 dni i spróbuj ponownie` : 'Oczekuje na połączenie z transakcją kartową.';
+ return isAdmin ? `Poproś ${member}, aby oznaczył jako gotówkę lub poczekaj 7 dni i spróbuj ponownie` : 'Oczekuje na połączenie z transakcją kartową.';
}
return '';
},
diff --git a/src/languages/pt-BR.ts b/src/languages/pt-BR.ts
index 4f3e8d33..f653cef6 100644
--- a/src/languages/pt-BR.ts
+++ b/src/languages/pt-BR.ts
@@ -130,7 +130,6 @@ import type {
ZipCodeExampleFormatParams,
} from './params';
import type {TranslationDeepObject} from './types';
-
type StateValue = {
stateISO: string;
stateName: string;
@@ -533,6 +532,7 @@ const translations: TranslationDeepObject<typeof en> = {
year: 'Ano',
quarter: 'Trimestre',
expensifyLogo: 'Logo da Expensify',
+ duplicateReport: 'Relatório duplicado',
},
socials: {
podcast: 'Siga-nos no Podcast',
@@ -5178,7 +5178,7 @@ _Para instruções mais detalhadas, [visite nossa central de ajuda](${CONST.NETS
updateCard: 'Atualizar cartão',
unassignCard: 'Remover cartão',
unassign: 'Desatribuir',
- unassignCardDescription: 'Desatribuir este cartão removerá todas as transações em relatórios em rascunho da conta do titular do cartão.',
+ unassignCardDescription: 'Remover a atribuição deste cartão excluirá todas as transações em relatórios de rascunho da conta do titular do cartão.',
assignCard: 'Atribuir cartão',
cardFeedName: 'Nome do feed do cartão',
cardFeedNameDescription: 'Dê um nome exclusivo ao feed do cartão para diferenciá-lo dos outros.',
@@ -7698,15 +7698,15 @@ Exija dados de despesas como recibos e descrições, defina limites e padrões e
reviewRequired: 'Revisão necessária',
rter: ({brokenBankConnection, isAdmin, isTransactionOlderThan7Days, member, rterType, companyCardPageURL}: ViolationsRterParams) => {
if (rterType === CONST.RTER_VIOLATION_TYPES.BROKEN_CARD_CONNECTION_530) {
- return 'Não é possível associar automaticamente o recibo devido à conexão bancária interrompida';
+ return 'Não é possível fazer a correspondência automática do recibo devido a conexão bancária interrompida';
}
if (brokenBankConnection || rterType === CONST.RTER_VIOLATION_TYPES.BROKEN_CARD_CONNECTION) {
return isAdmin
- ? `Conexão bancária interrompida. <a href="${companyCardPageURL}">Reconectar para corresponder ao recibo</a>`
- : 'Conexão bancária quebrada. Peça para um administrador reconectar para coincidir com o recibo.';
+ ? `Conexão bancária interrompida. <a href="${companyCardPageURL}">Reconecte para conciliar o recibo</a>`
+ : 'Conexão bancária interrompida. Peça para um administrador reconectar para corresponder ao recibo.';
}
if (!isTransactionOlderThan7Days) {
- return isAdmin ? `Peça para ${member} marcar como pagamento em dinheiro ou aguarde 7 dias e tente novamente` : 'Aguardando mesclagem com a transação do cartão.';
+ return isAdmin ? `Peça para ${member} marcar como dinheiro em espécie ou aguarde 7 dias e tente novamente` : 'Aguardando combinação com a transação do cartão.';
}
return '';
},
diff --git a/src/languages/zh-hans.ts b/src/languages/zh-hans.ts
index 9f5213a1..e6abb788 100644
--- a/src/languages/zh-hans.ts
+++ b/src/languages/zh-hans.ts
@@ -130,7 +130,6 @@ import type {
ZipCodeExampleFormatParams,
} from './params';
import type {TranslationDeepObject} from './types';
-
type StateValue = {
stateISO: string;
stateName: string;
@@ -530,6 +529,7 @@ const translations: TranslationDeepObject<typeof en> = {
year: '年份',
quarter: '季度',
expensifyLogo: 'Expensify徽标',
+ duplicateReport: '重复报销单',
},
socials: {
podcast: '在播客上关注我们',
@@ -5069,7 +5069,7 @@ _如需更详细的说明,请[访问我们的帮助网站](${CONST.NETSUITE_IM
updateCard: '更新卡片',
unassignCard: '取消分配卡片',
unassign: '取消分配',
- unassignCardDescription: '取消分配此卡将从持卡人的账户中移除所有处于草稿报表中的交易。',
+ unassignCardDescription: '取消分配此卡将从持卡人账户中移除所有处于草稿报表中的交易记录。',
assignCard: '分配卡片',
cardFeedName: '卡片交易源名称',
cardFeedNameDescription: '为该卡片流水命名一个唯一名称,以便与其他区分。',
@@ -6217,7 +6217,7 @@ ${reportName}
matchTypeContains: '包含',
matchTypeExact: '完全匹配',
duplicateRuleTitle: '已存在类似的商家规则',
- duplicateRulePrompt: (merchantName: string) => `即使已经有一条适用于“${merchantName}”的规则,是否仍要保存新规则?`,
+ duplicateRulePrompt: (merchantName: string) => `尽管你已经有一个现有规则,仍要为“${merchantName}”保存一个新规则吗?`,
saveAnyway: '仍然保存',
applyToExistingUnsubmittedExpenses: '应用到现有未提交的报销费用',
},
Note You can apply these changes to your branch by copying the patch to your clipboard, then running |
|
@Krishna2323 Can you update the translations? |
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
|
Translations updated. |
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
Valforte
left a comment
There was a problem hiding this comment.
Simple translation fix, but good otherwise
| quarter: 'Trimestre', | ||
| vacationDelegate: 'Delegado de férias', | ||
| expensifyLogo: 'Logo da Expensify', | ||
| duplicateReport: 'Relatório duplicado', |
There was a problem hiding this comment.
| duplicateReport: 'Relatório duplicado', | |
| duplicateReport: 'Duplicar relatório', |
As a brazilian myself this translation is wrong, please update it to the correct wording, while at it, please also update duplicateExpense above to Duplicar despesa
There was a problem hiding this comment.
Sorry for delay. Translations updated.
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
|
🚧 @Valforte has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/Valforte in version: 9.3.26-0 🚀
|
|
🚀 Deployed to production by https://github.com/puneetlath in version: 9.3.26-8 🚀
|
Explanation of Change
Fixed Issues
$ #82152
PROPOSAL:
Tests
N/A
Verify that no errors appear in the JS console
Offline tests
QA Steps
N/A
Verify that no errors appear in the JS console
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari