Update company card promo image#82609
Conversation
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
melvin-bot
Bot
requested review from
heyjennahay and
mkhutornyi
and removed request for
a team and
mkhutornyi
|
@mkhutornyi Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
melvin-bot
Bot
requested review from
a team,
mkhutornyi and
thienlnam
and removed request for
a team
|
@mkhutornyi @thienlnam One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
This is looking stellar! Awesome job. On mobile we should still use the same height of the illustration as this: 
It'll mean that the sides will be cut off but that's fine :) |
|
@dubielzyk-expensify Does this match what you had in mind? 
|
|
Yeah that looks great! Assuming it's using the same height as well? |
Yes, it uses the same height (220px) PR updated! |
|
Sweet. cc @Expensify/design for extra eyes. Otherwise we can move into a code review |
|
Looking good to me so far, let's get it into final review 🚀 |
Reviewer Checklist
Screenshots/VideosAndroid: HybridApp
Android: mWeb ChromeiOS: HybridApp
iOS: mWeb Safari
MacOS: Chrome / Safariweb.mov |
|
@nyomanjyotisa please merge main |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d7c34566e6
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| width: shouldUseNarrowLayout ? 680 : undefined, | ||
| height: shouldUseNarrowLayout ? 220 : undefined, |
There was a problem hiding this comment.
When shouldUseNarrowLayout is true, this style hard-codes the illustration to 680x220, so any viewport narrower than 680px (typical mobile) will clip the left/right sides because the card container uses overflow: 'hidden' (src/styles/index.ts, cardSectionContainer). This is a user-visible regression introduced by the new promo artwork path selection and affects all narrow layouts, so the narrow-layout branch should use a responsive width (or the condition should be inverted).
Useful? React with 👍 / 👎.
|
@mkhutornyi merged with the latest main |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3c83ef72fa
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| width: shouldUseNarrowLayout ? 680 : undefined, | ||
| height: shouldUseNarrowLayout ? 220 : undefined, |
There was a problem hiding this comment.
When shouldUseNarrowLayout is false, this style function returns {width: undefined, height: undefined} and is passed after styles.cardSectionIllustration in Section, which removes the default height: sectionIllustrationHeight/width: 'auto' sizing on desktop/tablet. Because the SVG is rendered with width="100%" and height="100%", the wrapper can collapse or render inconsistently (missing/cropped promo image) in wide-layout company card empty states. Return an empty object for wide layout instead of explicitly setting these keys to undefined.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Sorry, missed this one 😅
PR updated!
|
Codex Review: Didn't find any major issues. Swish! ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚧 @thienlnam has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/thienlnam in version: 9.3.26-0 🚀
|
|
🚀 Deployed to production by https://github.com/puneetlath in version: 9.3.26-8 🚀
|
6 participants
Explanation of Change
Update company card promo image to use specific illustrations based on workspace currency
Fixed Issues
$ #82220
PROPOSAL: #82220 (comment)
Tests
Same as QA Steps
Offline tests
Same as QA Steps
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android-Native.mp4
Android: mWeb Chrome
Android-mWeb.Chrome.mp4
iOS: Native
iOS-Native.mp4
iOS: mWeb Safari
iOS-mWeb.Safari.mp4
MacOS: Chrome / Safari
MacOS-Chrome.mp4