Move deleteReport to a separate file and use Onyx.connectWithoutView by bernhardoj · Pull Request #82481 · Expensify/App

bernhardoj · 2026-02-14T05:46:00Z

Explanation of Change

Fixed Issues

$ #73651
PROPOSAL:

Tests

Same as QA Steps

Verify that no errors appear in the JS console

Offline tests

Same as QA Steps

QA Steps

Go to Inbox
Press global create button > Create expense > Enter any amount
On the confirm page, select a new user that you have never chatted with before
Turn on Simulate failing network request
Create the expense
Since we turn on Simulate failing network request, the new report creation will fail
Press the error close button
Verify you are redirected to the concierge

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

android.mweb.mp4

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

web.mp4

melvin-bot · 2026-02-14T05:46:06Z

@alitoshmatov Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

melvin-bot · 2026-02-14T05:46:11Z

@brunovjk @MarioExpensify One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

bernhardoj · 2026-02-14T05:47:11Z

I believe @eVoloshchak will review this

codecov · 2026-02-14T05:54:56Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/libs/actions/ClearReportActionErrors.ts	`90.47% <ø> (ø)`
src/libs/actions/Report/index.ts	`69.19% <ø> (-0.17%)`	⬇️
src/libs/actions/Report/DeleteReport.ts	`95.83% <95.83%> (ø)`
... and 11 files with indirect coverage changes

eVoloshchak · 2026-02-17T10:30:11Z

+import deleteReport from '@libs/actions/Report/DeleteReport';
+import CONST from '@src/CONST';
+import ONYXKEYS from '@src/ONYXKEYS';
+import {ReportAction} from '@src/types/onyx';


Suggested change

import {ReportAction} from '@src/types/onyx';

import type {ReportAction} from '@src/types/onyx';

MarioExpensify

Awesome, thank you!

MarioExpensify · 2026-02-18T11:09:23Z

Woops, @eVoloshchak can you proceed with reviewer checklist please?

eVoloshchak · 2026-02-18T11:28:32Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

video_2026-06-11_21-48-43.mp4

Android: mWeb Chrome

video_2026-06-11_21-01-37.mp4

iOS: HybridApp

Screen.Recording.2026-06-11.at.20.56.17.mov

iOS: mWeb Safari

Screen.Recording.2026-06-11.at.20.52.57.mov

MacOS: Chrome / Safari

Screen.Recording.2026-06-11.at.20.51.30.mov

eVoloshchak · 2026-02-18T11:58:33Z

Turn on Simulate failing network request

Create an expense for a new user that you never chatted with before

Since we turn on Simulate failing network request, the new report creating will fail

Press the error close button

Verify you are redirected to concierge

@bernhardoj, this doesn't work on native (both iOS and Android), you're not redirected to Concierge.
Works properly on mWeb, though

Screen.Recording.2026-02-18.at.12.56.01.mov

Screen.Recording.2026-02-18.at.12.48.41.mov

MarioExpensify · 2026-02-18T12:11:34Z

@bernhardoj please address @eVoloshchak's comments, also, please don't forget to add proper screenshots/videos for each platform.

bernhardoj · 2026-02-18T15:30:45Z

this doesn't work on native (both iOS and Android)

Hmm, this is because inlineRequires, which imports the file/module when the function is called for the first time. So, when it's called for the first time, the report collection is empty.

bernhardoj · 2026-06-04T03:52:05Z

The Onyx fix is done a week ago, @eVoloshchak this is now ready for your review again.

luacmartins · 2026-06-08T19:28:03Z

@eVoloshchak bump

eVoloshchak · 2026-06-09T06:09:37Z

Turn on Simulate failing network request

Create an expense for a new user that you never chatted with before

Since we turn on Simulate failing network request, the new report creating will fail

@bernhardoj, those steps don't work for me anymore, there is no error on report creation, the app just falls back into the offline mode

Screen.Recording.2026-06-09.at.07.55.59.mov

Screen.Recording.2026-06-09.at.07.54.05.mov

bernhardoj · 2026-06-09T08:21:48Z

@eVoloshchak I've adjusted the test step. Please try again

eVoloshchak · 2026-06-09T13:03:39Z

@bernhardoj, I think we'll need different steps. The behavior for narrow screen layout has changed, we don't redirect to the actual chat after submitting the expense

Screen.Recording.2026-06-09.at.14.56.27.mov

Screen.Recording.2026-06-09.at.14.57.35.mov

luacmartins · 2026-06-09T14:43:48Z

Additionally, ESlint is failing

bernhardoj · 2026-06-09T15:09:55Z

Added 1. Go to Inbox to the test step so the report opens after creating the expense.

Merged with main to fix the lint

eVoloshchak · 2026-06-10T17:22:12Z

@bernhardoj, this still doesn't work for me, could you please double-check if you're seeing the same behavior?

Screen.Recording.2026-06-10.at.19.19.16.mov

Screen.Recording.2026-06-10.at.19.16.55.mov

Screen.Recording.2026-06-10.at.19.16.03.mov

bernhardoj · 2026-06-11T03:40:04Z

Verify you are redirected to the concierge

Hmm, looks like something changed. You mean that this is not happening anymore, right?

bernhardoj · 2026-06-11T03:46:12Z

If you let it load for a few seconds, there will be another error in the middle. Press that one.

The error at the bottom will simply go back and doesn't call deleteReport.

App/src/pages/inbox/ReportScreen.tsx

Lines 98 to 102 in 674cd8c

    
           const dismissReportCreationError = () => { 
        
               Navigation.goBack(undefined, { 
        
                   afterTransition: () => removeFailedReport(reportIDFromRoute), 
        
               }); 
        
           };

bernhardoj · 2026-06-11T03:59:45Z

Unrelated lint

eVoloshchak

LGTM!

luacmartins

@bernhardoj ESLint is failing

bernhardoj · 2026-06-12T05:53:50Z

@luacmartins lint error gone

github-actions · 2026-06-12T14:13:28Z

🚧 @luacmartins has triggered a test Expensify/App build. You can view the workflow run here.

OSBotify · 2026-06-12T14:19:30Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2026-06-12T14:20:09Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #82481.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-8cc36983d36-fdf5089-17e253a13eab48f52d50a15114f135053253a0c5/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-8cc3698-fdf5089-650edc9b3cb6c0f73289cc8bd9a01e70bb83cf4b/index.html

Web 🕸️
https://82481.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-06-12T22:03:32Z

🚀 Deployed to staging by https://github.com/luacmartins in version: 9.4.7-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

MelvinBot · 2026-06-12T22:05:22Z

Help site review — no docs changes required

I reviewed the changes in this PR and no help site documentation updates are required.

Why: This is a purely internal code refactor with no user-facing impact:

Moves the deleteReport function out of src/libs/actions/Report/index.ts into a new dedicated file src/libs/actions/Report/DeleteReport.ts.
Switches the Onyx subscriptions to Onyx.connectWithoutView to avoid unnecessary re-renders.
Adds unit tests (tests/unit/DeleteReportTest.ts) and updates imports.

There are no changes to features, UI, button labels, tab names, settings, billing, workspaces, or integrations — nothing that the articles under docs/articles describe. Since no behavior visible to customers changed, there is nothing to document, so I did not create a draft docs PR.

@bernhardoj, since no help site changes were needed, there is no docs PR to review. If you believe this refactor does change documented behavior, reply with details and I'll take another look.

OSBotify · 2026-06-15T17:52:45Z

🚀 Deployed to production by https://github.com/puneetlath in version: 9.4.7-4 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

replace with connectWithoutView

e0c0dfc

bernhardoj requested review from a team as code owners February 14, 2026 05:46

melvin-bot Bot assigned bernhardoj Feb 14, 2026

melvin-bot Bot requested review from alitoshmatov and heyjennahay February 14, 2026 05:46

melvin-bot Bot requested review from a team, MarioExpensify and brunovjk and removed request for a team February 14, 2026 05:46

bernhardoj added 2 commits February 14, 2026 13:48

lint

e9e6333

lint

d092763

bernhardoj added 2 commits February 14, 2026 14:20

prettier

59e41f1

add test

e681c5e

eVoloshchak suggested changes Feb 17, 2026

View reviewed changes

lint

37f7779

MarioExpensify approved these changes Feb 18, 2026

View reviewed changes

MarioExpensify removed the request for review from brunovjk February 18, 2026 11:09

MarioExpensify self-requested a review February 18, 2026 12:10

luacmartins requested a review from eVoloshchak June 4, 2026 21:45

Merge branch 'main' into chore/73651-use-connect-without-view

f966310

Merge branch 'main' into chore/73651-use-connect-without-view

f1d6f68

Merge branch 'main' into chore/73651-use-connect-without-view

af51bcf

eVoloshchak approved these changes Jun 11, 2026

View reviewed changes

luacmartins requested changes Jun 11, 2026

View reviewed changes

Comment thread src/libs/actions/Report/DeleteReport.ts

luacmartins approved these changes Jun 11, 2026

View reviewed changes

Comment thread src/libs/actions/Report/DeleteReport.ts

Merge branch 'main' into chore/73651-use-connect-without-view

b82bdf2

luacmartins merged commit 8cc3698 into Expensify:main Jun 12, 2026
31 checks passed

OSBotify mentioned this pull request Jun 12, 2026

Deploy Checklist: New Expensify 2026-06-12 #93470

Closed

62 tasks

applause-bot Bot mentioned this pull request Jun 14, 2026

[Exploratory] Expense- Infinite loading and failed report appear after toggle off network fail #93542

Open

7 tasks

melvin-bot Bot mentioned this pull request Jun 15, 2026

Remove Onyx.connect() for the key: ONYXKEYS.COLLECTION.REPORT_ACTIONS in src/libs/actions/Report.ts #73651

Open

	import {ReportAction} from '@src/types/onyx';
	import type {ReportAction} from '@src/types/onyx';

Uh oh!

Conversation

bernhardoj commented Feb 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Feb 14, 2026

Uh oh!

melvin-bot Bot commented Feb 14, 2026

Uh oh!

bernhardoj commented Feb 14, 2026

Uh oh!

codecov Bot commented Feb 14, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

eVoloshchak Feb 17, 2026

Choose a reason for hiding this comment

Uh oh!

MarioExpensify left a comment

Choose a reason for hiding this comment

Uh oh!

MarioExpensify commented Feb 18, 2026

Uh oh!

eVoloshchak commented Feb 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

eVoloshchak commented Feb 18, 2026

Uh oh!

MarioExpensify commented Feb 18, 2026

Uh oh!

bernhardoj commented Feb 18, 2026

Uh oh!

bernhardoj commented Jun 4, 2026

Uh oh!

luacmartins commented Jun 8, 2026

Uh oh!

eVoloshchak commented Jun 9, 2026

Uh oh!

bernhardoj commented Jun 9, 2026

Uh oh!

eVoloshchak commented Jun 9, 2026

Uh oh!

luacmartins commented Jun 9, 2026

Uh oh!

bernhardoj commented Jun 9, 2026

Uh oh!

eVoloshchak commented Jun 10, 2026

Uh oh!

bernhardoj commented Jun 11, 2026

Uh oh!

bernhardoj commented Jun 11, 2026

Uh oh!

bernhardoj commented Jun 11, 2026

Uh oh!

eVoloshchak left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

luacmartins left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

bernhardoj commented Jun 12, 2026

Uh oh!

Uh oh!

github-actions Bot commented Jun 12, 2026

Uh oh!

OSBotify commented Jun 12, 2026

Uh oh!

github-actions Bot commented Jun 12, 2026

bernhardoj commented Feb 14, 2026 •

edited

Loading

codecov Bot commented Feb 14, 2026 •

edited by github-actions Bot

Loading

eVoloshchak commented Feb 18, 2026 •

edited

Loading

luacmartins left a comment •

edited

Loading