Resolve `@ts-expect-error` comments related to OnyxUpdate changes - first batch by OlGierd03 · Pull Request #82255 · Expensify/App

OlGierd03 · 2026-02-12T12:57:01Z

Explanation of Change

This PR resolves the first batch of @ts-expect-error - will be solved in https://github.com/Expensify/App/issues/73830 comments, which are now ready to be addressed as shown in the issue progress overview

Fixed Issues

$ #73830

Tests

src/libs/actions/IOU/index.ts - buildOnyxDataForMoneyRequest

IOU_index.ts_2225.mp4

Prereq: Use a new account where you have never sent an expense or scanned a receipt.

+ button > Create new Expense
When in the Scan tab, verify you encounter a tooltip with content encouraging you to try scanning your first receipt
In tooltip > Try it out > Create expense
+ button > Create new Expense
When in the Scan tab, verify you do NOT encounter the same tooltip as before

src/libs/actions/IOU/index.ts - trackExpense

IOUindex.ts_7568.mp4

+ button > Track Distance
Notice the tab that is opened (Map/Manual/GPS)
Switch to a different tab and continue creating an Expense
After the expense has been created, once more open + button > Track Distance
Verify you're on the tab in which you most recently created an expense

src/libs/actions/IOU/index.ts - rejectMoneyRequest (`optimisticData`)

IOUindex.ts_13565_short.mp4

Prereq: 2 accounts in the same workspace with approve workflow enabled (1 member account, 1 approver account)

Member: Create a new Expense
Member: Submit created expense
Approver: Reject submitted expense
Member: Notice the violetion 'The expense was rejected'
Member: Press Mark as resolved
Member: Notice the violation optimistically disappearing

src/libs/actions/IOU/index.ts - rejectMoneyRequest (`failureData`)

IOUindex.ts_1362.mp4

Prereq: 2 accounts in the same workspace with approve workflow enabled (1 member account, 1 approver account)

Member: Create a new Expense
Member: Submit created expense
Approver: Reject submitted expense
Member: Notice the violetion 'The expense was rejected'
Member: Navigate to Account > TroubleShoot > Toggle Simulate failing network requests
Member: Navigate back to rejected expense
Member: Press Mark as resolved
Member: Notice the violation does not disappearing

src/libs/actions/Policy/Member.ts - removeMembers

Policy_Member.ts_519.mp4

Log in as a workspace admin with at least one other member who has a workspace chat
Go to Workspaces > [your workspace] > Members
Select one or more members via checkbox
Click Remove member > Remove
Notice the workspace chats with the removed member(s) become archived immediately (optimistic update)

src/libs/actions/Report/index.ts - buildNewReportOptimisticData

Report_index.ts.mp4

Navigate to Account > TroubleShoot > Toggle Simulate failing network requests
Go to Inbox > [your workspace] > + > Create Report
Click 'created' report
Notice error Unexpected error creating this chat. Please try again later. appears

src/libs/actions/Search.ts - getOnyxLoadingData

AfterChange.mov

Navigate to Search
Use the filter to display a subset of items
Navigate to Account > TroubleShoot > Toggle Simulate failing network requests
Navigate back to Search and notice error Oops... Something went wrong appears
Change filter and see how the change affects the results. The error Oops... Something went wrong should appear again

Offline tests

N/A

QA Steps

Same as tests

PR Author Checklist

Screenshots/Videos

For the convenience of the reviewer, all the videos have been attached in the test steps for the appropriate cases.

Note

The changes in this PR are platform indifferent as they are only onyx-related

…to @OlGierd03/remove-all-ts-expect-errors-comments

codecov · 2026-02-17T14:50:13Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/hooks/useSearchLoadingState.ts	`100.00% <100.00%> (ø)`
src/libs/SearchUIUtils.ts	`63.48% <100.00%> (-0.29%)`	⬇️
src/libs/TransactionUtils/index.ts	`83.58% <100.00%> (+0.08%)`	⬆️
src/libs/actions/Card.ts	`0.00% <ø> (ø)`
src/libs/actions/IOU/RejectMoneyRequest.ts	`70.33% <100.00%> (+0.28%)`	⬆️
src/libs/actions/IOU/Split.ts	`80.52% <100.00%> (+0.02%)`	⬆️
src/libs/actions/IOU/index.ts	`80.18% <100.00%> (+0.01%)`	⬆️
src/libs/actions/MergeTransaction.ts	`62.88% <100.00%> (+0.19%)`	⬆️
src/libs/actions/Policy/Member.ts	`74.60% <100.00%> (ø)`
src/libs/actions/Policy/Policy.ts	`69.24% <100.00%> (+0.07%)`	⬆️
... and 11 more
... and 39 files with indirect coverage changes

…to @OlGierd03/remove-all-ts-expect-errors-comments

OlGierd03 · 2026-04-16T11:21:36Z

It's ready now. I've resolved the mentioned conflicts and made sure that the most problematic change won't cause regression. I've also added extra test steps to help you test it (src/libs/actions/Search.ts - getOnyxLoadingData)

…rorView

OlGierd03 · 2026-04-16T11:43:51Z

@codex review

chatgpt-codex-connector · 2026-04-16T11:59:57Z

Codex Review: Didn't find any major issues. Nice work!

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

OlGierd03 · 2026-04-16T18:37:22Z

It's ready now. I've resolved the mentioned conflicts and made sure that the most problematic change won't cause regression. I've also added extra test steps to help you test it (src/libs/actions/Search.ts - getOnyxLoadingData)

@abzokhattab all yours

abzokhattab · 2026-04-16T18:38:17Z

Awesome .. thanks for the hard work.. i am looking into it now

abzokhattab · 2026-04-16T23:37:01Z

@codex review

abzokhattab · 2026-04-16T23:37:07Z

@MelvinBot review

MelvinBot · 2026-04-16T23:41:26Z

Deep Review

Verdict: No blocking issues. All @ts-expect-error removals are type-correct and the behavioral changes are intentional fixes, not regressions.

Search failure handling (highest-risk change)

The data: [] → data: null change in getOnyxLoadingData is correct. SearchResults.data is a Record type, so the old [] was already a type mismatch. The new error-handling chain works end-to-end:

Failure sets data: null + errors: {...}
useSearchLoadingState sees errors → returns false (no skeleton)
isSearchDataLoaded treats errors as "loaded" → Search mounts
!searchResults.data guards in Search/index.tsx prevent data processing
FullPageErrorView renders

The guards at Search/index.tsx:501 and SearchPage.tsx:60 correctly handle the null case. Array.isArray(null) returns false, so existing loading-state checks in SearchPageWide and SearchPageNarrow also behave correctly.

`?? null` pattern (bulk of changes)

All correct. Onyx's OnyxInputValue is explicitly TOnyxValue | null — undefined is forbidden because it's a no-op that would leave stale optimistic data. The ?? null coercion converts OnyxEntry<T> (which includes undefined) to a valid Onyx input. This applies consistently across RejectMoneyRequest, Split, MergeTransaction, Policy, Report/index, Transaction, and Search.

Type-level fixes (all verified)

Change	Verification
`errorFields` → `errors`	`ReportAction` has `errors`, not `errorFields`. Consumer reads `action.errors`
`private_isArchived: true/false` → `currentTime/null`	Type is `string \| undefined`, not boolean
`dismissedMethod: 'click' as const`	Type expects `'click' \| 'x'` literal union
`lastTravelSignupRequestTime: Date.now().toString()`	Type is `string`
`cardID: cardID.toString()`	Form values expect `string`
`DistanceExpenseType` expanded	Added `DISTANCE_GPS` and `DISTANCE_ODOMETER` to match all distance request types
`reportNextStep` threaded through `changeReportPolicyAndInviteSubmitter`	Caller reads from Onyx and passes correctly; fixes the `undefined` that was previously hardcoded

Minor observations (non-blocking)

OnyxSearchResponse type at Search.ts:90 still defines data: [] (empty tuple) — stale typing that could be cleaned up separately
dismissedMethod: 'click' is correctly added to the buildOnyxDataForMoneyRequest tooltip dismissal (matching the pattern in Welcome/index.ts)

Overall this is a well-executed batch of type fixes with thorough test coverage for the behavioral changes.

chatgpt-codex-connector · 2026-04-16T23:51:45Z

Codex Review: Didn't find any major issues. Can't wait for the next one!

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

abzokhattab · 2026-04-17T01:04:53Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2026-04-14.at.01.14.10.mov

Screen.Recording.2026-04-14.at.01.14.43.mov

Screen.Recording.2026-04-14.at.02.23.10.mov

Screen.Recording.2026-04-14.at.02.23.35.mov

Screen.Recording.2026-04-17.at.02.47.30.mov

Screen.Recording.2026-04-17.at.02.49.01.mov

abzokhattab

LGTM

OSBotify · 2026-04-17T17:23:31Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2026-04-17T17:24:20Z

🚧 @Julesssss has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-04-17T17:30:15Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #82255.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-7a1ef5f-08b118a-43f34e286f96e608f87216e842a0d11c7a88c9c1/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-7a1ef5f-08b118a-baaedaf7ff6a2fd5dc1a5f82542e0e43c9541b84/index.html

Web 🕸️
https://82255.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-04-21T11:35:37Z

🚀 Deployed to staging by https://github.com/Julesssss in version: 9.3.61-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

MelvinBot · 2026-04-21T11:36:56Z

I reviewed the changes in this PR. It resolves @ts-expect-error TypeScript suppression comments related to OnyxUpdate type changes — purely internal type fixes across action files, utils, and tests.

No help site documentation changes are required. There are no user-facing feature additions, UI changes, or workflow modifications in this PR.

jponikarchuk · 2026-04-21T12:36:40Z

This PR failing because of the issue #88423
This issue is reproducible in: Web

jponikarchuk · 2026-04-21T12:36:55Z

Deploy Blocker #88423 was identified to be related to this PR.

OlGierd03 · 2026-04-22T11:21:12Z

This PR failing because of the issue #88423 This issue is reproducible in: Web

It has been confirmed that the issue is unrelated to this PR and it has now been demoted

OSBotify · 2026-04-23T19:55:15Z

🚀 Deployed to production by https://github.com/marcaaron in version: 9.3.61-4 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Remove @ts-expect-error comments

d7a0231

melvin-bot Bot assigned OlGierd03 Feb 12, 2026

MarioExpensify self-requested a review February 12, 2026 20:31

OlGierd03 added 8 commits February 13, 2026 16:41

Merge '@OlGierd03/replace_union_OnyxKey_type_seventh_batch' branch

0c51a22

Remove comments

5097362

Remove @ts-expect-error comments

78aacfc

Merge branch '@OlGierd03/replace_union_OnyxKey_type_seventh_batch' in…

9c896df

…to @OlGierd03/remove-all-ts-expect-errors-comments

Remove @ts-expect-error comments

f1d6970

Remove @ts-expect-error comments

8ab0366

Remove @ts-expect-error comment

f5dc884

Delete unnecessary errors prop with null value

fd288e5

OlGierd03 force-pushed the @OlGierd03/remove-all-ts-expect-errors-comments branch from 27298bc to fd288e5 Compare February 17, 2026 14:46

OlGierd03 added 5 commits February 19, 2026 12:00

Merge branch '@OlGierd03/replace_union_OnyxKey_type_seventh_batch' in…

732f2b5

…to @OlGierd03/remove-all-ts-expect-errors-comments

Merge 'main' branch

9900cf2

Merge branch 'main' into @OlGierd03/remove-all-ts-expect-errors-comments

7579598

Run prettier

48079c5

Fix failing test

e2ee140

OlGierd03 mentioned this pull request Feb 24, 2026

[Due for payment 2026-05-11] [$250] Restore Type Safety for Onyx.update() #73830

Closed

Merge 'main' branch

b5650d2

OlGierd03 changed the title ~~Resolve all @ts-expect-error - will be solved in https://github.com/Expensify/App/issues/73830 comments - first batch~~ Resolve @ts-expect-error comments related to OnyxUpdate changes - first batch Feb 24, 2026

OlGierd03 added 5 commits March 9, 2026 14:35

Merge branch 'main' into @OlGierd03/remove-all-ts-expect-errors-comments

b337b37

Merge 'main' branch

c81a98a

Merge branch 'main' into @OlGierd03/remove-all-ts-expect-errors-comments

eba5878

Correct previous changes in Report, Search and Transaction

0c39f96

Merge branch 'main' into @OlGierd03/remove-all-ts-expect-errors-comments

6ab13cb

OlGierd03 mentioned this pull request Mar 20, 2026

Resolve @ts-expect-error comments related to OnyxUpdate changes - second batch #82786

Merged

51 tasks

OlGierd03 force-pushed the @OlGierd03/remove-all-ts-expect-errors-comments branch from d94f8f2 to a3742c6 Compare April 16, 2026 09:42

Merge main and resolve conflicts

cc777df

Let Search mount when errorrs are present so it can render FullPageEr…

7495f4f

…rorView

abzokhattab approved these changes Apr 17, 2026

View reviewed changes

melvin-bot Bot requested a review from Julesssss April 17, 2026 01:05

Julesssss approved these changes Apr 17, 2026

View reviewed changes

Julesssss merged commit 7a1ef5f into Expensify:main Apr 17, 2026
34 checks passed

OSBotify mentioned this pull request Apr 21, 2026

Deploy Checklist: New Expensify 2026-04-21 #88394

Closed

jponikarchuk mentioned this pull request Apr 21, 2026

[HOLD #87170]Create - No "Try it out" toolpit displayed while creating first scan expense. #88423

Closed

7 tasks

unzig21 mentioned this pull request Apr 22, 2026

[Due for payment 2026-05-13] [$250] 88394 - PR82255 - Unexpected error does not appear in created report after enabling Failing network #88500

Closed

7 tasks

Uh oh!

Conversation

OlGierd03 commented Feb 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov Bot commented Feb 17, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

OlGierd03 commented Apr 16, 2026

Uh oh!

OlGierd03 commented Apr 16, 2026

Uh oh!

chatgpt-codex-connector Bot commented Apr 16, 2026

Uh oh!

OlGierd03 commented Apr 16, 2026

Uh oh!

abzokhattab commented Apr 16, 2026

Uh oh!

abzokhattab commented Apr 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

abzokhattab commented Apr 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

MelvinBot commented Apr 16, 2026

Deep Review

Search failure handling (highest-risk change)

?? null pattern (bulk of changes)

Type-level fixes (all verified)

Minor observations (non-blocking)

Uh oh!

chatgpt-codex-connector Bot commented Apr 16, 2026

Uh oh!

abzokhattab commented Apr 17, 2026

Reviewer Checklist

Screenshots/Videos

Uh oh!

abzokhattab left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Apr 17, 2026

Uh oh!

github-actions Bot commented Apr 17, 2026

Uh oh!

github-actions Bot commented Apr 17, 2026

Uh oh!

OSBotify commented Apr 21, 2026

Uh oh!

MelvinBot commented Apr 21, 2026

Uh oh!

jponikarchuk commented Apr 21, 2026

Uh oh!

jponikarchuk commented Apr 21, 2026

Uh oh!

OlGierd03 commented Apr 22, 2026

Uh oh!

OSBotify commented Apr 23, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

OlGierd03 commented Feb 12, 2026 •

edited

Loading

codecov Bot commented Feb 17, 2026 •

edited by github-actions Bot

Loading

abzokhattab commented Apr 16, 2026 •

edited

Loading

abzokhattab commented Apr 16, 2026 •

edited

Loading

`?? null` pattern (bulk of changes)