Skip to content

[No QA] Adjust CLEAN-REACT-PATTERNS-1 review rule #82109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Julesssss merged 1 commit into from
Feb 12, 2026
Merged

[No QA] Adjust CLEAN-REACT-PATTERNS-1 review rule #82109

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 10 additions & 7 deletions .claude/agents/code-inline-reviewer.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1049,22 +1049,25 @@ async function submitForm(data: FormData) {

### [CLEAN-REACT-PATTERNS-1] Favor composition over configuration

- **Search patterns**: `shouldShow`, `shouldEnable`, `canSelect`, `enable`, `disable`, configuration props patterns
- **Search patterns**: `should\w+` (any prop starting with `should`), `canSelect`, `enable`, `disable`, configuration props patterns

- **Condition**: Flag ONLY when ALL of these are true:

- A **new feature** is being introduced OR an **existing component's API is being expanded with new props**
- The change adds configuration properties (flags, conditional logic)
- These configuration options control feature presence or behavior within the component
- These features could instead be expressed as composable child components
- Any of these scenarios apply:
- A **new feature** is being introduced
- An **existing component's API** is being expanded with new props
- A **refactoring** creates a new component that still has boolean configuration props matching the search patterns controlling branching logic — refactoring is an opportunity to eliminate configuration flags, not preserve them
- The component contains boolean props matching the search patterns that cause `if/else` or ternary branching inside the component body
- These configuration options control feature presence, layout strategy, or behavior within the component

**Features that should be expressed as child components:**
**Features that should NOT be controlled by boolean flags:**
- Optional UI elements that could be composed in
- New behavior that could be introduced as new children
- Features that currently require parent component code changes
- Layout strategy variants

**DO NOT flag if:**
- Props are narrow, stable values needed for coordination between composed parts (e.g., `reportID`, `data`, `columns`)
- Props are non-boolean data values needed for coordination between composed parts (e.g., `reportID`, `data`, `columns`).
- The component uses composition and child components for features
- Parent components stay stable as features are added

Expand Down
Loading