Skip to content

Move "Create report" in the "Move expenses" flow to the top of the list #82076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jasperhuangg merged 5 commits into from
Feb 19, 2026
Merged

Move "Create report" in the "Move expenses" flow to the top of the list #82076

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
dfd6275
Move 'Create report' in the 'Move expenses' flow to the top of the list
nyomanjyotisa Feb 11, 2026
d82da4e
Merge branch 'main' into issue-81555
nyomanjyotisa Feb 13, 2026
395c1a9
Show Create report at top and avoid scroll in move expenses flow
nyomanjyotisa Feb 13, 2026
da7b2e4
Rename prop to shouldScrollToFocusedIndexOnMount
nyomanjyotisa Feb 17, 2026
3c1ff96
Merge branch 'main' into issue-81555
nyomanjyotisa Feb 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/components/SelectionList/BaseSelectionList.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,7 @@ function BaseSelectionList<TItem extends ListItem>({
shouldStopPropagation = false,
shouldHeaderBeInsideList = false,
shouldScrollToFocusedIndex = true,
shouldScrollToFocusedIndexOnMount = true,
shouldDebounceScrolling = false,
shouldUpdateFocusedIndex = false,
shouldSingleExecuteRowSelect = false,
Expand Down Expand Up @@ -526,7 +527,7 @@ function BaseSelectionList<TItem extends ListItem>({
onEndReachedThreshold={onEndReachedThreshold}
style={style?.listStyle}
contentContainerStyle={styles.pb3}
initialScrollIndex={initialFocusedIndex}
initialScrollIndex={shouldScrollToFocusedIndexOnMount ? initialFocusedIndex : undefined}
onScrollBeginDrag={onScrollBeginDrag}
maintainVisibleContentPosition={{disabled: disableMaintainingScrollPosition}}
ListHeaderComponent={
Expand Down
3 changes: 3 additions & 0 deletions src/components/SelectionList/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,9 @@ type BaseSelectionListProps<TItem extends ListItem> = {
/** Whether to scroll to the focused item */
shouldScrollToFocusedIndex?: boolean;

/** Whether to scroll to the focused item on mount. When false, the list stays at the top to keep header content visible */
Comment thread
jasperhuangg marked this conversation as resolved.
shouldScrollToFocusedIndexOnMount?: boolean;

/** Whether keyboard shortcuts should be disabled */
disableKeyboardShortcuts?: boolean;

Expand Down
21 changes: 10 additions & 11 deletions src/pages/iou/request/step/IOURequestEditReportCommon.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -289,19 +289,18 @@ function IOURequestEditReportCommon({
}}
shouldSingleExecuteRowSelect
initiallyFocusedItemKey={selectedReportID}
shouldScrollToFocusedIndexOnMount={!createReportOption}
ListItem={InviteMemberListItem}
customListHeaderContent={createReportOption}
listFooterContent={
<>
{shouldShowRemoveFromReport && (
<MenuItem
onPress={removeFromReport}
title={translate('iou.removeFromReport')}
description={translate('iou.moveToPersonalSpace')}
icon={icons.Close}
/>
)}
{createReportOption}
</>
shouldShowRemoveFromReport ? (
<MenuItem
onPress={removeFromReport}
title={translate('iou.removeFromReport')}
description={translate('iou.moveToPersonalSpace')}
icon={icons.Close}
/>
) : undefined
}
listEmptyContent={createReportOption}
/>
Expand Down
Loading